Feature 1255 : limit params in sql queries were in wrong order (LIMIT…

… count OFFSET offset) git-svn-id: http://piwigo.org/svn/trunk@4334 68402e56-0260-453c-a942-63ccdbb3a9ee
Piwigo · Nov 21, 2009 · ce3fe0d · ce3fe0d
1 parent daa877a
commit ce3fe0d
Show file tree

Hide file tree

Showing 14 changed files with 21 additions and 23 deletions.
diff --git a/admin/cat_perm.php b/admin/cat_perm.php
@@ -59,7 +59,7 @@
 SELECT id
   FROM '.CATEGORIES_TABLE.'
   WHERE status = \'private\'
-  LIMIT 0 OFFSET 1
+  LIMIT 1
 ;';
 
   list($page['cat']) = pwg_db_fetch_row(pwg_query($query));

diff --git a/admin/element_set_global.php b/admin/element_set_global.php
@@ -474,13 +474,11 @@
   FROM '.IMAGES_TABLE.'
   WHERE id IN ('.implode(',', $page['cat_elements_id']).')
   '.$conf['order_by'].'
-  LIMIT '.$page['start'].' OFFSET '.$page['nb_images'].'
+  LIMIT '.$page['nb_images'].' OFFSET '.$page['start'].'
 ;';
-  //echo '<pre>'.$query.'</pre>';
   $result = pwg_query($query);
 
   // template thumbnail initialization
-
   while ($row = pwg_db_fetch_assoc($result))
   {
     $src = get_thumbnail_url($row);

diff --git a/admin/element_set_unit.php b/admin/element_set_unit.php
@@ -196,7 +196,7 @@
   FROM '.IMAGES_TABLE.'
   WHERE id IN ('.implode(',', $page['cat_elements_id']).')
   '.$conf['order_by'].'
-  LIMIT '.$page['start'].' OFFSET '.$page['nb_images'].'
+  LIMIT '.$page['nb_images'].' OFFSET '.$page['start'].'
 ;';
   $result = pwg_query($query);
 

diff --git a/admin/include/functions.php b/admin/include/functions.php
@@ -597,7 +597,7 @@ function set_random_representant($categories)
   FROM '.IMAGE_CATEGORY_TABLE.'
   WHERE category_id = '.$category_id.'
   ORDER BY '.DB_RANDOM_FUNCTION.'()
-  LIMIT 0 OFFSET 1
+  LIMIT 1
 ;';
     list($representative) = pwg_db_fetch_row(pwg_query($query));
 

diff --git a/admin/include/functions_history.inc.php b/admin/include/functions_history.inc.php
@@ -161,7 +161,7 @@ function get_history($data, $search, $types)
   WHERE '.$where_separator.'
 ;';
 
-  // LIMIT '.$page['start'].' OFFSET '.$conf['nb_logs_page'].'
+  // LIMIT '.$conf['nb_logs_page'].' OFFSET '.$page['start'].'
 
   $result = pwg_query($query);
 

diff --git a/admin/rating.php b/admin/rating.php
@@ -176,7 +176,7 @@
   WHERE 1 = 1 ' . $page['user_filter'] . '
   GROUP BY r.element_id
   ORDER BY ' . $available_order_by[$order_by_index][1] .'
-  LIMIT '.$start.' OFFSET '.$elements_per_page.'
+  LIMIT '.$elements_per_page.' OFFSET '.$start.'
 ;';
 
 $images = array();

diff --git a/comments.php b/comments.php
@@ -326,7 +326,7 @@
 if ('all' != $page['items_number'])
 {
   $query.= '
-  LIMIT '.$start.' OFFSET '.$page['items_number'];
+  LIMIT '.$page['items_number'].' OFFSET '.$start;
 }
 $query.= '
 ;';

diff --git a/include/calendar_monthly.class.php b/include/calendar_monthly.class.php
@@ -348,7 +348,7 @@ function build_month_calendar(&$tpl_var)
     $query.= $this->get_date_where();
     $query.= '
   ORDER BY RAND()
-  LIMIT 0 OFFSET 1';
+  LIMIT 1';
     unset ( $page['chronology_date'][CDAY] );
 
     $row = pwg_db_fetch_assoc(pwg_query($query));

diff --git a/include/category_cats.inc.php b/include/category_cats.inc.php
@@ -105,7 +105,7 @@
       "\n  AND"
     ).'
   ORDER BY RAND()
-  LIMIT 0,1
+  LIMIT 1
 ;';
       $subresult = pwg_query($query);
       if (pwg_db_num_rows($subresult) > 0)
@@ -133,7 +133,7 @@
       "\n  AND"
     ).'
     ORDER BY RAND()
-    LIMIT 0,1
+    LIMIT 1
   ;';
       $subresult = pwg_query($query);
       if (pwg_db_num_rows($subresult) > 0)

diff --git a/include/functions_notification.inc.php b/include/functions_notification.inc.php
@@ -444,7 +444,7 @@ function get_recent_post_dates($max_dates, $max_elements, $max_cats)
   '.$where_sql.'
   GROUP BY date_available
   ORDER BY date_available DESC
-  LIMIT 0 OFFSET '.$max_dates.'
+  LIMIT '.$max_dates.'
 ;';
   $result = pwg_query($query);
   $dates = array();
@@ -464,7 +464,7 @@ function get_recent_post_dates($max_dates, $max_elements, $max_cats)
     AND date_available="'.$dates[$i]['date_available'].'"
     AND tn_ext IS NOT NULL
   ORDER BY RAND(NOW())
-  LIMIT 0 OFFSET '.$max_elements.'
+  LIMIT '.$max_elements.'
 ;';
       $dates[$i]['elements'] = array();
       $result = pwg_query($query);
@@ -484,7 +484,7 @@ function get_recent_post_dates($max_dates, $max_elements, $max_cats)
     AND date_available="'.$dates[$i]['date_available'].'"
   GROUP BY category_id
   ORDER BY img_count DESC
-  LIMIT 0 OFFSET '.$max_cats.'
+  LIMIT '.$max_cats.'
 ;';
       $dates[$i]['categories'] = array();
       $result = pwg_query($query);

diff --git a/include/functions_tag.inc.php b/include/functions_tag.inc.php
@@ -239,7 +239,7 @@ function get_common_tags($items, $max_tags, $excluded_tag_ids=null)
   {
     $query .= '
   ORDER BY counter DESC
-  LIMIT 0,'.$max_tags;
+  LIMIT '.$max_tags;
   }
   else
   {

diff --git a/include/section_init.inc.php b/include/section_init.inc.php
@@ -490,7 +490,7 @@
   WHERE hit > 0
     '.$forbidden.'
     '.$conf['order_by'].'
-  LIMIT 0, '.$conf['top_number'].'
+  LIMIT '.$conf['top_number'].'
 ;';
 
     $page = array_merge(
@@ -517,7 +517,7 @@
   WHERE average_rate IS NOT NULL
     '.$forbidden.'
     '.$conf['order_by'].'
-  LIMIT 0, '.$conf['top_number'].'
+  LIMIT '.$conf['top_number'].'
 ;';
     $page = array_merge(
       $page,

diff --git a/include/ws_functions.inc.php b/include/ws_functions.inc.php
@@ -292,7 +292,7 @@ function ws_categories_getImages($params, &$service)
     AND ', $where_clauses).'
 GROUP BY i.id
 '.$order_by.'
-LIMIT '.(int)($params['per_page']*$params['page']).' OFFSET '.(int)$params['per_page'];
+LIMIT '.(int)$params['per_page'].' OFFSET '.(int)($params['per_page']*$params['page']);
 
     $result = pwg_query($query);
     while ($row = pwg_db_fetch_assoc($result))
@@ -682,8 +682,8 @@ function ws_images_getInfo($params, &$service)
   FROM '.COMMENTS_TABLE.'
   WHERE '.$where_comments.'
   ORDER BY date
-  LIMIT '.(int)($params['comments_per_page']*$params['comments_page']).
-    ' OFFSET '.(int)$params['comments_per_page'];
+  LIMIT '.(int)$params['comments_per_page'].
+    ' OFFSET '.(int)($params['comments_per_page']*$params['comments_page']);
 
     $result = pwg_query($query);
     while ($row = pwg_db_fetch_assoc($result))
@@ -1398,7 +1398,7 @@ function ws_tags_getImages($params, &$service)
   WHERE '. implode('
     AND ', $where_clauses).'
 '.$order_by.'
-LIMIT '.(int)($params['per_page']*$params['page']).' OFFSET '.(int)$params['per_page'];
+LIMIT '.(int)$params['per_page'].' OFFSET '.(int)($params['per_page']*$params['page']);
 
     $result = pwg_query($query);
     while ($row = pwg_db_fetch_assoc($result))

diff --git a/random.php b/random.php
@@ -52,7 +52,7 @@
     'WHERE'
   ).'
   ORDER BY RAND(NOW())
-  LIMIT 0, '.min(50, $conf['top_number'],$user['nb_image_page']).'
+  LIMIT '.min(50, $conf['top_number'],$user['nb_image_page']).'
 ;';
 
 // +-----------------------------------------------------------------------+