Feature 1255 :

update pwg_db_insert_id() function. PosgreSQL needs table name to retrieve last insert auto increment id. git-svn-id: http://piwigo.org/svn/trunk@4892 68402e56-0260-453c-a942-63ccdbb3a9ee
Piwigo · Feb 15, 2010 · c1d6177 · c1d6177
1 parent 78b517b
commit c1d6177
Show file tree

Hide file tree

Showing 10 changed files with 20 additions and 14 deletions.
diff --git a/admin/history.php b/admin/history.php
@@ -136,7 +136,7 @@
 ;';
     pwg_query($query);
 
-    $search_id = pwg_db_insert_id();
+    $search_id = pwg_db_insert_id(SEARCH_TABLE);
 
     redirect(
       PHPWG_ROOT_PATH.'admin.php?page=history&search_id='.$search_id
@@ -198,7 +198,7 @@
 ;';
     pwg_query($query);
 
-    $search_id = pwg_db_insert_id();
+    $search_id = pwg_db_insert_id(SEARCH_TABLE);
 
     redirect(
       PHPWG_ROOT_PATH.'admin.php?page=history&search_id='.$search_id

diff --git a/admin/include/functions.php b/admin/include/functions.php
@@ -1254,7 +1254,7 @@ function create_virtual_category($category_name, $parent_id=null)
     array($insert)
     );
 
-  $inserted_id = pwg_db_insert_id();
+  $inserted_id = pwg_db_insert_id(CATEGORIES_TABLE);
 
   $query = '
 UPDATE
@@ -1387,7 +1387,7 @@ function tag_id_from_tag_name($tag_name)
         )
       );
 
-    $page['tag_id_from_tag_name_cache'][$tag_name] = pwg_db_insert_id();
+    $page['tag_id_from_tag_name_cache'][$tag_name] = pwg_db_insert_id(TAGS_TABLE);
   }
   else
   {
@@ -1662,7 +1662,7 @@ function create_tag($tag_name)
         )
       );
 
-    $inserted_id = pwg_db_insert_id();
+    $inserted_id = pwg_db_insert_id(TAGS_TABLE);
 
     return array(
       'info' => sprintf(

diff --git a/include/dblayer/functions_mysql.inc.php b/include/dblayer/functions_mysql.inc.php
@@ -157,7 +157,7 @@ function pwg_db_real_escape_string($s)
   return mysql_real_escape_string($s);
 }
 
-function pwg_db_insert_id()
+function pwg_db_insert_id($table=null, $column='id')
 {
   return mysql_insert_id();
 }

diff --git a/include/dblayer/functions_pgsql.inc.php b/include/dblayer/functions_pgsql.inc.php
@@ -192,9 +192,15 @@ function pwg_db_real_escape_string($s)
   return pg_escape_string($s);
 }
 
-function pwg_db_insert_id()
+function pwg_db_insert_id($table=null, $column='id')
 {
-  // select currval('piwigo_user_id_seq');
+  $sequence = sprintf('%s_%s_seq', strtolower($table), $column);
+  $query = '
+SELECT CURRVAL(\''.$sequence.'\');';
+
+  list($id) = pwg_db_fetch_row(pwg_query($query));
+
+  return $id;
 }
 
 /**

diff --git a/include/dblayer/functions_sqlite.inc.php b/include/dblayer/functions_sqlite.inc.php
@@ -214,7 +214,7 @@ function pwg_db_real_escape_string($s)
   return $pwg_db_link->escapeString($s);
 }
 
-function pwg_db_insert_id()
+function pwg_db_insert_id($table=null, $column='id')
 {
   global $pwg_db_link;
 

diff --git a/include/functions_comment.inc.php b/include/functions_comment.inc.php
@@ -168,7 +168,7 @@ function insert_user_comment( &$comm, $key, &$infos )
 
     pwg_query($query);
 
-    $comm['id'] = pwg_db_insert_id();
+    $comm['id'] = pwg_db_insert_id(COMMENTS_TABLE);
 
     if (($comment_action=='validate' and $conf['email_admin_on_comment']) or
         ($comment_action!='validate' and $conf['email_admin_on_comment_validation']))

diff --git a/include/ws_functions.inc.php b/include/ws_functions.inc.php
@@ -1247,7 +1247,7 @@ function ws_images_add($params, &$service)
     array($insert)
     );
 
-  $image_id = pwg_db_insert_id();
+  $image_id = pwg_db_insert_id(IMAGES_TABLE);
 
   // let's add links between the image and the categories
   if (isset($params['categories']))

diff --git a/qsearch.php b/qsearch.php
@@ -60,7 +60,7 @@
   (\''.addslashes(serialize($search)).'\', NOW() )
 ;';
   pwg_query($query);
-  $search_id = pwg_db_insert_id();
+  $search_id = pwg_db_insert_id(SEARCH_TABLE);
 }
 
 redirect(

diff --git a/search.php b/search.php
@@ -148,7 +148,7 @@
 ;';
     pwg_query($query);
 
-    $search_id = pwg_db_insert_id();
+    $search_id = pwg_db_insert_id(SEARCH_TABLE);
   }
   else
   {

diff --git a/upload.php b/upload.php
@@ -248,7 +248,7 @@ function validate_upload( $temp_name, $my_max_file_size,
     $query.= ",'".$_POST['mail_address']."',".time().",'".$xml_infos."')";
     $query.= ';';
     pwg_query( $query );
-    $page['waiting_id'] = pwg_db_insert_id();
+    $page['waiting_id'] = pwg_db_insert_id(WAITING_TABLE);
 
     if ($conf['email_admin_on_picture_uploaded'])
     {