Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
feature 1255: add pwg_select_db function.
git-svn-id: http://piwigo.org/svn/trunk@5230 68402e56-0260-453c-a942-63ccdbb3a9ee
  • Loading branch information
patdenice committed Mar 21, 2010
1 parent 62ce6a7 commit 54c9ceb
Show file tree
Hide file tree
Showing 8 changed files with 47 additions and 19 deletions.
4 changes: 2 additions & 2 deletions include/common.inc.php
Expand Up @@ -105,8 +105,8 @@ function sanitize_mysql_kv(&$v, $k)

// Database connection
$pwg_db_link = pwg_db_connect($conf['db_host'], $conf['db_user'],
$conf['db_password'], $conf['db_base'])
or my_error('pwg_db_connect', true);
$conf['db_password'], $conf['db_base']);
pwg_select_db($conf['db_base'], $pwg_db_link);

pwg_db_check_charset();

Expand Down
10 changes: 7 additions & 3 deletions include/dblayer/functions_mysql.inc.php
Expand Up @@ -32,14 +32,18 @@
*
*/

function pwg_db_connect($host, $user, $password, $database)
function pwg_db_connect($host, $user, $password, $database=null, $die=true)
{
$link = mysql_connect($host, $user, $password) or my_error('mysql_connect', false);
mysql_select_db($database, $link) or my_error('mysql_select_db', false);
$link = @mysql_connect($host, $user, $password) or my_error('mysql_connect', $die);

return $link;
}

function pwg_select_db($database, $link, $die=true)
{
return @mysql_select_db($database, $link) or my_error('mysql_select_db', $die);
}

function pwg_db_check_charset()
{
defined('PWG_CHARSET') and defined('DB_CHARSET')
Expand Down
9 changes: 7 additions & 2 deletions include/dblayer/functions_pdo-sqlite.inc.php
Expand Up @@ -33,7 +33,7 @@
*
*/

function pwg_db_connect($host, $user, $password, $database)
function pwg_db_connect($host, $user, $password, $database, $die=true)
{
global $conf;

Expand All @@ -42,7 +42,7 @@ function pwg_db_connect($host, $user, $password, $database)
try {
$link = new PDO($db_file);
} catch (Exception $e) {
my_error('sqlite::open', true);
my_error('sqlite::open', $die);
}

$link->sqliteCreateFunction('now', 'pwg_now', 0);
Expand All @@ -56,6 +56,11 @@ function pwg_db_connect($host, $user, $password, $database)
return $link;
}

function pwg_select_db($database=null, $link=null, $die=null)
{
return true;
}

function pwg_db_check_charset()
{
return true;
Expand Down
9 changes: 7 additions & 2 deletions include/dblayer/functions_pgsql.inc.php
Expand Up @@ -33,7 +33,7 @@
*
*/

function pwg_db_connect($host, $user, $password, $database)
function pwg_db_connect($host, $user, $password, $database, $die=true)
{
$connection_string = '';
if (strpos($host,':') !== false)
Expand All @@ -49,11 +49,16 @@ function pwg_db_connect($host, $user, $password, $database)
$user,
$password,
$database);
$link = pg_connect($connection_string) or my_error('pg_connect', false);
$link = pg_connect($connection_string) or my_error('pg_connect', $die);

return $link;
}

function pwg_select_db($database=null, $link=null, $die=null)
{
return true;
}

function pwg_db_check_charset()
{
return true;
Expand Down
9 changes: 7 additions & 2 deletions include/dblayer/functions_sqlite.inc.php
Expand Up @@ -33,7 +33,7 @@
*
*/

function pwg_db_connect($host, $user, $password, $database)
function pwg_db_connect($host, $user, $password, $database, $die=true)
{
global $conf;

Expand All @@ -50,7 +50,7 @@ function pwg_db_connect($host, $user, $password, $database)
try {
$link = new SQLite3($db_file, $sqlite_open_mode);
} catch (Exception $e) {
my_error('sqlite::open', true);
my_error('sqlite::open', $die);
}

$link->createFunction('now', 'pwg_now', 0);
Expand All @@ -64,6 +64,11 @@ function pwg_db_connect($host, $user, $password, $database)
return $link;
}

function pwg_select_db($database=null, $link=null, $die=null)
{
return true;
}

function pwg_db_check_charset()
{
return true;
Expand Down
17 changes: 13 additions & 4 deletions install.php
Expand Up @@ -227,11 +227,20 @@
//---------------------------------------------------------------- form analyze
if ( isset( $_POST['install'] ))
{
ob_start();
if (($pwg_db_link = pwg_db_connect($_POST['dbhost'], $_POST['dbuser'],
$_POST['dbpasswd'], $_POST['dbname']))!==false)
$_POST['dbpasswd'], $_POST['dbname'], false))!==false)
{

array_push( $infos, l10n('Parameters are correct') );
if (pwg_select_db($_POST['dbname'], $pwg_db_link, false)!==false)
{
array_push( $infos, l10n('Parameters are correct') );
}
else
{
array_push( $errors,
l10n('Connection to server succeed, but it was impossible to connect to database') );
}
ob_end_clean();

$required_version = constant('REQUIRED_'.strtoupper($dblayer).'_VERSION');
if ( version_compare(pwg_get_db_version(), $required_version, '>=') )
Expand Down Expand Up @@ -261,8 +270,8 @@
else
{
array_push( $errors, l10n('Can\'t connect to server') );
ob_end_clean();
}

$webmaster = trim(preg_replace( '/\s{2,}/', ' ', $admin_name ));
if ( empty($webmaster))
array_push( $errors, l10n('enter a login for webmaster') );
Expand Down
4 changes: 2 additions & 2 deletions upgrade.php
Expand Up @@ -52,8 +52,8 @@

// Database connection
$pwg_db_link = pwg_db_connect($conf['db_host'], $conf['db_user'],
$conf['db_password'], $conf['db_base'])
or my_error('pwg_db_connect', true);
$conf['db_password'], $conf['db_base']);
pwg_select_db($conf['db_base'], $pwg_db_link);

pwg_db_check_charset();

Expand Down
4 changes: 2 additions & 2 deletions upgrade_feed.php
Expand Up @@ -56,8 +56,8 @@
// +-----------------------------------------------------------------------+

$pwg_db_link = pwg_db_connect($conf['db_host'], $conf['db_user'],
$conf['db_password'], $conf['db_base'])
or my_error('pwg_db_connect', true);
$conf['db_password'], $conf['db_base']);
pwg_select_db($conf['db_base'], $pwg_db_link);

pwg_db_check_charset();

Expand Down

0 comments on commit 54c9ceb

Please sign in to comment.