Navigation Menu

Skip to content

Commit

Permalink
Amend bug 1559. standard deviation was not removed in some places.
Browse files Browse the repository at this point in the history
So, sqlite crashed because std function has been removed.

git-svn-id: http://piwigo.org/svn/trunk@6125 68402e56-0260-453c-a942-63ccdbb3a9ee
  • Loading branch information
nikrou committed May 8, 2010
1 parent f51c941 commit a34af69
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 7 deletions.
4 changes: 1 addition & 3 deletions admin/rating.php
Expand Up @@ -169,8 +169,7 @@
i.average_rate,
MAX(r.date) AS recently_rated,
COUNT(r.rate) AS nb_rates,
SUM(r.rate) AS sum_rates,
ROUND(STD(r.rate),2) AS std_rates
SUM(r.rate) AS sum_rates
FROM '.RATE_TABLE.' AS r
LEFT JOIN '.IMAGES_TABLE.' AS i ON r.element_id = i.id
WHERE 1 = 1 ' . $page['user_filter'] . '
Expand Down Expand Up @@ -206,7 +205,6 @@
'U_THUMB' => $thumbnail_src,
'U_URL' => $image_url,
'AVG_RATE' => $image['average_rate'],
'STD_RATE' => $image['std_rates'],
'SUM_RATE' => $image['sum_rates'],
'NB_RATES' => (int)$image['nb_rates'],
'NB_RATES_TOTAL' => (int)$nb_rates,
Expand Down
2 changes: 0 additions & 2 deletions admin/themes/default/template/rating.tpl
Expand Up @@ -38,7 +38,6 @@
<td>{'File'|@translate}</td>
<td>{'Number of rates'|@translate}</td>
<td>{'Average rate'|@translate}</td>
<td>{'Controversy'|@translate}</td>
<td>{'Sum of rates'|@translate}</td>
<td>{'Rate'|@translate}</td>
<td>{'Username'|@translate}</td>
Expand All @@ -50,7 +49,6 @@
<td rowspan="{$image.NB_RATES_TOTAL+1}"><a href="{$image.U_URL}"><img src="{$image.U_THUMB}" alt="{$image.FILE}" title="{$image.FILE}"></a></td>
<td rowspan="{$image.NB_RATES_TOTAL+1}"><strong>{$image.NB_RATES}/{$image.NB_RATES_TOTAL}</strong></td>
<td rowspan="{$image.NB_RATES_TOTAL+1}"><strong>{$image.AVG_RATE}</strong></td>
<td rowspan="{$image.NB_RATES_TOTAL+1}"><strong>{$image.STD_RATE}</strong></td>
<td rowspan="{$image.NB_RATES_TOTAL+1}" style="border-right: 1px solid;" ><strong>{$image.SUM_RATE}</strong></td>
</tr>
{foreach from=$image.rates item=rate name=rate}
Expand Down
1 change: 0 additions & 1 deletion include/functions_rate.inc.php
Expand Up @@ -120,7 +120,6 @@ function rate_picture($image_id, $rate)
$query = '
SELECT COUNT(rate) AS count
, ROUND(AVG(rate),2) AS average
, ROUND(STD(rate),2) AS stdev
FROM '.RATE_TABLE.'
WHERE element_id = '.$image_id.'
;';
Expand Down
1 change: 0 additions & 1 deletion include/ws_functions.inc.php
Expand Up @@ -676,7 +676,6 @@ function ws_images_getInfo($params, &$service)
$query = '
SELECT COUNT(rate) AS count
, ROUND(AVG(rate),2) AS average
, ROUND(STD(rate),2) AS stdev
FROM '.RATE_TABLE.'
WHERE element_id = '.$image_row['id'].'
;';
Expand Down

0 comments on commit a34af69

Please sign in to comment.