Changeset 12342 for trunk/plugins/language_switch

Timestamp:

Oct 4, 2011, 2:48:02 PM (13 years ago)

Author:

plg

Message:

bug 2430 fixed: prevents from cross site scripting, the URL is cleanly rewritten

Location:

trunk/plugins/language_switch

Files:

• flags.tpl (modified) (1 diff)
• language_switch.inc.php (modified) (1 diff)

trunk/plugins/language_switch/flags.tpl

@@ -20 +20 @@
 {foreach from=$lang_switch.flags key=code item=flag name=f}
           <li>
-            <a rel="nofollow" href="{$SCRIPT_NAME}{$flag.url}">
+            <a rel="nofollow" href="{$flag.url}">
               <img class="flags" src="{$flag.img}" alt="{$flag.alt}" title="{$flag.alt}"/> {$flag.title}
             </a>

trunk/plugins/language_switch/language_switch.inc.php

@@ -101 +101 @@
     
     $url_starting = get_query_string_diff(array('lang'));
-    
+
     foreach ($available_lang as $code => $displayname)
     {
-      $qlc = array ( 
-        'url' => str_replace(
-          array('=&','?&'),
-          array('&','?'),
-          add_url_params($url_starting, array('lang'=> $code))
-          ),
+      $qlc = array (
+        'url' => add_url_params(duplicate_index_url(), array('lang'=> $code)),
         'alt' => ucwords($displayname),
         'title' => substr($displayname, 0, -4), // remove [FR] or [RU]