Changeset 12760 for branches/2.3/include/functions_html.inc.php

Timestamp:

Dec 17, 2011, 11:51:20 PM (12 years ago)

Author:

plg

Message:

bug 2502 fixed: better handling of non-latin tags and multilanguage tags on
tags.php with mode letter.

We can't rely on url_name because it always start with "_" when the tag looks
like "[lang...". Instead we compute a str2url on the name, but once it has been
rendered by Extended Description. To avoid useless computations, I have added a
cache on the tag_alpha_compare function. Tested on a 175 tags set, speed is
good.

File:

• branches/2.3/include/functions_html.inc.php (modified) (1 diff)

branches/2.3/include/functions_html.inc.php

@@ -295 +295 @@
 function tag_alpha_compare($a, $b)
 {
-  return strcmp(strtolower($a['url_name']), strtolower($b['url_name']));
+  global $page;
+  
+  foreach (array($a, $b) as $tag)
+  {
+    if (!isset($page[__FUNCTION__.'_cache'][ $tag['name'] ]))
+    {
+      $page[__FUNCTION__.'_cache'][ $tag['name'] ] = strtolower(str2url($tag['name']));
+    }
+  }
+
+  return strcmp($page[__FUNCTION__.'_cache'][ $a['name'] ], $page[__FUNCTION__.'_cache'][ $b['name'] ]);
 }