Changeset 1731

Timestamp:

Jan 18, 2007, 3:09:31 AM (17 years ago)

Author:

rvelices

Message:

plugin simplification: adding admin links does not require the plugin_id anymore...

Location:

trunk

Files:

• admin/include/functions_plugins.inc.php (modified) (1 diff)
• admin/plugin.php (modified) (3 diffs)
• plugins/add_index/main.admin.inc.php (modified) (5 diffs)
• plugins/event_tracer/main.inc.php (modified) (3 diffs)

trunk/admin/include/functions_plugins.inc.php

@@ -71 +71 @@
 /**
  * Retrieves an url for a plugin page.
- * @param string plugin_id
- * @param string page - the php script file name (without .php extension)
+ * @param string file - php script full name
  */
-function get_admin_plugin_menu_link($plugin_id, $page)
+function get_admin_plugin_menu_link($file)
 {
-  $url = get_root_url().'admin.php?page=plugin&section='
-    .urlencode($plugin_id .'~'. $page);
+  global $page;
+  $real_file = realpath($file);
+  $url = get_root_url().'admin.php?page=plugin';
+  if (false!==$real_file)
+  {
+    $real_plugin_path = realpath(PHPWG_PLUGINS_PATH);
+    $file = substr($real_file, strlen($real_plugin_path)+1);
+    $file = str_replace('\\', '/', $file);//Windows
+    $url .= '&section='.urlencode($file);
+  }
+  else if (isset($page['errors']))
+  {
+    array_push($page['errors'], 'PLUGIN ERROR: "'.$file.'" is not a valid file');
+  }
   return $url;
 }

trunk/admin/plugin.php

@@ -34 +34 @@
 check_status(ACCESS_ADMINISTRATOR);
 
-$section = explode('~', $_GET['section'] );
-if (count($section)!=2)
+$sections = explode('/', $_GET['section'] );
+for ($i=0; $i<count($sections); $i++)
+{
+  if (empty($sections[$i]) or $sections[$i]=='..')
+  {
+    unset($sections[$i]);
+    $i--;
+  }
+}
+
+if (count($sections)<2)
 {
   die('Invalid plugin URL');
 }
 
-$plugin_id = $section[0];
+$plugin_id = $sections[0];
 $check_db_plugin = get_db_plugins('active', $plugin_id );
 if (empty($check_db_plugin))
@@ -46 +55 @@
   die('Invalid URL - plugin '.$plugin_id.' not active');
 }
-$section[1]=str_replace('./', '', $section[1]); // no up in dir structure
 
-$filename = PHPWG_PLUGINS_PATH.$plugin_id.'/'.$section[1].'.php';
+$filename = PHPWG_PLUGINS_PATH.implode('/', $sections);
 if (is_file($filename))
 {
@@ -55 +63 @@
 else
 {
-  die('Missing '.$filename);
+  die('Missing file '.$filename);
 }
 ?>

trunk/plugins/add_index/main.admin.inc.php

@@ -34 +34 @@
 class AdminAddIndex extends AddIndex
 {
-  var $my_id;
   function load_params()
   {
@@ -64 +63 @@
       (
         'CAPTION' => l10n('Advanced_Add_Index'),
-        'URL' => get_admin_plugin_menu_link($this->my_id, 'admin/main_page').'&overwrite'
+        'URL' => get_admin_plugin_menu_link(dirname(__FILE__).'/admin/main_page.php').'&overwrite'
       ));
 
@@ -77 +76 @@
         array
         (
-          'U_HREF' => get_admin_plugin_menu_link($this->my_id, 'admin/main_page').'&site_id='.$site_id,
+          'U_HREF' => get_admin_plugin_menu_link(dirname(__FILE__).'/admin/main_page.php').'&site_id='.$site_id,
           'U_CAPTION' => l10n('Manager_Add_Index'),
           'U_HINT' => l10n('Add_Index')
@@ -91 +90 @@
         array(
           'NAME' => l10n('Menu_Add_Index'),
-          'URL' => get_admin_plugin_menu_link($this->my_id, 'admin/admin_menu')
+          'URL' => get_admin_plugin_menu_link(dirname(__FILE__).'/admin/admin_menu.php')
         )
       );
@@ -100 +99 @@
 // Create object
 $add_index = new AdminAddIndex();
-$add_index->my_id = $plugin['id'];
 
 // Load Add Index parameters

trunk/plugins/event_tracer/main.inc.php

@@ -12 +12 @@
   var $me_working;
   var $my_config;
-  var $my_id;
   
-  function EventTracer($id)
+  function EventTracer()
   {
     $this->me_working=0;
-    $this->my_id=$id;
   }
 
@@ -84 +82 @@
         array(
           'NAME' => 'Event Tracer',
-          'URL' => get_admin_plugin_menu_link($this->my_id, 'tracer_admin')
+          'URL' => get_admin_plugin_menu_link(dirname(__FILE__).'/tracer_admin.php')
         )
       );
@@ -91 +89 @@
 }
 
-$obj = new EventTracer($plugin['id']);
+$obj = new EventTracer();
 $obj->load_config();