Changeset 2308

Timestamp:

Apr 25, 2008, 3:00:39 AM (16 years ago)

Author:

rvelices

Message:

• minor sql query optimizations

Location:

trunk/include

Files:

• functions.inc.php (modified) (2 diffs)
• functions_tag.inc.php (modified) (2 diffs)

trunk/include/functions.inc.php

@@ -565 +565 @@
   }
 
-  // here we ask the database the current date and time, and we extract
-  // {year, month, day} from the current date. We could do this during the
-  // insert query with a CURDATE(), CURTIME(), DATE_FORMAT(CURDATE(), '%Y')
-  // ... but I (plg) think it would cost more than a double query and a PHP
-  // extraction.
-  $query = '
-SELECT CURDATE(), CURTIME()
-;';
-  list($curdate, $curtime) = mysql_fetch_row(pwg_query($query));
-
-  list($curyear, $curmonth, $curday) = explode('-', $curdate);
-  list($curhour) = explode(':', $curtime);
-
   $query = '
 INSERT INTO '.HISTORY_TABLE.'
@@ -597 +584 @@
   VALUES
   (
-    \''.$curdate.'\',
-    \''.$curtime.'\',
-    '.$curyear.',
-    '.$curmonth.',
-    '.$curday.',
-    '.$curhour.',
+    CURDATE(),
+    CURTIME(),
+    YEAR( CURDATE() ),
+    MONTH( CURDATE() ),
+    DAYOFMONTH( CURDATE() ),
+    HOUR( CURTIME() ),
     '.$user['id'].',
     \''.$_SERVER['REMOTE_ADDR'].'\',

trunk/include/functions_tag.inc.php

@@ -50 +50 @@
   WHERE'
     ).'
-  GROUP BY tag_id';
+  GROUP BY tag_id
+  ORDER BY NULL';
   $tag_counters = simple_hash_from_query($query, 'tag_id', 'counter');
 
@@ -243 +244 @@
   ORDER BY counter DESC
   LIMIT 0,'.$max_tags;
+  }
+  else
+  {
+    $query .= '
+  ORDER BY NULL';
   }