Changeset 2490

Timestamp:

Aug 28, 2008, 10:05:39 PM (16 years ago)

Author:

rvelices

Message:

• fix an issue on category modify (lock/unlock display was reversed) and improved queries on submit

Location:

trunk

Files:

• admin/cat_modify.php (modified) (5 diffs)
• admin/template/yoga/admin/cat_modify.tpl (modified) (1 diff)
• plugins/admin_multi_view/controller.php (modified) (1 diff)

trunk/admin/cat_modify.php

@@ -38 +38 @@
 if ( !isset( $_GET['cat_id'] ) || !is_numeric( $_GET['cat_id'] ) )
 {
-  $_GET['cat_id'] = '-1';
+  trigger_error( 'missing cat_id param', E_USER_ERROR);
 }
 
@@ -44 +44 @@
 if (isset($_POST['submit']))
 {
-  $data =
-    array(
-      'id' => $_GET['cat_id'],
-      'name' => @$_POST['name'],
-      'commentable' => $_POST['commentable'],
-      'uploadable' =>
-        isset($_POST['uploadable']) ? $_POST['uploadable'] : 'false',
-      'comment' =>
-        $conf['allow_html_descriptions'] ?
-          @$_POST['comment'] : strip_tags(@$_POST['comment'])
-      );
-
-  mass_updates(
-    CATEGORIES_TABLE,
-    array(
-      'primary' => array('id'),
-      'update' => array_diff(array_keys($data), array('id'))
-      ),
-    array($data)
-    );
-
-  set_cat_visible(array($_GET['cat_id']), $_POST['visible']);
-  set_cat_status(array($_GET['cat_id']), $_POST['status']);
-
-  if (isset($_POST['parent']))
-  {
-    move_categories(
-      array($_GET['cat_id']),
-      $_POST['parent']
-      );
-  }
-
-  $image_order = '';
+  $image_order = null;
   if ( !isset($_POST['image_order_default']) )
   {
@@ -95 +63 @@
     }
   }
-  $image_order = empty($image_order) ? 'null' : "'$image_order'";
-  $query = '
-UPDATE '.CATEGORIES_TABLE.' SET image_order='.$image_order.'
-WHERE ';
+
+  $data =
+    array(
+      'id' => $_GET['cat_id'],
+      'name' => @$_POST['name'],
+      'commentable' => $_POST['commentable'],
+      'uploadable' =>
+        isset($_POST['uploadable']) ? $_POST['uploadable'] : 'false',
+      'comment' =>
+        $conf['allow_html_descriptions'] ?
+          @$_POST['comment'] : strip_tags(@$_POST['comment']),
+      'image_order' => $image_order,
+      );
+
+  mass_updates(
+    CATEGORIES_TABLE,
+    array(
+      'primary' => array('id'),
+      'update' => array_diff(array_keys($data), array('id'))
+      ),
+    array($data)
+    );
+
+  // retrieve cat infos before continuing (following updates are expensive)
+  $cat_info = get_cat_info($_GET['cat_id']);
+
   if (isset($_POST['image_order_subcats']))
   {
-    $query .= 'uppercats REGEXP \'(^|,)'.$_GET['cat_id'].'(,|$)\'';
-  }
-  else
-  {
-    $query .= 'id='.$_GET['cat_id'].';';
-  }
-  pwg_query($query);
+    $query = '
+UPDATE '.CATEGORIES_TABLE.' SET image_order='.(isset($image_order) ? 'NULL':"'$image_order'").'
+  WHERE uppercats LIKE "'.$cat_info['uppercats'].',%"';
+    pwg_query($query);
+  }
+
+  if ($cat_info['visible'] != get_boolean( $_POST['visible'] ) )
+  {
+    set_cat_visible(array($_GET['cat_id']), $_POST['visible']);
+  }
+  if ($cat_info['status'] != get_boolean( $_POST['status'] ) )
+  {
+    set_cat_status(array($_GET['cat_id']), $_POST['status']);
+  }
+
+  if (isset($_POST['parent']) and $cat_info['id_uppercat'] != $_POST['parent'])
+  {
+    move_categories( array($_GET['cat_id']), $_POST['parent'] );
+  }
 
   array_push($page['infos'], l10n('editcat_confirm'));
 }
-else if (isset($_POST['set_random_representant']))
+elseif (isset($_POST['set_random_representant']))
 {
   set_random_representant(array($_GET['cat_id']));
 }
-else if (isset($_POST['delete_representant']))
+elseif (isset($_POST['delete_representant']))
 {
   $query = '
@@ -124 +126 @@
   pwg_query($query);
 }
-else if (isset($_POST['submitAdd']))
+elseif (isset($_POST['submitAdd']))
 {
   $output_create = create_virtual_category(
@@ -160 +162 @@
   }
 }
-else if (isset($_POST['submitDestinations'])
+elseif (isset($_POST['submitDestinations'])
          and isset($_POST['destinations'])
          and count($_POST['destinations']) > 0)

trunk/admin/template/yoga/admin/cat_modify.tpl

@@ -71 +71 @@
       <td><strong>{'lock'|@translate}</strong>
       <td>
-        {html_radios name='visible' values='false,true'|@explode output='No,Yes'|@explode|translate selected=$CAT_VISIBLE}
+        {html_radios name='visible' values='true,false'|@explode output='No,Yes'|@explode|translate selected=$CAT_VISIBLE}
       </td>
     </tr>

trunk/plugins/admin_multi_view/controller.php

@@ -31 +31 @@
   if ( is_adviser() and $user['id']!=$_GET['view_as'] and $conf['guest_id']!=$_GET['view_as'])
     die('security error');
-  pwg_set_session_var( 'multiview_as', (int)$_GET['view_as'] );
+  if ($user['id']===$_GET['view_as'])
+    pwg_unset_session_var( 'multiview_as' );
+  else
+    pwg_set_session_var( 'multiview_as', (int)$_GET['view_as'] );
   // user change resets theme/lang
   pwg_unset_session_var( 'multiview_theme' );