Changeset 24986

Timestamp:

Oct 18, 2013, 10:56:05 PM (11 years ago)

Author:

plg

Message:

bug 2977 fixed: when moving an album, whatever the previous status
private/public we must remove irrelevant permissions (a public album
can have hidden permission, ie list of groups/users permitted). I've
also found a bug in the algorithm that selects users/groups to delete
(reverse parameters in array_diff).

File:

• branches/2.5/admin/include/functions.php (modified) (1 diff)

branches/2.5/admin/include/functions.php

@@ -1140 +1140 @@
     foreach ($categories as $cat_id => $category)
     {
-      switch ($category['status'])
+      if ('public' == $category['status'])
       {
-        case 'public' :
-        {
-          set_cat_status(array($cat_id), 'private');
-          break;
-        }
-        case 'private' :
-        {
-          $subcats = get_subcat_ids(array($cat_id));
-
-          foreach ($tables as $table => $field)
-          {
-            $query = '
+        set_cat_status(array($cat_id), 'private');
+      }
+      
+      $subcats = get_subcat_ids(array($cat_id));
+
+      foreach ($tables as $table => $field)
+      {
+        $query = '
 SELECT '.$field.'
   FROM '.$table.'
   WHERE cat_id = '.$cat_id.'
 ;';
-            $category_access = array_from_query($query, $field);
-
-            $query = '
+        $category_access = array_from_query($query, $field);
+
+        $query = '
 SELECT '.$field.'
   FROM '.$table.'
   WHERE cat_id = '.$new_parent.'
 ;';
-            $parent_access = array_from_query($query, $field);
-
-            $to_delete = array_diff($parent_access, $category_access);
-
-            if (count($to_delete) > 0)
-            {
-              $query = '
+        $parent_access = array_from_query($query, $field);
+
+        $to_delete = array_diff($category_access, $parent_access);
+
+        if (count($to_delete) > 0)
+        {
+          $query = '
 DELETE FROM '.$table.'
   WHERE '.$field.' IN ('.implode(',', $to_delete).')
     AND cat_id IN ('.implode(',', $subcats).')
 ;';
-              pwg_query($query);
-            }
-          }
-          break;
+          pwg_query($query);
         }
       }