Changeset 25018 for trunk/admin/cat_perm.php

Timestamp:

Oct 19, 2013, 7:43:04 PM (11 years ago)

Author:

mistic100

Message:

remove all array_push (50% slower than []) + some changes missing for feature:2978

File:

• trunk/admin/cat_perm.php (modified) (5 diffs)

trunk/admin/cat_perm.php

@@ -126 +126 @@
       while ($row = pwg_db_fetch_assoc($result))
       {
-        array_push($granteds[$row['cat_id']], $row['group_id']);
+        $granteds[ $row['cat_id'] ][] = $row['group_id'];
       }
 
@@ -136 +136 @@
         foreach ($group_ids as $group_id)
         {
-          array_push(
-            $inserts,
-            array(
-              'group_id' => $group_id,
-              'cat_id' => $cat_id
-              )
+          $inserts[] = array(
+            'group_id' => $group_id,
+            'cat_id' => $cat_id
             );
         }
@@ -191 +188 @@
   }
 
-  array_push($page['infos'], l10n('Album updated successfully'));
+  $page['infos'][] = l10n('Album updated successfully');
 }
 
@@ -273 +270 @@
   while ($row = pwg_db_fetch_assoc($result))
   {
-    if (!isset($granted_groups[$row['group_id']]))
-    {
-      $granted_groups[$row['group_id']] = array();
-    }
-    array_push($granted_groups[$row['group_id']], $row['user_id']);
+    if (!isset($granted_groups[ $row['group_id'] ]))
+    {
+      $granted_groups[ $row['group_id'] ] = array();
+    }
+    $granted_groups[ $row['group_id'] ][] = $row['user_id'];
   }
 
@@ -303 +300 @@
       if (in_array($user_id, $user_granted_indirect_ids))
       {
-        array_push($group_usernames, $users[$user_id]);
+        $group_usernames[] = $users[$user_id];
       }
     }