Changeset 25018 for trunk/admin/include/updates.class.php

Timestamp:

Oct 19, 2013, 7:43:04 PM (11 years ago)

Author:

mistic100

Message:

remove all array_push (50% slower than []) + some changes missing for feature:2978

File:

• trunk/admin/include/updates.class.php (modified) (6 diffs)

trunk/admin/include/updates.class.php

@@ -162 +162 @@
             if (in_array($ext_id, $conf['updates_ignored'][$type]))
             {
-              array_push($ignore_list, $ext_id);
+              $ignore_list[] = $ext_id;
             }
             else
@@ -249 +249 @@
       and !empty($old_files))
     {
-      array_push($old_files, $file);
+      $old_files[] = $file;
       foreach($old_files as $old_file)
       {
@@ -315 +315 @@
     else
     {
-      array_push($page['errors'], l10n('Unable to dump database.'));
+      $page['errors'][] = l10n('Unable to dump database.');
     }
   }
@@ -415 +415 @@
             if ($step == 2)
             {
-              array_push($page['infos'], l10n('Update Complete'), $upgrade_to);
+              $page['infos'][] = l10n('Update Complete');
+              $page['infos'][] = $upgrade_to;
               $step = -1;
             }
@@ -426 +427 @@
           {
             file_put_contents(PHPWG_ROOT_PATH.$conf['data_location'].'update/log_error.txt', $error);
-            array_push(
-              $page['errors'],
-              sprintf(
-                l10n('An error has occured during extract. Please check files permissions of your piwigo installation.<br><a href="%s">Click here to show log error</a>.'),
-                get_root_url().$conf['data_location'].'update/log_error.txt'
-              )
-            );
+            
+            $page['errors'][] = l10n(
+              'An error has occured during extract. Please check files permissions of your piwigo installation.<br><a href="%s">Click here to show log error</a>.',
+              get_root_url().$conf['data_location'].'update/log_error.txt'
+              );
           }
         }
@@ -438 +437 @@
         {
           deltree(PHPWG_ROOT_PATH.$conf['data_location'].'update');
-          array_push($page['errors'], l10n('An error has occured during upgrade.'));
+          $page['errors'][] = l10n('An error has occured during upgrade.');
         }
       }
       else
       {
-        array_push($page['errors'], l10n('Piwigo cannot retrieve upgrade file from server'));
+        $page['errors'][] = l10n('Piwigo cannot retrieve upgrade file from server');
       }
     }