Changeset 25344

Timestamp:

Nov 5, 2013, 8:23:29 PM (10 years ago)

Author:

mistic100

Message:

feature 2965: apply new template on pwg_mail()
TODO : review other mail functions, configuration GUI

Location:

trunk

Files:

• include/config_default.inc.php (modified) (3 diffs)
• include/emogrifier.class.php (added)
• include/functions_mail.inc.php (modified) (24 diffs)
• themes/default/template/mail/text/html/footer.tpl (modified) (1 diff)
• themes/default/template/mail/text/html/global-mail-css.tpl (modified) (1 diff)
• themes/default/template/mail/text/html/header.tpl (modified) (1 diff)
• themes/default/template/mail/text/html/mail-css-clear.tpl (added)
• themes/default/template/mail/text/html/mail-css-dark.tpl (added)
• themes/default/template/mail/text/plain/footer.tpl (modified) (1 diff)
• themes/default/template/mail/text/plain/header.tpl (modified) (1 diff)

trunk/include/config_default.inc.php

@@ -230 +230 @@
 $conf['available_permission_levels'] = array(0,1,2,4,8);
 
-// mail_options: only set it true if you have a send mail warning with
-// "options" parameter missing on mail() function execution.
-$conf['mail_options'] = false;
+// check_upgrade_feed: check if there are database upgrade required. Set to
+// true, a message will strongly encourage you to upgrade your database if
+// needed.
+//
+// This configuration parameter is set to true in BSF branch and to false
+// elsewhere.
+$conf['check_upgrade_feed'] = true;
+
+// rate_items: available rates for a picture
+$conf['rate_items'] = array(0,1,2,3,4,5);
+
+// Define default method to use ('http' or 'html' in order to do redirect)
+$conf['default_redirect_method'] = 'http';
+
+// Define using double password type in admin's users management panel
+$conf['double_password_type_in_admin'] = false;
+
+// Define if logins must be case sentitive or not at users registration. ie :
+// If set true, the login "user" will equal "User" or "USER" or "user",
+// etc. ... And it will be impossible to use such login variation to create a
+// new user account.
+$conf['insensitive_case_logon'] = false;
+
+// how should we check for unicity when adding a photo. Can be 'md5sum' or
+// 'filename'
+$conf['uniqueness_mode'] = 'md5sum';
+
+// Library used for image resizing. Value could be 'auto', 'imagick',
+// 'ext_imagick' or 'gd'. If value is 'auto', library will be choosen in this
+// order. If choosen library is not available, another one will be picked up.
+$conf['graphics_library'] = 'auto';
+
+// If library used is external installation of ImageMagick ('ext_imagick'),
+// you can define imagemagick directory.
+$conf['ext_imagick_dir'] = '';
+
+// how many user comments to display by default on comments.php. Use 'all'
+// to display all user comments without pagination. Default available values
+// are array(5,10,20,50,'all') but you can set any other numeric value.
+$conf['comments_page_nb_comments'] = 10;
+
+// +-----------------------------------------------------------------------+
+// |                                 email                                 |
+// +-----------------------------------------------------------------------+
 
 // send_bcc_mail_webmaster: send bcc mail to webmaster. Set true for debug
@@ -238 +279 @@
 $conf['send_bcc_mail_webmaster'] = false;
 
-// default_email_format:
-//  Define the default email format use to send email
-//  Value could be text/plain  or text/html
-$conf['default_email_format'] = 'text/html';
-
-// alternative_email_format:
-//  Define the alternative email format use to send email
-//  Value could be text/plain  or text/html
-$conf['alternative_email_format'] = 'text/plain';
-
-// define the name of sender mail:
-// If value is empty, gallery title is used
+// define the name of sender mail: if value is empty, gallery title is used
 $conf['mail_sender_name'] = '';
 
-// smtp configuration
-// (work if fsockopen function is allowed for smtp port)
+// define the email of sender mail: if valie is empty, webmaster email is used
+$conf['mail_sender_email'] = '';
+
+// set true to allow text/html emails
+$conf['allow_html_email'] = true;
+
+// 'clear' or 'dark'
+$conf['mail_theme'] = 'clear';
+
+// smtp configuration (work if fsockopen function is allowed for smtp port)
 // smtp_host: smtp server host
 //  if null, regular mail function is used
@@ -265 +303 @@
 // 'ssl' or 'tls'
 $conf['smtp_secure'] = null;
-
-// check_upgrade_feed: check if there are database upgrade required. Set to
-// true, a message will strongly encourage you to upgrade your database if
-// needed.
-//
-// This configuration parameter is set to true in BSF branch and to false
-// elsewhere.
-$conf['check_upgrade_feed'] = true;
-
-// rate_items: available rates for a picture
-$conf['rate_items'] = array(0,1,2,3,4,5);
-
-// Define default method to use ('http' or 'html' in order to do redirect)
-$conf['default_redirect_method'] = 'http';
-
-// Define using double password type in admin's users management panel
-$conf['double_password_type_in_admin'] = false;
-
-// Define if logins must be case sentitive or not at users registration. ie :
-// If set true, the login "user" will equal "User" or "USER" or "user",
-// etc. ... And it will be impossible to use such login variation to create a
-// new user account.
-$conf['insensitive_case_logon'] = false;
-
-// how should we check for unicity when adding a photo. Can be 'md5sum' or
-// 'filename'
-$conf['uniqueness_mode'] = 'md5sum';
-
-// Library used for image resizing. Value could be 'auto', 'imagick',
-// 'ext_imagick' or 'gd'. If value is 'auto', library will be choosen in this
-// order. If choosen library is not available, another one will be picked up.
-$conf['graphics_library'] = 'auto';
-
-// If library used is external installation of ImageMagick ('ext_imagick'),
-// you can define imagemagick directory.
-$conf['ext_imagick_dir'] = '';
-
-// how many user comments to display by default on comments.php. Use 'all'
-// to display all user comments without pagination. Default available values
-// are array(5,10,20,50,'all') but you can set any other numeric value.
-$conf['comments_page_nb_comments'] = 10;
 
 // +-----------------------------------------------------------------------+

trunk/include/functions_mail.inc.php

@@ -22 +22 @@
 // +-----------------------------------------------------------------------+
 
-// +-----------------------------------------------------------------------+
-// |                               functions                               |
-// +-----------------------------------------------------------------------+
-
-/*
- * Returns the name of the mail sender :
- *
+/**
+ * Returns the name of the mail sender
  * @return string
  */
@@ -38 +33 @@
 }
 
-/*
+/**
+ * Returns the email of the mail sender
+ * @since 2.6
+ * @return string
+ */
+function get_mail_sender_email()
+{
+  global $conf;
+
+  return (empty($conf['mail_sender_email']) ? get_webmaster_mail_address() : $conf['mail_sender_email']);
+}
+
+/**
  * Returns an array of mail configuration parameters :
- *
- * - mail_options
  * - send_bcc_mail_webmaster
- * - default_email_format
- * - alternative_email_format
+ * - allow_html_email
  * - use_smtp
  * - smtp_host
  * - smtp_user
  * - smtp_password
- * - boundary_key
+ * - smtp_secure
  * - email_webmaster
- * - formated_email_webmaster
+ * - name_webmaster
  *
  * @return array
@@ -60 +64 @@
 
   $conf_mail = array(
-    'mail_options' => $conf['mail_options'],
     'send_bcc_mail_webmaster' => $conf['send_bcc_mail_webmaster'],
-    'default_email_format' => $conf['default_email_format'],
-    'alternative_email_format' => $conf['alternative_email_format'],
+    'allow_html_email' => $conf['allow_html_email'],
+    'mail_theme' => $conf['mail_theme'],
     'use_smtp' => !empty($conf['smtp_host']),
     'smtp_host' => $conf['smtp_host'],
@@ -69 +72 @@
     'smtp_password' => $conf['smtp_password'],
     'smtp_secure' => $conf['smtp_secure'],
+    'email_webmaster' => get_mail_sender_email(),
+    'name_webmaster' => get_mail_sender_name(),
     );
 
-  // we have webmaster id among user list, what's his email address ?
-  $conf_mail['email_webmaster'] = get_webmaster_mail_address();
-
-  // name of the webmaster is the title of the gallery
-  $conf_mail['formated_email_webmaster'] = format_email(get_mail_sender_name(), $conf_mail['email_webmaster']);
-
   return $conf_mail;
 }
@@ -82 +81 @@
 /**
  * Returns an email address with an associated real name
- *
  * @param string name
  * @param string email
@@ -88 +86 @@
 function format_email($name, $email)
 {
-  // Spring cleaning
   $cvt_email = trim(preg_replace('#[\n\r]+#s', '', $email));
   $cvt_name = trim(preg_replace('#[\n\r]+#s', '', $name));
@@ -108 +105 @@
 
 /**
+ * Returns the mail and the name from a formatted address
+ * @since 2.6
+ * @param string|array $input
+ * @return array
+ */
+function unformat_email($input)
+{
+  if (is_array($input))
+  {
+    return $input;
+  }
+
+  if (preg_match('/(.*)<(.*)>.*/', $input, $matches))
+  {
+    return array(
+      'email' => trim($matches[2]),
+      'name' => trim($matches[1]),
+      );
+  }
+  else
+  {
+    return array(
+      'email' => trim($input),
+      'name' => '',
+      );
+  }
+}
+  
+
+/**
  * Returns an email address list with minimal email string
- *
- * @param string with email list (email separated by comma)
+ * @param string $email_list - comma separated
+ * @return string
  */
 function get_strict_email_list($email_list)
@@ -116 +143 @@
   $result = array();
   $list = explode(',', $email_list);
+
   foreach ($list as $email)
   {
@@ -131 +159 @@
 /**
  * Return an new mail template
- *
- * @param string email_format: mail format, text/html or text/plain
- * @param string theme: theme to use [default get_default_theme()]
- */
-function & get_mail_template($email_format, $theme='')
-{
-  if (empty($theme))
-  {
-    $theme = get_default_theme();
-  }
-
-  $mail_template = new Template(PHPWG_ROOT_PATH.'themes', $theme, 'template/mail/'.$email_format);
-
-  return $mail_template;
-}
-
-/**
- * Return string email format (text/html or text/plain)
- *
- * @param string format
- */
-function get_str_email_format($is_html)
-{
-  return ($is_html ? 'text/html' : 'text/plain');
-}
-
-/*
- * Switch language to param language
+ * @param string $email_format - text/html or text/plain
+ * @return Template
+ */
+function &get_mail_template($email_format)
+{
+  $template = new Template(PHPWG_ROOT_PATH.'themes', 'default', 'template/mail/'.$email_format);
+  return $template;
+}
+
+/**
+ * Switch language to specified language
  * All entries are push on language stack
- *
- * @param string language
+ * @param string $language
  */
 function switch_lang_to($language)
@@ -198 +208 @@
     load_language('admin.lang', '', array('language'=>$language) );
     
+    // Reload all plugins files (see load_language declaration)
     if (!empty($language_files))
     {
@@ -220 +231 @@
 }
 
-/*
+/**
  * Switch back language pushed with switch_lang_to function
- *
- * @param: none
  */
 function switch_lang_back()
@@ -457 +466 @@
 }
 
-/*
+/**
  * sends an email, using Piwigo specific informations
  *
- * @param:
- *   - to: receiver(s) of the mail (list separated by comma).
- *   - args: function params of mail function:
+ * @param string|string[] $to
+ * @param array $args
  *       o from: sender [default value webmaster email]
  *       o Cc: array of carbon copy receivers of the mail. [default value empty]
@@ -470 +478 @@
  *       o content_format: format of mail content  [default value 'text/plain']
  *       o email_format: global mail format  [default value $conf_mail['default_email_format']]
- *       o theme: template to use [default get_default_theme()]
+ *       o theme: theme to use [default value $conf_mail['mail_theme']]
+ *       o mail_title: main title of the mail [default value $conf['gallery_title']]
+ *       o mail_subtitle: subtitle of the mail [default value subject]
  *
- * @return boolean (Ok or not)
+ * @return boolean
  */
 function pwg_mail($to, $args = array())
@@ -492 +502 @@
   $mail = new PHPMailer;
 
-  foreach (explode(',', get_strict_email_list($to)) as $recipient)
-  {
-    $mail->addAddress($recipient);
-  }
-  
+  $recipients = !is_array($to) ? explode(',', $to) : $to;
+  foreach ($recipients as $recipient)
+  {
+    $recipient = unformat_email($recipient);
+    $mail->addAddress($recipient['email'], $recipient['name']);
+  }
+
   $mail->WordWrap = 76;
   $mail->CharSet = 'UTF-8';
@@ -505 +517 @@
   if (empty($args['from']))
   {
-    $mail->From = get_webmaster_mail_address();
-    $mail->FromName = get_mail_sender_name();
-
-    $mail->addReplyTo(get_webmaster_mail_address(), get_mail_sender_name());
+    $from = array(
+      'email' => $conf_mail['email_webmaster'],
+      'name' => $conf_mail['name_webmaster'],
+      );
   }
   else
   {
-    $mail->From = $args['from'];
-    $mail->addReplyTo($args['from']);
-  }
+    $from = unformat_email($args['from']);
+  }
+  $mail->setFrom($from['email'], $from['name']);
+  $mail->addReplyTo($from['email'], $from['name']);
 
   // Subject
@@ -521 +534 @@
     $args['subject'] = 'Piwigo';
   }
-  
   $args['subject'] = trim(preg_replace('#[\n\r]+#s', '', $args['subject']));
-
   $mail->Subject = $args['subject'];
 
@@ -529 +540 @@
   if (!empty($args['Cc']))
   {
-    $mail->addCC($args['Cc']);
+    foreach ($args['Cc'] as $cc)
+    {
+      $cc = unformat_email($cc);
+      $mail->addCC($cc['email'], $cc['name']);
+    }
   }
 
@@ -535 +550 @@
   if ($conf_mail['send_bcc_mail_webmaster'])
   {
-    $args['Bcc'][] = get_webmaster_mail_address();;
-  }
-
+    $args['Bcc'][] = get_webmaster_mail_address();
+  }
   if (!empty($args['Bcc']))
   {
     foreach ($args['Bcc'] as $bcc)
     {
-      $mail->addBCC($bcc);
-    }
+      $bcc = unformat_email($bcc);
+      $mail->addBCC($bcc['email'], $bcc['name']);
+    }
+  }
+
+  // theme
+  if (empty($args['theme']) or !in_array($args['theme'], array('clear','dark')))
+  {
+    $args['theme'] = $conf_mail['mail_theme'];
   }
 
   // content
-  if (empty($args['email_format']))
-  {
-    $args['email_format'] = $conf_mail['default_email_format'];
-  }
-
   if (!isset($args['content']))
   {
     $args['content'] = '';
   }
-
+  if (!isset($args['mail_title']))
+  {
+    $args['mail_title'] = $conf['gallery_title'];
+  }
+  if (!isset($args['mail_subtitle']))
+  {
+    $args['mail_subtitle'] = $args['subject'];
+  }
+
+  // content type
   if (empty($args['content_format']))
   {
@@ -562 +587 @@
   }
 
-  if (empty($args['theme']))
-  {
-    $args['theme'] = get_default_theme();
-  }
-
-  $content_type_list[] = $args['email_format'];
-  if (!empty($conf_mail['alternative_email_format']))
-  {
-    $content_type_list[] = $conf_mail['alternative_email_format'];
-  }
+  $content_type_list = array();
+  if ($conf_mail['allow_html_email'] and @$args['email_format'] != 'text/plain')
+  {
+    $content_type_list[] = 'text/html';
+  }
+  $content_type_list[] = 'text/plain';
 
   $contents = array();
-
-  foreach (array_unique($content_type_list) as $content_type)
-  {
-    // key compose of indexes witch allow ti cache mail data
-    $cache_key = $content_type.'-'.$lang_info['code'].'-'.$args['theme'];
+  foreach ($content_type_list as $content_type)
+  {
+    // key compose of indexes witch allow to cache mail data
+    $cache_key = $content_type.'-'.$lang_info['code'];
+    $cache_key.= '-'.crc32(@$args['mail_title'] . @$args['mail_subtitle']);
 
     if (!isset($conf_mail[$cache_key]))
     {
+      // instanciate a new Template
       if (!isset($conf_mail[$cache_key]['theme']))
       {
-        $conf_mail[$cache_key]['theme'] = get_mail_template($content_type, $args['theme']);
+        $conf_mail[$cache_key]['theme'] = get_mail_template($content_type);
+        trigger_action('before_parse_mail_template', $cache_key, $content_type);
       }
 
@@ -595 +618 @@
           'GALLERY_TITLE' => isset($page['gallery_title']) ? $page['gallery_title'] : $conf['gallery_title'],
           'VERSION' => $conf['show_version'] ? PHPWG_VERSION : '',
-          'PHPWG_URL' => PHPWG_URL,
-          'TITLE_MAIL' => urlencode(l10n('A comment on your site')),
-          'MAIL' => get_webmaster_mail_address()
+          'PHPWG_URL' => defined('PHPWG_URL') ? PHPWG_URL : '',
+          'CONTENT_ENCODING' => get_pwg_charset(),
+          'CONTACT_MAIL' => $conf_mail['email_webmaster'],
+          'MAIL_TITLE' => $args['mail_title'],
+          'MAIL_SUBTITLE' => $args['mail_subtitle'],
           )
         );
@@ -609 +634 @@
         }
 
-        $file = PHPWG_ROOT_PATH.'themes/'.$args['theme'].'/mail-css.tpl';
-        if (is_file($file))
+        if ($conf_mail[$cache_key]['theme']->smarty->template_exists('mail-css-'. $args['theme'] .'.tpl'))
         {
-          $conf_mail[$cache_key]['theme']->set_filename('css', realpath($file));
+          $conf_mail[$cache_key]['theme']->set_filename('css', 'mail-css-'. $args['theme'] .'.tpl');
           $conf_mail[$cache_key]['theme']->assign_var_from_handle('MAIL_CSS', 'css');
         }
       }
 
-      // what are displayed on the header of each mail ?
       $conf_mail[$cache_key]['header'] = $conf_mail[$cache_key]['theme']->parse('mail_header', true);
-
-      // what are displayed on the footer of each mail ?
       $conf_mail[$cache_key]['footer'] = $conf_mail[$cache_key]['theme']->parse('mail_footer', true);
     }
@@ -628 +649 @@
 
     // Content
-    if (($args['content_format'] == 'text/plain') and ($content_type == 'text/html'))
-    {
-      $contents[$content_type].= '<p>'.
-                  nl2br(
-                    preg_replace("/(http:\/\/)([^\s,]*)/i",
-                                 "<a href='$1$2' class='thumblnk'>$1$2</a>",
-                                 htmlspecialchars($args['content']))).
-                  '</p>';
-    }
-    else if (($args['content_format'] == 'text/html') and ($content_type == 'text/plain'))
+    if ($args['content_format'] == 'text/plain' and $content_type == 'text/html')
+    {
+      // convert plain text to html
+      $contents[$content_type].=
+        '<p>'.
+        nl2br(
+          preg_replace(
+            '/(https?:\/\/([-\w\.]+[-\w])+(:\d+)?(\/([\w\/_\.\#-]*(\?\S+)?[^\.\s])?)?)/i',
+            '<a href="$1">$1</a>',
+            htmlspecialchars($args['content'])
+            )
+          ).
+        '</p>';
+    }
+    else if ($args['content_format'] == 'text/html' and $content_type == 'text/plain')
     {
       // convert html text to plain text
@@ -654 +680 @@
   unset_make_full_url();
 
+  // Send content to PHPMailer
   if (isset($contents['text/html']))
   {
-    $mail->isHTML(true); // Set email format to HTML
-    $mail->Body = $contents['text/html'];
+    $mail->isHTML(true);
+    $mail->Body = move_css_to_body($contents['text/html']);
     
     if (isset($contents['text/plain']))
@@ -704 +731 @@
   }
 
-  $ret = $mail->send();
-  if(!$ret)
-  {
-    trigger_error( 'Mailer Error: ' . $mail->ErrorInfo, E_USER_WARNING);
-  }
+  $ret = true;
+  $pre_result = trigger_event('before_send_mail', true, $to, $args, $mail);
+
+  if ($pre_result)
+  {
+    $ret = $mail->send();
+    if (!$ret and is_admin())
+    {
+      trigger_error('Mailer Error: ' . $mail->ErrorInfo, E_USER_WARNING);
+    }
+  }
+
   return $ret;
 }
 
-/* DEPRECATED
- * pwg sendmail
- *
- * @param:
- *   - result of other sendmail
- *   - to: Receiver or receiver(s) of the mail.
- *   - subject  [default value 'Piwigo']
- *   - content: content of mail
- *   - headers: headers of mail
- *
- * @return boolean (Ok or not)
- */
-function pwg_send_mail($result, $to, $subject, $contents, $headers)
-{
+/**
+ * @deprecated 2.6
+ */
+function pwg_send_mail($result, $to, $subject, $content, $headers)
+{
+  trigger_error('pwg_send_mail function is deprecated', E_USER_NOTICE);
+  
   if (!$result)
   {
-    include_once(PHPWG_ROOT_PATH.'include/class.phpmailer.php');
+    return pwg_mail($to, array(
+        'content' => $content,
+        'subject' => $subject,
+      ));
+  }
+  else
+  {
+    return $result;
+  }
+}
+
+/**
+ * @deprecated 2.6
+ */
+function move_ccs_rules_to_body($content)
+{
+  trigger_error('move_ccs_rules_to_body function is deprecated, use move_css_to_body', E_USER_NOTICE);
+  
+  return move_css_to_body($content);
+}
+
+/**
+ * Moves CSS rules contained in the <style> tag to inline CSS
+ * (for compatibility with Gmail and such clients)
+ * @since 2.6
+ * @param string $content
+ * @return string
+ */
+function move_css_to_body($content)
+{
+  include_once(PHPWG_ROOT_PATH.'include/emogrifier.class.php');
+
+  $e = new Emogrifier($content);
+  $e->preserveStyleTag = true;
+  return $e->emogrify();
+}
+
+/**
+ * Saves a copy of the mail if _data/tmp
+ * @param boolean $result
+ * @param string $to
+ * @param array $args
+ * @param PHPMailer $mail
+ * @return boolean $result
+ */
+function pwg_send_mail_test($result, $to, $args, $mail)
+{
+  global $conf, $user, $lang_info;
+  
+  $dir = PHPWG_ROOT_PATH.$conf['data_location'].'tmp';
+  if (mkgetdir($dir, MKGETDIR_DEFAULT&~MKGETDIR_DIE_ON_ERROR))
+  {
+    $filename = $dir.'/mail.'.stripslashes($user['username']).'.'.$lang_info['code'].'.'.$args['theme'].'-'.date('YmdHis');
+    if ($args['content_format'] == 'text/plain')
+    {
+      $filename .= '.txt';
+    }
+    else
+    {
+      $filename .= '.html';
+    }
     
-    global $conf_mail;
-
-    if ($conf_mail['use_smtp'])
-    {
-      include_once( PHPWG_ROOT_PATH.'include/class_smtp_mail.inc.php' );
-      $smtp_mail = new smtp_mail(
-        $conf_mail['smtp_host'], $conf_mail['smtp_user'], $conf_mail['smtp_password'],
-        $conf_mail['email_webmaster']);
-      return $smtp_mail->mail($to, $subject, $content, $headers);
-    }
-    else
-    {
-      $mail = new PHPMailer;
-
-      $mail->From = 'plg@pigolabs.com';
-      $mail->FromName = 'Pierrick en local';
-      foreach (explode(',', $to) as $recipient)
-      {
-        $mail->addAddress($recipient);  // Add a recipient
-      }
-      // $mail->addReplyTo('plg@piwigo.org', 'Pierrick de Piwigo.org');
-      // $mail->addCC('cc@example.com');
-      // $mail->addBCC('bcc@example.com');
-
-      $mail->WordWrap = 76;                                // Set word wrap to 50 characters
-
-      if (isset($contents['text/html']))
-      {
-        $mail->isHTML(true);                                 // Set email format to HTML
-        $mail->Body = $contents['text/html'];
-
-        if (isset($contents['text/plain']))
-        {
-          $mail->AltBody = $contents['text/plain'];
-        }
-      }
-      else
-      {
-        $mail->isHTML(false);
-        $mail->Body = $contents['text/plain'];
-      }
-
-      $mail->CharSet = 'UTF-8';
-      $mail->Subject = $subject;
-
-      if(!$mail->send()) {
-        echo 'Message could not be sent.';
-        echo 'Mailer Error: ' . $mail->ErrorInfo;
-        exit;
-      }
-
-      // if ($conf_mail['mail_options'])
-      // {
-      //   $options = '-f '.$conf_mail['email_webmaster'];
-      //   return mail($to, $subject, $content, $headers, $options);
-      // }
-      // else
-      // {
-      //   return mail($to, $subject, $content, $headers);
-      // }
-    }
-  }
-  else
-  {
-    return $result;
-  }
-}
-
-function move_ccs_rules_to_body($content)
-{
-  return $content;
-  // We search all css rules in style tags
-  preg_match('#<style>(.*?)</style>#s', $content, $matches);
-
-  if (!empty($matches[1]))
-  {
-    preg_match_all('#([^\n]*?)\{(.*?)\}#s', $matches[1], $matches);
-
-    $selectors = array();
-    $unknow_selectors = '';
-
-    foreach ($matches[1] as $key => $value)
-    {
-      $selects = explode(',', $value);
-      $style = trim($matches[2][$key], ' ;');
-
-      foreach($selects as $select)
-      {
-        $select = trim($select);
-        $selectors[$select][] = $style;
-      }
-    }
-
-    foreach ($selectors as $selector => $style)
-    {
-      if (!preg_match('/^(#|\.|)([A-Za-z0-9_-]*)$/', $selector, $matches))
-      {
-        $unknow_selectors .= $selector.' {'.implode(";\n", $style).";}\n";
-      }
-      else switch ($matches[1])
-      {
-        case '#':
-          $content = preg_replace('|id="'.$matches[2].'"|', 'id="'.$matches[2].'" style="'.implode(";\n", $style).";\"\n", $content);
-          break;
-        case '.':
-          $content = preg_replace('|class="'.$matches[2].'"|', 'class="'.$matches[2].'" style="'.implode(";\n", $style).";\"\n", $content);
-          break;
-        default:
-          $content = preg_replace('#<'.$matches[2].'( |>)#', '<'.$matches[2].' style="'.implode(";\n", $style).";\"\n$1", $content);
-          break;
-      }
-    }
-
-    // Keep unknow tags in page head
-    if (!empty($unknow_selectors))
-    {
-      $content = preg_replace('#<style>.*?</style>#s', "<style type=\"text/css\">\n$unknow_selectors</style>", $content);
-    }
-    else
-    {
-      $content = preg_replace('#<style>.*?</style>#s', '', $content);
-    }
-  }
-  return $content;
-}
-
-/*Testing block*/
-function pwg_send_mail_test($result, $to, $subject, $content, $headers, $args)
-{
-    global $conf, $user, $lang_info;
-    $dir = PHPWG_ROOT_PATH.$conf['data_location'].'tmp';
-    if ( mkgetdir( $dir,  MKGETDIR_DEFAULT&~MKGETDIR_DIE_ON_ERROR) )
-    {
-      $filename = $dir.'/mail.'.stripslashes($user['username']).'.'.$lang_info['code'].'.'.$args['theme'].'-'.date('YmdHis');
-      if ($args['content_format'] == 'text/plain')
-      {
-        $filename .= '.txt';
-      }
-      else
-      {
-        $filename .= '.html';
-      }
-      $file = fopen($filename, 'w+');
-      fwrite($file, $to ."\n");
-      fwrite($file, $subject ."\n");
-      fwrite($file, $headers);
-      fwrite($file, $content);
-      fclose($file);
-    }
-    return $result;
-}
+    $file = fopen($filename, 'w+');
+    fwrite($file, implode(', ', $to) ."\n");
+    fwrite($file, $mail->Subject ."\n");
+    fwrite($file, $mail->createHeader() ."\n");
+    fwrite($file, $mail->createBody());
+    fclose($file);
+  }
+  
+  return $result;
+}
+
 if ($conf['debug_mail'])
-  add_event_handler('send_mail', 'pwg_send_mail_test', EVENT_HANDLER_PRIORITY_NEUTRAL+10, 6);
-
-
-add_event_handler('send_mail', 'pwg_send_mail', EVENT_HANDLER_PRIORITY_NEUTRAL, 5);
-add_event_handler('send_mail_content', 'move_ccs_rules_to_body');
+{
+  add_event_handler('before_send_mail', 'pwg_send_mail_test', EVENT_HANDLER_PRIORITY_NEUTRAL+10, 4);
+}
+
 trigger_action('functions_mail_included');
 

trunk/themes/default/template/mail/text/html/footer.tpl

@@ -1 @@
-</div> <!-- content -->
-<div id="copyright">
-<hr>
-  {'Sent by'|@translate}
-  <a href="{$GALLERY_URL}">{$GALLERY_TITLE}</a>
+            {* <!-- end $CONTENT --> *}
+          </td></tr>
 
- {* Please, do not remove this copyright. If you really want to,
-      contact us on http://piwigo.org to find a solution on how
-      to show the origin of the script...*}
-  - {'Powered by'|@translate}
-  <a href="http://piwigo.org" class="Piwigo">
-  <span class="Piwigo">Piwigo</span></a>
-  {$VERSION}
+          <tr><td id="footer">
+            {* <!-- begin FOOTER --> *}
+{* <!-- Please, do not remove this copyright. If you really want to,
+contact us on http://piwigo.org to find a solution on how
+to show the origin of the script... --> *}
+      
+            {'Sent by'|translate} <a href="{$GALLERY_URL}">{$GALLERY_TITLE}</a>
+            - {'Powered by'|translate} <a href="{$PHPWG_URL}" class="Piwigo">Piwigo</a>
+            {if not empty($VERSION)}{$VERSION}{/if}
+            
+            - {'Contact'|translate}
+            <a href="mailto:{$CONTACT_MAIL}?subject={'A comment on your site'|translate|escape:url}">{'Webmaster'|@translate}</a>
+            {* <!-- end FOOTER --> *}
+          </td></tr>
+        </table>
 
-  - {'Contact'|@translate}
-  <a href="mailto:{$MAIL}?subject={$TITLE_MAIL}">{'Webmaster'|@translate}</a>
-
-</div> <!-- copyright -->
-</div> <!-- the_page -->
-
-</body>
+      </td></tr>
+    </table>
+  </body>
 </html>

trunk/themes/default/template/mail/text/html/global-mail-css.tpl

@@ -1 @@
-/* Global mail css */
+{strip}
+/* page */
+body {
+  font-family:"Verdana", "Helvetica", "Optima", sans-serif;
+  font-size:12px;
+  margin:0px;
+  padding:0px;
+}
 
-body {ldelim} font-family: Univers, Helvetica, Optima; font-size:12px; margin:0px; padding:0px; }
-#the_page {ldelim} margin:0px; padding:0px; text-align:left;}
-#content {ldelim} margin:0px; padding:30px 0px 0px 30px; width:732px;}
-hr {ldelim} width:632px; margin-left:0;}
-#copyright {ldelim} font-size:10px; margin:0px; padding:48px 0px 32px 62px;}
-.PWG {ldelim} font-family:verdana, sans-serif !important; font-size:0.9em; font-weight:normal; letter-spacing:0px;}
-h2 {ldelim} padding:7px 15px; width:617px; font-weight:bold;}
-img {ldelim} margin:16px; border:16px solid #aaa; -moz-border-radius: 4px; border-radius: 4px 4px; }
-img:hover {ldelim} padding: 15px; border: 1px solid yellow; -moz-border-radius: 4px; border-radius: 4px 4px; }
+html, body, #bodyTable {
+  width:100%;
+  height:100%;
+}
+
+/* main block */
+#header {
+  padding:20px;
+}
+#header #title {
+  font-size:26px;
+  font-weight:bold;
+}
+#header #subtitle {
+  font-size:20px;
+}
+#content {
+  padding:0 20px 20px 20px;
+}
+#footer {
+  font-size:10px;
+  padding:5px;
+}
+#topSpacer {
+  margin-bottom:20px;
+}
+
+/* images */
+img {
+  border:none;
+}
+
+h1, h2, h3, h4, h5 {
+  margin:0.5em 0 0.25em 0;
+}
+h1 { font-size:26px; }
+h2 { font-size:20px; }
+h3 { font-size:16px; }
+h4 { font-size:12px; }
+h5 { font-size:10px; }
+
+/* paragraphs */
+p {
+  margin:0.25em 0 0.5em 0;
+}
+blockquote {
+  margin-left:10px;
+  padding-left:10px;
+  font-family:"Times",serif;
+  font-size:14px;
+}
+
+/* list */
+ul, ol {
+  margin:0.5em 0 0.25em 30px;
+  padding:0;
+}
+dl {
+  margin:0.5em 0 0.25em 10px;
+}
+dt {
+  margin:0.25em 0 0 0;
+  font-weight:bold;
+}
+dd {
+  margin:0 0 0.25em 10px;
+}
+
+/* tables */
+#content table {
+  width:100%;
+  border-spacing:0;
+  border-collapse:collapse;
+}
+#content table td {
+  padding:2px 3px;
+}
+#content table th {
+  font-weight:bold;
+  text-align:center;
+  padding:4px 0;
+}
+#content table tfoot td {
+  font-size:0.8em;
+}
+
+/* line */
+hr {
+  border-width:0 0 1px 0;
+  border-color:#ddd;
+  border-style:solid;
+  margin:1em;
+}
+{/strip}

trunk/themes/default/template/mail/text/html/header.tpl

@@ -1 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html lang="{$lang_info.code}" dir="{$lang_info.direction}">
-<head>
-<title>Piwigo Mail</title>
-<meta http-equiv="Content-Type" content="text/html; charset={$CONTENT_ENCODING}">
-<style><!-- /* Mini style for mails */
-{if isset($GLOBAL_MAIL_CSS)}{$GLOBAL_MAIL_CSS}{/if}
-{if isset($MAIL_CSS)}{$MAIL_CSS}{/if}
---></style>
-</head>
-<body>
-<div id="the_page">
-<div id="content" class="content">
+  <head>
+    <meta http-equiv="Content-Type" content="text/html; charset={$CONTENT_ENCODING}"/>
+    <title>Piwigo Mail</title>
+
+    <style type="text/css">
+    {if isset($GLOBAL_MAIL_CSS)}{$GLOBAL_MAIL_CSS}{/if}
+    {if isset($MAIL_CSS)}{$MAIL_CSS}{/if}
+    </style>
+  </head>
+
+  <body>
+    <table id="bodyTable" cellspacing="0" cellpadding="10" border="0">
+      <tr><td align="center" valign="top">
+
+        <table id="contentTable" cellspacing="0" cellpadding="0" border="0">
+          <tr><td id="header">
+            {* <!-- begin HEADER --> *}
+            <div id="title">{$MAIL_TITLE}</div>
+            {if not empty($MAIL_SUBTITLE)}<div id="subtitle">{$MAIL_SUBTITLE}</div>{/if}
+            {* <!-- end HEADER --> *}
+          </td></tr>
+
+          <tr><td id="content">
+{* <!-- use an invisible div with a bottom margin to force the browser 
+to merge the margin with the element bellow (typically h1/h2/...) --> *}
+            <div id="topSpacer"></div>
+            {* <!-- begin CONTENT --> *}

trunk/themes/default/template/mail/text/plain/footer.tpl

@@ +1 @@
+{literal}
 
--- 
+{/literal}
+----
 {'Sent by'|@translate} "{$GALLERY_TITLE}" {$GALLERY_URL}
-{'Contact'|@translate} {$MAIL}
-{'Powered by'|@translate} Piwigo {$VERSION}
+{'Powered by'|@translate} "Piwigo{if not empty($VERSION)} {$VERSION}{/if}" {$PHPWG_URL}
+{'Contact'|@translate}: {$CONTACT_MAIL}

trunk/themes/default/template/mail/text/plain/header.tpl

@@ +1 @@
+{$MAIL_TITLE}
+{if not empty($MAIL_SUBTITLE)}{$MAIL_SUBTITLE}
+{/if}
+----
 {literal}
-
-{/literal}{*note that there must be an empty line to separate the mime headers*}
+{/literal}