Changeset 26619 for extensions/oAuth

Timestamp:

Jan 11, 2014, 2:11:21 PM (10 years ago)

Author:

mistic100

Message:

move "oauth_id" field to user + display 16px icon on users list

Location:

extensions/oAuth

Files:

• auth.php (modified) (2 diffs)
• include/admin_events.inc.php (added)
• include/functions.inc.php (modified) (1 diff)
• include/public_events.inc.php (modified) (2 diffs)
• main.inc.php (modified) (3 diffs)
• maintain.inc.php (modified) (2 diffs)

extensions/oAuth/auth.php

@@ -22 +22 @@
   if ($provider == 'Persona')
   {
-    if (!verify_ephemeral_key(@$_POST['key']) | empty($_POST['assertion']))
+    if (!verify_ephemeral_key(@$_POST['key']) || empty($_POST['assertion']))
     {
       header('HTTP/1.1 403 Forbidden');
@@ -63 +63 @@
     // check is already registered
     $query = '
-SELECT id FROM ' . USERS_TABLE . '
+SELECT user_id FROM ' . USER_INFOS_TABLE . '
   WHERE oauth_id = "' . implode('---', $oauth_id) . '"
 ;';

extensions/oAuth/include/functions.inc.php

@@ -62 +62 @@
 function get_oauth_id($user_id)
 {
-  global $conf;
-  
   $query = '
-SELECT oauth_id FROM ' . USERS_TABLE . '
-  WHERE ' . $conf['user_fields']['id'] . ' = ' . $user_id . '
+SELECT oauth_id FROM ' . USER_INFOS_TABLE . '
+  WHERE user_id = ' . $user_id . '
   AND oauth_id != ""
 ;';

extensions/oAuth/include/public_events.inc.php

@@ -28 +28 @@
   
   $query = '
-SELECT oauth_id FROM ' . USERS_TABLE . '
+SELECT oauth_id
+  FROM ' . USER_INFOS_TABLE . ' AS i
+    INNER JOIN ' . USERS_TABLE . ' AS u
+    ON i.user_id = u.' . $conf['user_fields']['id'] . '
   WHERE ' . $conf['user_fields']['username'] . ' = "' . pwg_db_real_escape_string($username) . '"
   AND oauth_id != ""
@@ -125 +128 @@
           // update oauth field
           $query = '
-UPDATE ' . USERS_TABLE . '
+UPDATE ' . USER_INFOS_TABLE . '
   SET oauth_id = "' . $oauth_id . '"
-  WHERE ' . $conf['user_fields']['id'] . ' = ' . $user_id . '
+  WHERE user_id = ' . $user_id . '
 ;';
           pwg_query($query);

extensions/oAuth/main.inc.php

@@ -30 +30 @@
 }
 
-// force getuserdata() to retrieve 'oauth_id' field
-$conf['user_fields']['oauth_id'] = 'oauth_id';
-
 
 add_event_handler('init', 'oauth_init');
@@ -39 +36 @@
 {
   add_event_handler('get_admin_plugin_menu_links', 'oauth_admin_plugin_menu_links');
+  
+  add_event_handler('user_list_columns', 'oauth_user_list_columns');
+  add_event_handler('after_render_user_list', 'oauth_user_list_render');
+  
+  add_event_handler('loc_begin_admin_page', 'oauth_user_list');
+  
+  include_once(OAUTH_PATH . 'include/admin_events.inc.php');
 }
 else if (!empty($hybridauth_conf) and function_exists('curl_init'))
@@ -101 +105 @@
     // }
   // }
-  
-  // pwg_unset_session_var('persona_logout');
 }
-
-function oauth_admin_plugin_menu_links($menu) 
-{
-  $menu[] = array(
-    'NAME' => 'Social Connect',
-    'URL' => OAUTH_ADMIN,
-    );
-  return $menu;
-}

extensions/oAuth/maintain.inc.php

@@ -32 +32 @@
     }
     
+    $result = pwg_query('SHOW COLUMNS FROM `' . USER_INFOS_TABLE . '` LIKE "oauth_id";');
+    if (!pwg_db_num_rows($result))
+    {
+      pwg_query('ALTER TABLE `' . USER_INFOS_TABLE . '` ADD `oauth_id` VARCHAR(255) DEFAULT NULL;');
+    }
+    
+    // move field from users table to user_infos
     $result = pwg_query('SHOW COLUMNS FROM `' . USERS_TABLE . '` LIKE "oauth_id";');
-    if (!pwg_db_num_rows($result))
-    {      
-      pwg_query('ALTER TABLE `' . USERS_TABLE . '` ADD `oauth_id` VARCHAR(255) DEFAULT NULL;');
+    if (pwg_db_num_rows($result))
+    {
+      $query = '
+UPDATE `' . USER_INFOS_TABLE . '` AS i
+  SET oauth_id = (
+    SELECT oauth_id
+      FROM `' . USERS_TABLE . '` AS u
+      WHERE u.'.$conf['user_fields']['id'].' = i.user_id
+    )
+;';
+      pwg_query($query);
+      
+      pwg_query('ALTER TABLE `' . USERS_TABLE . '` DROP `oauth_id`;');
     }
     
@@ -76 +93 @@
     conf_delete_param('oauth');
 
-    pwg_query('ALTER TABLE `'. USERS_TABLE .'` DROP `oauth_id`;');
+    pwg_query('ALTER TABLE `'. USER_INFOS_TABLE .'` DROP `oauth_id`;');
     
     @unlink($this->file);