Changeset 27563 for extensions/rv_db_integrity/check_db.php

Timestamp:

Mar 5, 2014, 9:44:20 PM (10 years ago)

Author:

rvelices

Message:

• check parent/child album status/visibility/permissions
• show offending ids for missing foreign keys

File:

• extensions/rv_db_integrity/check_db.php (modified) (4 diffs)

extensions/rv_db_integrity/check_db.php

@@ -20 +20 @@
   GROUP BY ref.'.$reff;
 
-  $result = pwg_query($query);
-  return pwg_db_num_rows($result);
+        return query2array($query,null,$reff);
 }
 
@@ -75 +74 @@
                 {
                         $err = check_table_ref($table, $field_name, $test[0], $test[1] );
-                        if ($err)
+                        if (count($err))
                         {
                                 $failed++;
-                                $tpl_var['errors'][]= $err.' error references; #'.$test[0].'.'.$test[1].' referring to #'.$table.'.'.$field_name;
+                                $tpl_var['errors'][]= count($err).' error references; #'.$test[0].'.'.$test[1].' referring to #'.$table.'.'.$field_name;
+                                $tpl_var['errors'][]= 'Offending '.$test[1].' '.implode(',',$err);
                         }
                 }
@@ -107 +107 @@
 $template->append('reference_tests', $tpl_var);
 
+// Status/visible tests
+$tpl_var = array(
+                'ID' => 'status',
+                'LABEL' => 'Album status/visibility',
+                'CHECKED' => isset($_POST['status']) ? 'checked="checked"' : $default_checked,
+                'COUNT' => 1,
+        );
+if (isset($_POST['status']))
+{
+        $failed = 0;
+        $query = '
+SELECT id,name,id_uppercat,status,visible
+  FROM '.CATEGORIES_TABLE;
+        $cats = query2array($query,'id');
+        foreach($cats as $cat)
+        {
+                if (!isset($cat['id_uppercat'])) continue;
+                if ('public'==$cat['status'] && 'public'!=$cats[$cat['id_uppercat']]['status'])
+                {
+                        $failed++;
+                        $tpl_var['errors'][] = 'Public album '.$cat['id'].' '.$cat['name'].' parent '.$cat['id_uppercat'].' is '.$cats[$cat['id_uppercat']]['status'];
+                }
+                if ('true'==$cat['visible'] && 'true'!=$cats[$cat['id_uppercat']]['visible'])
+                {
+                        $failed++;
+                        $tpl_var['errors'][] = 'Visible album '.$cat['id'].' '.$cat['name'].' parent '.$cat['id_uppercat'].' is '.$cats[$cat['id_uppercat']]['visible'];
+                }
+        }
+        $tpl_var['result'] = $failed;
+}
+$template->append('reference_tests', $tpl_var);
+
+// Permissions
+$tpl_var = array(
+                'ID' => 'permissions',
+                'LABEL' => 'Permissions',
+                'CHECKED' => isset($_POST['permissions']) ? 'checked="checked"' : $default_checked,
+                'COUNT' => 1,
+        );
+if (isset($_POST['permissions']))
+{
+        $query = '
+SELECT id,name,id_uppercat
+        FROM '.CATEGORIES_TABLE.'
+        WHERE status="private"';
+        $cats = query2array($query,'id');
+
+        $groups = array_fill_keys( array_keys($cats), array());
+        $query = 'SELECT cat_id,group_id FROM '.GROUP_ACCESS_TABLE;
+        $result = pwg_query($query);
+        while ($row=pwg_db_fetch_assoc($result))
+                $groups[$row['cat_id']][] = $row['group_id'];
+
+        $users = array_fill_keys( array_keys($cats), array());
+        $query = 'SELECT cat_id,user_id FROM '.USER_ACCESS_TABLE;
+        $result = pwg_query($query);
+        while ($row=pwg_db_fetch_assoc($result))
+                $users[$row['cat_id']][] = $row['user_id'];
+
+        $failed = 0;
+        foreach($cats as $cat)
+        {
+                if (!isset($cats[$cat['id_uppercat']])) continue;
+                foreach( array('users','groups') as $type)
+                {
+                        $arr = $$type;
+                        $me = $arr[$cat['id']];
+                        $dad = $arr[$cat['id_uppercat']];
+                        $delta = array_diff($me, $dad);
+                        if (count($delta))
+                        {
+                                $tpl_var['errors'][] = 'Album '.$cat['id'].' '.$cat['name'].' too many '.$type.' permissions '.implode(',',$delta);
+                                $failed++;
+                        }
+                }
+        }
+        $tpl_var['result'] = $failed;
+}
+$template->append('reference_tests', $tpl_var);
+
 
 // #images(id,storage_category_id) vs. #image_category(image_id,category_id) ---
@@ -117 +197 @@
 if (isset($_POST['id_storage_category_id']))
 {
-  $query = '
+        $query = '
 SELECT i.id, i.storage_category_id, i.path
   FROM '.IMAGES_TABLE.' i LEFT JOIN '.IMAGE_CATEGORY_TABLE.' ic ON ic.image_id=i.id AND ic.category_id=i.storage_category_id