Changeset 281

Timestamp:

Jan 16, 2004, 12:19:51 AM (20 years ago)

Author:

z0rglub

Message:

improved function update_category essentially by using INNER JOIN instead of
LEFT JOIN

File:

• branches/release-1_3/admin/include/functions.php (modified) (1 diff)

branches/release-1_3/admin/include/functions.php

@@ -380 +380 @@
     $query.= ' WHERE category_id = '.$id;
     $query.= ';';
-    $row = mysql_fetch_array( mysql_query( $query ) );
+    list( $nb_images ) = mysql_fetch_array( mysql_query( $query ) );
+    // updating the date_last
+    $query = 'SELECT MAX(date_available) AS date_available';
+    $query.= ' FROM '.PREFIX_TABLE.'images';
+    $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category ON id = image_id';
+    $query.= ' WHERE category_id = '.$id;
+    $query.= ';';
+    list( $date_available ) = mysql_fetch_array( mysql_query( $query ) );
+    
     $query = 'UPDATE '.PREFIX_TABLE.'categories';
-    $query.= ' SET nb_images = '.$row['nb_images'];
+    $query.= " SET date_last = '".$date_available."'";
+    $query.= ' SET nb_images = '.$nb_images;
     $query.= ' WHERE id = '.$id;
     $query.= ';';
     mysql_query( $query );
-    // updating the date_last
-    $query = 'SELECT date_available';
-    $query.= ' FROM '.PREFIX_TABLE.'images';
-    $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category ON id = image_id';
-    $query.= ' WHERE category_id = '.$id;
-    $query.= ' ORDER BY date_available DESC';
-    $query.= ' LIMIT 0,1';
-    $query.= ';';
-    $row = mysql_fetch_array( mysql_query( $query ) );
-    $query = 'UPDATE '.PREFIX_TABLE.'categories';
-    $query.= " SET date_last = '".$row['date_available']."'";
-    $query.= ' WHERE id = '.$id;
-    $query.= ';';
-    mysql_query( $query );
+
     // updating the representative_picture_id : if the representative
     // picture of the category is not any more linked to the category, we