Changeset 29074 for trunk/admin

Timestamp:

Jul 25, 2014, 11:10:49 AM (10 years ago)

Author:

plg

Message:

bug 3104: less rights for admins (compared to webmaster). Now an admin can't:

• delete a webmaster
• give webmaster/admin status to any user
• change status of a webmaster/admin

Location:

trunk/admin

Files:

• themes/default/template/user_list.tpl (modified) (2 diffs)
• user_list.php (modified) (2 diffs)

trunk/admin/themes/default/template/user_list.tpl

@@ -34 +34 @@
   'true':"{'Yes'|translate}",
   'false':"{'No'|translate}",
+};
+
+var statusLabels = {
+{foreach from=$label_of_status key=status item=label}
+  '{$status}' : '{$label|escape:javascript}',
+{/foreach}
 };
 {/footer_script}
@@ -261 +267 @@
           user.email = user.email || '';
           
-          jQuery("#action select[name=status] option").each(function() {
-            if (user.status == jQuery(this).val()) {
-              user.statusLabel = jQuery(this).html();
-            }
-          });
+          user.statusLabel = statusLabels[user.status];
           
                       /* Render the underscore template */

trunk/admin/user_list.php

@@ -100 +100 @@
   );
 
+// an admin can't delete other admin/webmaster
+if ('admin' == $user['status'])
+{
+  $query = '
+SELECT
+    user_id
+  FROM '.USER_INFOS_TABLE.'
+  WHERE status IN (\'webmaster\', \'admin\')
+;';
+  $protected_users = array_merge($protected_users, query2array($query, null, 'user_id'));
+}
+
 $template->assign(
   array(
@@ -118 +130 @@
 foreach (get_enums(USER_INFOS_TABLE, 'status') as $status)
 {
-  // Only status <= can be assign
-  if (is_autorize_status(get_access_type_status($status)))
-  {
-    $pref_status_options[$status] = l10n('user_status_'.$status);
-  }
+  $label_of_status[$status] = l10n('user_status_'.$status);
 }
+
+$pref_status_options = $label_of_status;
+
+// a simple "admin" can set/remove statuses webmaster/admin
+if ('admin' == $user['status'])
+{
+  unset($pref_status_options['webmaster']);
+  unset($pref_status_options['admin']);
+}
+
+$template->assign('label_of_status', $label_of_status);
 $template->assign('pref_status_options', $pref_status_options);
 $template->assign('pref_status_selected', 'normal');