Changeset 301


Ignore:
Timestamp:
Jan 19, 2004, 10:18:34 PM (20 years ago)
Author:
z0rglub
Message:

Performances improved : replacing the useless LEFT JOIN by INNER JOIN

Location:
branches/release-1_3
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • branches/release-1_3/admin/infos_images.php

    r258 r301  
    5050    $query = 'SELECT id,file';
    5151    $query.= ' FROM '.PREFIX_TABLE.'images';
    52     $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category ON id = image_id';
     52    $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category ON id = image_id';
    5353    $query.= ' WHERE category_id = '.$page['cat'];
    5454    $query.= ';';
    … …  
    177177      $query = 'SELECT id,keywords';
    178178      $query.= ' FROM '.PREFIX_TABLE.'images';
    179       $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category ON id = image_id';
     179      $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category ON id = image_id';
    180180      $query.= ' WHERE category_id = '.$page['cat'];
    181181      $query.= ';';
    … …  
    280280  $query.= ',storage_category_id,category_id';
    281281  $query.= ' FROM '.PREFIX_TABLE.'images';
    282   $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category ON id = image_id';
     282  $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category ON id = image_id';
    283283  $query.= ' WHERE category_id = '.$page['cat'];
    284284  $query.= $conf['order_by'];

  • branches/release-1_3/include/functions_category.inc.php

    r296 r301  
    495495        $query = 'SELECT COUNT(DISTINCT(id)) AS nb_total_images';
    496496        $query.= ' FROM '.PREFIX_TABLE.'images';
    497         $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category AS ic';
     497        $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category AS ic';
    498498        $query.= ' ON id = ic.image_id';
    499499        $query.= $page['where'];
    … …  
    529529        $query = 'SELECT COUNT(DISTINCT(id)) AS nb_total_images';
    530530        $query.= ' FROM '.PREFIX_TABLE.'images';
    531         $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category AS ic';
     531        $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category AS ic';
    532532        $query.= ' ON id = ic.image_id';
    533533        $query.= $page['where'];

  • branches/release-1_3/picture.php

    r300 r301  
    4444}
    4545$query.= ' FROM '.PREFIX_TABLE.'images';
    46 $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category AS ic ON id = ic.image_id';
     46$query.= ' INNER JOIN '.PREFIX_TABLE.'image_category AS ic';
     47$query.= ' ON id = ic.image_id';
    4748$query.= $page['where'];
    4849$query.= ' AND id = '.$_GET['image_id'];
    … …  
    7879$query = 'SELECT DISTINCT(id)';
    7980$query.= ' FROM '.PREFIX_TABLE.'images';
    80 $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category AS ic ON id = ic.image_id';
     81$query.= ' INNER JOIN '.PREFIX_TABLE.'image_category AS ic';
     82$query.= ' ON id = ic.image_id';
    8183$query.= $page['where'];
    8284$query.= $conf['order_by'];
    … …  
    140142    $query = 'SELECT id';
    141143    $query.= ' FROM '.PREFIX_TABLE.'images';
    142     $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category AS ic';
     144    $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category AS ic';
    143145    $query.= ' ON id = ic.image_id';
    144146    $query.= $page['where'];
    … …  
    169171  $query = 'SELECT DISTINCT(id),name,file,tn_ext,storage_category_id';
    170172  $query.= ' FROM '.PREFIX_TABLE.'images';
    171   $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category AS ic ON id=ic.image_id';
     173  $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category AS ic';
     174  $query.= ' ON id=ic.image_id';
    172175  $query.= $page['where'];
    173176  $query.= $conf['order_by'];
    … …  
    277280  $query = 'SELECT DISTINCT(id),name,file,tn_ext,storage_category_id';
    278281  $query.= ' FROM '.PREFIX_TABLE.'images';
    279   $query.= ' LEFT JOIN '.PREFIX_TABLE.'image_category AS ic ON id=ic.image_id';
     282  $query.= ' INNER JOIN '.PREFIX_TABLE.'image_category AS ic';
     283  $query.= ' ON id=ic.image_id';
    280284  $query.= $page['where'];
    281285  $query.= $conf['order_by'];
Note: See TracChangeset for help on using the changeset viewer.