Changeset 311

Timestamp:

Jan 22, 2004, 12:33:56 AM (20 years ago)

Author:

z0rglub

Message:

Php warnings correction

Location:

branches/release-1_3

Files:

• admin/comments.php (modified) (1 diff)
• admin/include/functions.php (modified) (2 diffs)
• admin/infos_images.php (modified) (1 diff)
• admin/picture_modify.php (modified) (3 diffs)
• admin/user_list.php (modified) (1 diff)
• category.php (modified) (1 diff)

branches/release-1_3/admin/comments.php

@@ -37 +37 @@
     $subrow = mysql_fetch_array( $subresult );
 
-    if ( $array_cat_directories[$subrow['cat_id']] == '' )
+    if ( !isset( $array_cat_directories[$subrow['cat_id']] ) )
     {
       $array_cat_directories[$subrow['cat_id']] =

branches/release-1_3/admin/include/functions.php

@@ -405 +405 @@
     // if the category has no representative picture (ie
     // representative_picture_id == NULL) we don't update anything
-    if ( $row['representative_picture_id'] != '' )
+    if ( isset( $row['representative_picture_id'] ) )
     {
       $query = 'SELECT image_id';
@@ -692 +692 @@
   $uppercat = $page['plain_structure'][$category_id]['id_uppercat'];
 
-  while ( $uppercat != '' )
+  while ( $uppercat != 'NULL' )
   {
     array_push( $uppercats, $uppercat );

branches/release-1_3/admin/infos_images.php

@@ -180 +180 @@
       while ( $row = mysql_fetch_array( $result ) )
       {
-        $specific_keywords = explode( ',', $row['keywords'] );
+        if ( !isset( $row['keywords'] ) ) $specific_keywords = array();
+        else $specific_keywords = explode( ',', $row['keywords'] );
+        
         $common_keywords   = get_keywords( $_POST['keywords_cat'] );
         // first possiblity : adding the given keywords to all the pictures

branches/release-1_3/admin/picture_modify.php

@@ -96 +96 @@
     // if the user ask this picture to be not any more the representative,
     // we have to set the representative_picture_id of this category to NULL
-    else if ( $row['representative_picture_id'] == $_GET['image_id'] )
+    else if ( isset( $row['representative_picture_id'] )
+              and $row['representative_picture_id'] == $_GET['image_id'] )
     {
       $query = 'UPDATE '.PREFIX_TABLE.'categories';
@@ -187 +188 @@
 $vtp->setVar( $sub, 'form_action', $action );
 // retrieving direct information about picture
-$query = 'SELECT file,date_available,date_creation,tn_ext,name,filesize';
-$query.= ',width,height,author,comment,keywords,storage_category_id';
+$infos = array( 'file','date_available','date_creation','tn_ext','name'
+                ,'filesize','width','height','author','comment','keywords'
+                ,'storage_category_id' );
+$query = 'SELECT '. implode( ',', $infos );
 $query.= ' FROM '.PREFIX_TABLE.'images';
 $query.= ' WHERE id = '.$_GET['image_id'];
 $query.= ';';
 $row = mysql_fetch_array( mysql_query( $query ) );
+
+foreach ( $infos as $info ) {
+  if ( !isset( $row[$info] ) ) $row[$info] = '';
+}
+
 // picture title
 if ( $row['name'] == '' )
@@ -315 +323 @@
   }
 
-  if ( $row['representative_picture_id'] == $_GET['image_id'] )
+  if ( isset( $row['representative_picture_id'] )
+       and $row['representative_picture_id'] == $_GET['image_id'] )
   {
     $vtp->setVar( $sub, 'linked_category.representative_checked',

branches/release-1_3/admin/user_list.php

@@ -59 +59 @@
   $row = mysql_fetch_array( mysql_query( $query ) );
   // confirm user deletion ?
-  if ( $_GET['confirm'] != 1 )
+  if ( !isset( $_GET['confirm'] ) )
   {
     $vtp->addSession( $sub, 'deletion' );

branches/release-1_3/category.php

@@ -286 +286 @@
     $file = get_filename_wo_extension( $row['file'] );
     // name of the picture
-    if ( $row['name'] != '' ) $name = $row['name'];
-    else                      $name = str_replace( '_', ' ', $file );
+    if ( isset( $row['name'] ) and $row['name'] != '' ) $name = $row['name'];
+    else $name = str_replace( '_', ' ', $file );
 
     if ( $page['cat'] == 'search' )