Changeset 3487 for trunk/comments.php

Timestamp:

Jul 1, 2009, 10:43:20 PM (15 years ago)

Author:

rvelices

Message:

• remove unnecessary addslashes in comments.cpp
• in template use modifier |@default instead of |default (generated code is faster because we indicate that the input is scalar and not an array)

File:

• trunk/comments.php (modified) (7 diffs)

trunk/comments.php

@@ -101 +101 @@
 if (isset($_GET['author']) and !empty($_GET['author']))
 {
-  $page['where_clauses'][] = 
-    'u.'.$conf['user_fields']['username'].' = \''.addslashes($_GET['author']).'\'
-     OR author = \''.addslashes($_GET['author']).'\'';    
+  $page['where_clauses'][] =
+    'u.'.$conf['user_fields']['username'].' = \''.$_GET['author'].'\'
+     OR author = \''.$_GET['author'].'\'';
 }
 
@@ -167 +167 @@
     and (is_admin() || $conf['user_can_edit_comment']))
 {
-  if (!empty($_POST['content'])) 
+  if (!empty($_POST['content']))
   {
-    update_user_comment(array('comment_id' => $_GET['edit'], 
+    update_user_comment(array('comment_id' => $_GET['edit'],
                               'image_id' => $_POST['image_id'],
                               'content' => $_POST['content']),
                         $_POST['key']
-                        ); 
+                        );
 
     $edit_comment = null;
   }
-  else 
+  else
   {
     $edit_comment = $_GET['edit'];
@@ -306 +306 @@
      , com.validated
   FROM '.IMAGE_CATEGORY_TABLE.' AS ic
-    INNER JOIN '.COMMENTS_TABLE.' AS com    
+    INNER JOIN '.COMMENTS_TABLE.' AS com
     ON ic.image_id = com.image_id
     LEFT JOIN '.USERS_TABLE.' AS u
@@ -375 +375 @@
           );
 
-    if (!empty($comment['author'])) 
+    if (!empty($comment['author']))
     {
       $author = $comment['author'];
@@ -398 +398 @@
         );
 
-    if (can_manage_comment('delete', $comment['author_id'])) 
+    if (can_manage_comment('delete', $comment['author_id']))
     {
       $url = get_root_url().'comments.php'
         .get_query_string_diff(array('delete','validate','edit'));
-      $tpl_comment['U_DELETE'] = 
+      $tpl_comment['U_DELETE'] =
         add_url_params($url,
                        array('delete'=>$comment['comment_id'])
@@ -411 +411 @@
       $url = get_root_url().'comments.php'
         .get_query_string_diff(array('edit', 'delete','validate'));
-      $tpl_comment['U_EDIT'] = 
+      $tpl_comment['U_EDIT'] =
         add_url_params($url,
                        array('edit'=>$comment['comment_id'])
                        );
-      if (isset($edit_comment) and ($comment['comment_id'] == $edit_comment)) 
+      if (isset($edit_comment) and ($comment['comment_id'] == $edit_comment))
       {
         $tpl_comment['IN_EDIT'] = true;
@@ -427 +427 @@
     if ( is_admin() && $comment['validated'] != 'true')
     {
-      $tpl_comment['U_VALIDATE'] = 
+      $tpl_comment['U_VALIDATE'] =
         add_url_params($url,
                        array('validate'=>$comment['comment_id'])