Changeset 3662 for trunk

Timestamp:

Jul 21, 2009, 11:41:31 PM (15 years ago)

Author:

plg

Message:

merge r3661 from branch 2.0 to trunk

feature 1071: improve log system on API calls. The log can be activated by a
configuration setting. The log file can be changed also with a configuration
setting.

improvement: pwg.images.add API methods gets a cleaner way to log received
parameters.

Location:

trunk/include

Files:

• config_default.inc.php (modified) (1 diff)
• ws_functions.inc.php (modified) (4 diffs)

trunk/include/config_default.inc.php

@@ -654 +654 @@
 // Web services are allowed (true) or completely forbidden (false)
 $conf['allow_web_services'] = true;
+
+// enable log for web services
+$conf['ws_enable_log'] = false;
+
+// web services log file path
+$conf['ws_log_filepath'] = '/tmp/piwigo_ws.log';
 
 // Maximum number of images to be returned foreach call to the web service

trunk/include/ws_functions.inc.php

@@ -991 +991 @@
   }
 
-  // name
-  // category_id
-  // file_content
-  // file_sum
-  // thumbnail_content
-  // thumbnail_sum
-  // rank
-
-  // $fh_log = fopen('/tmp/php.log', 'w');
-  // fwrite($fh_log, time()."\n");
-  // fwrite($fh_log, 'input rank :'.$params['rank']."\n");
-  // fwrite($fh_log, 'input:  '.$params['file_sum']."\n");
-  // fwrite($fh_log, 'input:  '.$params['thumbnail_sum']."\n");
+  foreach ($params as $param_key => $param_value) {
+    ws_logfile(
+      sprintf(
+        '[pwg.images.add] input param "%s" : "%s"',
+        $param_key,
+        is_null($param_value) ? 'NULL' : $param_value
+        )
+      );
+  }
 
   // does the image already exists ?
@@ -1028 +1024 @@
     $day
     );
-
-  //fwrite($fh_log, $upload_dir."\n");
 
   // create the upload directory tree if not exists
@@ -1224 +1218 @@
 
   invalidate_user_cache();
-
-  // fclose($fh_log);
 }
 
@@ -1791 +1783 @@
 function ws_logfile($string)
 {
-  return true;
+  global $conf;
+
+  if (!$conf['ws_enable_log']) {
+    return true;
+  }
 
   file_put_contents(
-    '/tmp/piwigo_ws.log',
+    $conf['ws_log_filepath'],
     '['.date('c').'] '.$string."\n",
     FILE_APPEND