Changeset 610 for trunk/admin

Timestamp:

Nov 20, 2004, 6:23:42 PM (20 years ago)

Author:

plg

Message:

• optimization : representative picture becomes mandatory for a non empty category. So, at each insertion in images table for a category, a new representative element is elected (by rand). This must be improved by not reelcting a random picture admin set an element as representative manually.

• optimization : recent cats page only needs 2 queries instead of 3*N (N categories to display). The bad point is that it shows representative element of recent cat and not a random element among recently added.

• optimization : empty cats page only needs 1 query per non empty sub category instead of... a lot. For each sub category, PhpWebGallery shows the representative element of a category chosen randomly in sub cats. Thus, get_non_empty_subcat_ids and get_first_non_empty_cat_id becomes obsolete.

• new function get_cat_display_name_cache to show category names with a caching for all gallery categories names. This function, to the contrary of get_cat_display_name shows names in the correct order...

Location:

trunk/admin

Files:

• include/functions.php (modified) (2 diffs)
• remote_site.php (modified) (1 diff)
• update.php (modified) (1 diff)

trunk/admin/include/functions.php

@@ -487 +487 @@
     AND id IN ('.implode(',', $cat_ids).')
 ;';
-    $result = pwg_query( $query );
-    while ( $row = mysql_fetch_array( $result ) )
+    $result = pwg_query($query);
+    while ($row = mysql_fetch_array($result))
     {
       $query = '
@@ -496 +496 @@
     AND image_id = '.$row['representative_picture_id'].'
 ;';
-      $result = pwg_query( $query );
-      if (mysql_num_rows($result) == 0)
-      {
+      $sub_result = pwg_query($query);
+      if (mysql_num_rows($sub_result) == 0)
+      {
+        // set a new representative element for this category
         $query = '
+SELECT image_id
+  FROM '.IMAGE_CATEGORY_TABLE.'
+  WHERE category_id = '.$row['id'].'
+  ORDER BY RAND()
+  LIMIT 0,1
+;';
+        $sub_sub_result = pwg_query($query);
+        if (mysql_num_rows($sub_sub_result) > 0)
+        {
+          list($representative) = mysql_fetch_array(pwg_query($query));
+          $query = '
+UPDATE '.CATEGORIES_TABLE.'
+  SET representative_picture_id = '.$representative.'
+  WHERE id = '.$row['id'].'
+;';
+          pwg_query($query);
+        }
+        else
+        {
+          $query = '
 UPDATE '.CATEGORIES_TABLE.'
   SET representative_picture_id = NULL
   WHERE id = '.$row['id'].'
 ;';
-        pwg_query( $query );
+          pwg_query($query);
+        }
       }
     }

trunk/admin/remote_site.php

@@ -431 +431 @@
     }
     $query.= '
+;';
+    pwg_query($query);
+    // set a new representative element for this category
+    $query = '
+SELECT image_id
+  FROM '.IMAGE_CATEGORY_TABLE.'
+  WHERE category_id = '.$category_id.'
+  ORDER BY RAND()
+  LIMIT 0,1
+;';
+    list($representative) = mysql_fetch_array(pwg_query($query));
+    $query = '
+UPDATE '.CATEGORIES_TABLE.'
+  SET representative_picture_id = '.$representative.'
+  WHERE id = '.$category_id.'
 ;';
     pwg_query($query);

trunk/admin/update.php

@@ -513 +513 @@
   (category_id,image_id) VALUES
   '.implode(',', $ids).'
+;';
+    pwg_query($query);
+
+    // set a new representative element for this category
+    $query = '
+SELECT image_id
+  FROM '.IMAGE_CATEGORY_TABLE.'
+  WHERE category_id = '.$category_id.'
+  ORDER BY RAND()
+  LIMIT 0,1
+;';
+    list($representative) = mysql_fetch_array(pwg_query($query));
+    $query = '
+UPDATE '.CATEGORIES_TABLE.'
+  SET representative_picture_id = '.$representative.'
+  WHERE id = '.$category_id.'
 ;';
     pwg_query($query);