Changeset 6312 for branches/2.1/include

Timestamp:

May 24, 2010, 1:31:58 AM (15 years ago)

Author:

plg

Message:

bug 1684 fixed: the test to check availability of the user_infos line was
wrong. I had changed the old db_num_rows > 0 because it was not working with
SQLite. As suggested by nicolas, let's use a simpler trick "count(1)" in the
query itself, this way it should work with any database engine.

I've also removed the while (true) (ugly infinite loop, with a condition for
exit) that was producing an infinite loop for Piwigo installations with 2.0
database model and 2.1 code (before launching upgrade.php)

File:

• branches/2.1/include/functions_user.inc.php (modified) (2 diffs)

branches/2.1/include/functions_user.inc.php

@@ -268 +268 @@
   $userdata = array();
 
+  // retrieve basic user data
   $query = '
 SELECT ';
@@ -290 +291 @@
   $row = pwg_db_fetch_assoc(pwg_query($query));
 
-  while (true)
-  {
-    $query = '
-SELECT ui.*, uc.*, t.name AS theme_name
+  // retrieve additional user data
+  $query = '
+SELECT
+    COUNT(1) AS counter,
+    ui.*,
+    uc.*,
+    t.name AS theme_name
   FROM '.USER_INFOS_TABLE.' AS ui
     LEFT JOIN '.USER_CACHE_TABLE.' AS uc ON ui.user_id = uc.user_id
     LEFT JOIN '.THEMES_TABLE.' AS t ON t.id = ui.theme
-  WHERE ui.user_id = \''.$user_id.'\'';
+  WHERE ui.user_id = \''.$user_id.'\'
+;';
+  $result = pwg_query($query);
+  $user_infos_row = pwg_db_fetch_assoc($result);
+  if (0 == $user_infos_row['counter']) {
+    create_user_infos($user_id);
+    
     $result = pwg_query($query);
-    if ($result)
-    {
-      break;
-    }
-    else
-    {
-      create_user_infos($user_id);
-    }
-  }
-
-  $row = array_merge($row, pwg_db_fetch_assoc($result));
+    $user_infos_row = pwg_db_fetch_assoc($result);
+  }
+
+  // then merge basic + additional user data
+  $row = array_merge($row, $user_infos_row);
 
   foreach ($row as $key => $value)