Changeset 672

Timestamp:

Jan 6, 2005, 11:16:21 PM (19 years ago)

Author:

plg

Message:

• upgrade scripts added for releases 1.3.x

• my_error function moved from admin/include/functions.php to include/functions.inc.php

• because MySQL temporary tables are not always authorized on creation, use a temporary table name (with the current microsecond) on a non temporary table (in mass_updates function)

• ability to retrieve distant full directories (usefull in upgrade scripts)

• global variables $count_queries and $queries_time moved into global array $page

• get_cat_display_name displays category names in correct order : the one given by uppercats

• function setup_style simplified

• default value for configuration parameter "show_nb_comments" set to false (less queries by default)

Location:

trunk

Files:

• admin/include/functions.php (modified) (7 diffs)
• include/functions.inc.php (modified) (2 diffs)
• include/functions_category.inc.php (modified) (1 diff)
• include/functions_user.inc.php (modified) (1 diff)
• include/page_tail.php (modified) (2 diffs)
• install/config.sql (modified) (1 diff)
• install/upgrade_1.3.0.php (added)
• install/upgrade_1.3.1.php (added)
• install/upgrade_1.3.2.php (added)
• install/upgrade_1.3.3.php (added)
• install/upgrade_1.3.4.php (added)
• upgrade.php (added)

trunk/admin/include/functions.php

@@ -768 +768 @@
 }
 
-// my_error returns (or send to standard output) the message concerning the
-// error occured for the last mysql query.
-function my_error($header, $echo = true)
-{
-  $error = $header.'<span style="font-weight:bold;">N°= '.mysql_errno();
-  $error.= ' -->> '.mysql_error()."</span><br /><br />\n";
-  if ($echo)
-  {
-    echo $error;
-  }
-  else
-  {
-    return $error;
-  }
-}
-
 /**
  * inserts multiple lines in a table
@@ -911 +895 @@
       }
     }
+    
+    $temporary_tablename = $tablename.'_'.micro_seconds();
+    
     $query = '
-CREATE TEMPORARY TABLE '.$tablename.'_temporary
+CREATE TABLE '.$temporary_tablename.'
 (
 '.implode(",\n", $columns).',
@@ -919 +906 @@
 ;';
     pwg_query($query);
-    mass_inserts($tablename.'_temporary', $all_fields, $datas);
+    mass_inserts($temporary_tablename, $all_fields, $datas);
     // update of images table by joining with temporary table
     $query = '
-UPDATE '.$tablename.' AS t1, '.$tablename.'_temporary AS t2
+UPDATE '.$tablename.' AS t1, '.$temporary_tablename.' AS t2
   SET '.implode("\n    , ",
                 array_map(
@@ -934 +921 @@
     pwg_query($query);
     $query = '
-DROP TABLE '.$tablename.'_temporary
+DROP TABLE '.$temporary_tablename.'
 ;';
     pwg_query($query);
@@ -1194 +1181 @@
   }
 
-  // filling $uppercats_array : to each category id the uppercats list is
-  // associated
-  $uppercats_array = array();
-  
-  $query = '
-SELECT id, uppercats
+  // caching galleries_url
+  $query = '
+SELECT id, galleries_url
+  FROM '.SITES_TABLE.'
+;';
+  $result = pwg_query($query);
+  $galleries_url = array();
+  while ($row = mysql_fetch_array($result))
+  {
+    $galleries_url[$row['id']] = $row['galleries_url'];
+  }
+
+  // categories : id, site_id, uppercats
+  $categories = array();
+  
+  $query = '
+SELECT id, uppercats, site_id
   FROM '.CATEGORIES_TABLE.'
   WHERE id IN (
@@ -1207 +1205 @@
   while ($row = mysql_fetch_array($result))
   {
-    $uppercats_array[$row['id']] = $row['uppercats'];
-  }
-  
-  $query = '
-SELECT galleries_url
-  FROM '.SITES_TABLE.'
-  WHERE id = 1
-';
-  $row = mysql_fetch_array(pwg_query($query));
-  $basedir = $row['galleries_url'];
+    array_push($categories, $row);
+  }
   
   // filling $cat_fulldirs
   $cat_fulldirs = array();
-  foreach ($uppercats_array as $cat_id => $uppercats)
-  {
-    $uppercats = str_replace(',', '/', $uppercats);
-    $cat_fulldirs[$cat_id] = $basedir.preg_replace('/(\d+)/e',
-                                                   "\$cat_dirs['$1']",
-                                                   $uppercats);
+  foreach ($categories as $category)
+  {
+    $uppercats = str_replace(',', '/', $category['uppercats']);
+    $cat_fulldirs[$category['id']] = $galleries_url[$category['site_id']];
+    $cat_fulldirs[$category['id']].= preg_replace('/(\d+)/e',
+                                                  "\$cat_dirs['$1']",
+                                                  $uppercats);
   }
 
@@ -1318 +1309 @@
   return $fs;
 }
+
+/**
+ * stupidly returns the current microsecond since Unix epoch
+ */
+function micro_seconds()
+{
+  $t1 = explode(' ', microtime());
+  $t2 = explode('.', $t1[0]);
+  $t2 = $t1[1].substr($t2[1], 0, 6);
+  return $t2;
+}
 ?>

trunk/include/functions.inc.php

@@ -487 +487 @@
 function pwg_query($query)
 {
-  global $conf,$count_queries,$queries_time;
+  global $conf,$page;
   
   $start = get_moment();
-  $result = mysql_query($query);
+  $result = mysql_query($query) or my_error($query."\n");
   
   $time = get_moment() - $start;
-  $count_queries++;
-  $queries_time+= $time;
+
+  if (!isset($page['count_queries']))
+  {
+    $page['count_queries'] = 0;
+    $page['queries_time'] = 0;
+  }
+  
+  $page['count_queries']++;
+  $page['queries_time']+= $time;
   
   if ($conf['show_queries'])
   {
     $output = '';
-    $output.= '<pre>['.$count_queries.'] '."\n".$query;
-    $output.= "\n".'(this query time : '.number_format( $time, 3, '.', ' ').' s)</b>';
-    $output.= "\n".'(total SQL time  : '.number_format( $queries_time, 3, '.', ' ').' s)';
+    $output.= '<pre>['.$page['count_queries'].'] ';
+    $output.= "\n".$query;
+    $output.= "\n".'(this query time : ';
+    $output.= number_format($time, 3, '.', ' ').' s)</b>';
+    $output.= "\n".'(total SQL time  : ';
+    $output.= number_format($page['queries_time'], 3, '.', ' ').' s)';
     $output.= '</pre>';
     
@@ -625 +635 @@
   return $src;
 }
+
+// my_error returns (or send to standard output) the message concerning the
+// error occured for the last mysql query.
+function my_error($header, $echo = true)
+{
+  $error = '<pre>';
+  $error.= $header;
+  $error.= '[mysql error '.mysql_errno().'] ';
+  $error.= mysql_error();
+  $error.= '</pre>';
+  if ($echo)
+  {
+    echo $error;
+  }
+  else
+  {
+    return $error;
+  }
+}
 ?>

trunk/include/functions_category.inc.php

@@ -222 +222 @@
   $cat['comment'] = nl2br($cat['comment']);
 
-  $cat['name'] = array();
-
+  $names = array();
   $query = '
 SELECT name,id
   FROM '.CATEGORIES_TABLE.'
   WHERE id IN ('.$cat['uppercats'].')
-  ORDER BY id ASC
 ;';
   $result = pwg_query($query);
   while($row = mysql_fetch_array($result))
   {
-    $cat['name'][$row['id']] = $row['name'];
+    $names[$row['id']] = $row['name'];
+  }
+
+  // category names must be in the same order than uppercats list
+  $cat['name'] = array();
+  foreach (explode(',', $cat['uppercats']) as $cat_id)
+  {
+    $cat['name'][$cat_id] = $names[$cat_id];
   }
   

trunk/include/functions_user.inc.php

@@ -209 +209 @@
 function setup_style($style)
 {
-  $template_path = 'template/' ;
-  $template_name = $style ;
-  $template = new Template(PHPWG_ROOT_PATH . $template_path . $template_name);
-  return $template;
+  return new Template(PHPWG_ROOT_PATH.'template/'.$style);
 }
 

trunk/include/page_tail.php

@@ -43 +43 @@
   $time = get_elapsed_time($t2, get_moment());
 
-  if (!isset($count_queries))
+  if (!isset($page['count_queries']))
   {
-    $count_queries = 0;
-    $queries_time = 0;
+    $page['count_queries'] = 0;
+    $page['queries_time'] = 0;
   }
   
@@ -52 +52 @@
     'debug',
     array('TIME' => $time,
-          'NB_QUERIES' => $count_queries,
-          'SQL_TIME' => number_format($queries_time, 3, '.', ' ').' s'));
+          'NB_QUERIES' => $page['count_queries'],
+          'SQL_TIME' => number_format($page['queries_time'],3,'.',' ').' s'));
 }
 

trunk/install/config.sql

@@ -21 +21 @@
 INSERT INTO phpwebgallery_config (param,value,comment) VALUES ('recent_period','7','Period within which pictures are displayed as new (in days)');
 INSERT INTO phpwebgallery_config (param,value,comment) VALUES ('auto_expand','false','Auto expand of the category tree');
-INSERT INTO phpwebgallery_config (param,value,comment) VALUES ('show_nb_comments','true','Show the number of comments under the thumbnails');
+INSERT INTO phpwebgallery_config (param,value,comment) VALUES ('show_nb_comments','false','Show the number of comments under the thumbnails');
 INSERT INTO phpwebgallery_config (param,value,comment) VALUES ('use_iptc','false','Use IPTC data during database synchronization with files metadata');
 INSERT INTO phpwebgallery_config (param,value,comment) VALUES ('use_exif','true','Use EXIF data during database synchronization with files metadata');