Changeset 6767

Timestamp:

Aug 16, 2010, 4:42:02 PM (14 years ago)

Author:

patdenice

Message:

Fix bug with htmlspecialchars on plugins name.

Location:

extensions/autoupdate/trunk

Files:

• include/functions_remote.inc.php (modified) (1 diff)
• plugins_update.php (modified) (1 diff)

extensions/autoupdate/trunk/include/functions_remote.inc.php

@@ -86 +86 @@
         if (!$plugins->plugin_version_compare($fs_plugin['version'], $plugin_info['revision_name']))
         {
-          if (in_array($fs_plugin['name'], $ignore_list))
+          $fs_plugin_name = htmlspecialchars_decode($fs_plugin['name']);
+
+          if (in_array($fs_plugin_name, $ignore_list))
           {
-            array_push($new_ignore_list, $fs_plugin['name']);
+            array_push($new_ignore_list, $fs_plugin_name);
           }
           else

extensions/autoupdate/trunk/plugins_update.php

@@ -10 +10 @@
 
   $replacement = '  <a href="{$plugin.URL_DOWNLOAD}">{\''.$l_key.'\'|@translate}</a><br>
-    <a href="#" onClick="autoupdate_ignore(\'{$plugin.EXT_NAME}\', true, {$smarty.foreach.plugins_loop.index}); return false;" id="au_ignore_{$smarty.foreach.plugins_loop.index}_true" {if $plugin.EXT_NAME|@in_array:$AU_IGNORE_LIST}style="display: none;"{/if}>{\'Don\\\'t notify on admin homepage\'|@translate}</a>
-    <a href="#" onClick="autoupdate_ignore(\'{$plugin.EXT_NAME}\', false, {$smarty.foreach.plugins_loop.index}); return false;" id="au_ignore_{$smarty.foreach.plugins_loop.index}_false" {if !$plugin.EXT_NAME|@in_array:$AU_IGNORE_LIST}style="display: none;"{/if}>{\'Notify on admin homepage\'|@translate}</a>';
+    <a href="#" onClick="autoupdate_ignore(\'{$plugin.EXT_NAME|@htmlspecialchars_decode}\', true, {$smarty.foreach.plugins_loop.index}); return false;" id="au_ignore_{$smarty.foreach.plugins_loop.index}_true" {if $plugin.EXT_NAME|@htmlspecialchars_decode|@in_array:$AU_IGNORE_LIST}style="display: none;"{/if}>{\'Don\\\'t notify on admin homepage\'|@translate}</a>
+    <a href="#" onClick="autoupdate_ignore(\'{$plugin.EXT_NAME|@htmlspecialchars_decode}\', false, {$smarty.foreach.plugins_loop.index}); return false;" id="au_ignore_{$smarty.foreach.plugins_loop.index}_false" {if !$plugin.EXT_NAME|@htmlspecialchars_decode|@in_array:$AU_IGNORE_LIST}style="display: none;"{/if}>{\'Notify on admin homepage\'|@translate}</a>';
 
   return str_replace($search, $replacement, $content);;