Changeset 9474 for extensions/LCAS/trunk/admin/LCAS_admin.php

Timestamp:

Mar 2, 2011, 1:38:30 PM (13 years ago)

Author:

Eric

Message:

bug 2208 re-fixed : Duplicate user control improvement on username update will work fine on this way (hopefully !)

File:

• extensions/LCAS/trunk/admin/LCAS_admin.php (modified) (1 diff)

extensions/LCAS/trunk/admin/LCAS_admin.php

@@ -90 +90 @@
         
         if ((isset($_POST['user-'.$lcas_UserToUpdate])) && ($_POST['user-'.$lcas_UserToUpdate] != '')) {
+
           // Check if username already exists
-                $count = 0;
                 $lcas_previous_compare_user = LCAS_change_case($_POST['user-'.$lcas_UserToUpdate], $conf_LCAS[0]);
-                      foreach ($page['all_users'] as $local_user)
-                      {
-                        if ($lcas_previous_compare_user == $local_user['transformed']) {
-                                $count = 1;
-                                break;
-                        }
-                      }
-
+
+          $LCAS_users = array();
+
+          // This is a dirty request - Works fine for small number of users but could be unoptimized for large number of users
           $query = '
-                 SELECT username
-                 FROM '.USERS_TABLE.'
-                 WHERE username="'.addslashes($_POST['user-'.$lcas_UserToUpdate]).'"
-          ;';
-        
-          $count = pwg_db_num_rows(pwg_query($query));
-
-          if ($count < 1)
+            SELECT '.$conf['user_fields']['username'].' AS username
+            FROM '.USERS_TABLE.';';
+          
+          while ($r = pwg_db_fetch_assoc(pwg_query($query)))
           {
-            // Get old username befor update - Usefull for user notification if is set
+            $LCAS_users[$r['username']] = LCAS_change_case($r['username'], $conf_LCAS[0]);
+          }
+            
+          $users_found = array_keys($LCAS_users, $lcas_previous_compare_user);
+
+          if (count($users_found) < 1)
+          {
+            // Get old username before update - Usefull for user notification if is set
             $query ='
               SELECT username