Changeset 9919 for extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/CommentService.java

Timestamp:

Mar 29, 2011, 8:21:25 PM (13 years ago)

Author:

mlg

Message:

Complete rewriting of the api
The api now uses interfaces everywhere (for the dao, services and session manager). This allows the developer to use his own implementations if he wants.
Deletion of the singletons. There are now getters and setters. It allows to make dependency injection.
Use of sl4j in the api, instead of using log4j.

File:

• extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/CommentService.java (modified) (3 diffs)

extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/service/CommentService.java

@@ -4 +4 @@
 import java.util.List;
 
-import fr.mael.jiwigo.dao.CommentDao;
 import fr.mael.jiwigo.om.Comment;
 import fr.mael.jiwigo.transverse.exception.ProxyAuthenticationException;
-import fr.mael.jiwigo.transverse.session.SessionManager;
 
-/*
- *  jiwigo-ws-api Piwigo webservice access Api
- *  Copyright (c) 2010-2011 Mael mael@le-guevel.com
- *                All Rights Reserved
- *
- *  This library is free software. It comes without any warranty, to
- *  the extent permitted by applicable law. You can redistribute it
- *  and/or modify it under the terms of the Do What The Fuck You Want
- *  To Public License, Version 2, as published by Sam Hocevar. See
- *  http://sam.zoy.org/wtfpl/COPYING for more details.
- */
-/**
-
- * @author mael
- *
- */
-public class CommentService {
-    /**
-     * Logger
-     */
-    public static final org.apache.commons.logging.Log LOG = org.apache.commons.logging.LogFactory
-            .getLog(CommentService.class);
-
-    /**
-     * singleton
-     */
-    private static CommentService instance;
-
-    private SessionManager sessionManager;
-
-    /**
-     * @return the singleton
-     */
-    public static CommentService getInstance(SessionManager sessionManager) {
-        if (instance == null) {
-            instance = new CommentService(sessionManager);
-        }
-        return instance;
-    }
-
-    /**
-     * private constructor, to use a singleton
-     */
-    private CommentService(SessionManager sessionManager) {
-        this.sessionManager = sessionManager;
-    }
-
+public interface CommentService {
     /**
      * Lists all comments for an image
@@ -63 +15 @@
      * @throws ProxyAuthenticationException
      */
-    public List<Comment> list(Integer imageId) throws IOException, ProxyAuthenticationException {
-        return CommentDao.getInstance(sessionManager).list(imageId);
-    }
+    public List<Comment> list(Integer imageId) throws IOException, ProxyAuthenticationException;
 
     /**
@@ -77 +27 @@
      */
     public boolean create(String content, Integer imageId, String auteur) throws IOException,
-            ProxyAuthenticationException {
-        Comment comment = new Comment();
-        comment.setContent(content);
-        comment.setImageId(imageId);
-        comment.setAuthor(auteur);
-        return CommentDao.getInstance(sessionManager).create(comment);
-    }
+            ProxyAuthenticationException;
 
 }