•  » Engine
  •  » jQuery by default on gallery side

#1 2012-03-26 00:41:11

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
14048

jQuery by default on gallery side

Hi coding team,

Piwigo already loads jQuery by default in the administration. Since Piwigo 2.0 if I remember correctly. Some very popular themes like Stripped or Simple are already loading jQuery. Some popular plugins are already loading jQuery on gallery side: RV Gmaps, Image Preview, Community (only on the upload page), autosize, GThumb, RV Thumbnail Scroller...

On [Subversion] r13683, because I wanted to make it simple, I also used jQuery on picture.php for a show/hide function. As it was also used on thumbnails.tpl (Ajax load of thumbnails) and also on Elegant theme, after a short discussion with P@t I have added the load of jQuery in the default header.tpl. But the question needs to be clearly discussed: should Piwigo load jQuery by default?

My opinion is that Piwigo 2.4 should load jQuery by default. So many websites (including piwigo.org) are using jQuery now that it has become nearly unavoidable. Modern web browsers are very fast with jQuery. I don't see why we keep the constraint of avoiding jQuery in Piwigo core.

Offline

 

#2 2012-03-26 00:48:17

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: jQuery by default on gallery side

agreed

Offline

 

#3 2012-03-26 10:52:56

rvelices
Former Piwigo Team
2005-12-29
1960

Re: jQuery by default on gallery side

then any particular reason to load it in the header instead of footer ?

Offline

 

#4 2012-03-26 20:06:49

flop25
Piwigo Team
2006-07-06
7038

Re: jQuery by default on gallery side

I've never understood why we didn't did this before
Yeah footer is much better than header


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#5 2012-03-26 23:32:54

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
14048

Re: jQuery by default on gallery side

rvelices wrote:

then any particular reason to load it in the header instead of footer ?

No specific reason, I just did it the same way we did on administration side. I changed that in [Subversion] r13763 (I also changed in Elegant)

Offline

 
  •  » Engine
  •  » jQuery by default on gallery side

Board footer

Powered by FluxBB

github linkedin newsletter Piwigo.org © 2002-2026 · Contact