Announcement

  •  » Engine
  •  » About empty lang values

#1 2014-04-05 23:28:51

flop25
Piwigo Team
2006-07-06
7037

About empty lang values

Hi team
I would like to change "if ( ($val=@$lang[$key]) == null)" in http://piwigo.org/dev/browser/trunk/inc … c.php#L981 , with  "if ( ($val=@$lang[$key]) === null)"  : this will NOT display the key of the lang if the value is empty, but still will display the key if the lang doesn't exist.
That change would allow further customization, by allowing to not display a text by setting an empty value; currently we have to set a ' ' value, so that space doesn't mean empty for systems and is then interpreted wrongly as not empty.
I don't think that change would change anything to the work flow of translations, but I'm asking if that would be problematic


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#2 2014-04-13 19:58:16

flop25
Piwigo Team
2006-07-06
7037

Re: About empty lang values

ok I will commit


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#3 2014-04-13 21:29:04

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13809

Re: About empty lang values

Let me take a look before April 18th please :-)

Offline

 

#4 2014-04-13 21:29:58

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13809

Re: About empty lang values

I see you have commited [Subversion] r28171, I will review it.

Offline

 
  •  » Engine
  •  » About empty lang values

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact