Piwigo.org

mjp · 2020-05-02 22:34:28

Hello,

First hello and thanks for Piwigo (this is my first post)

I have found one problem with new Metadata Open Graph extension: if description contains HTML tags the og:description property is not stripped of them, which causes problems, eg.:

Code:

<meta property="og:description" content="
13 May 2019
<!--complete-->
<div class="title">Poznań</div>
">

Piwigo version: 2.10.2
PHP version: 7.4
MySQL version: 5.5.5

ddtddt · 2020-05-03 08:16:05

Hi :-)

you've html in your description ?

ddtddt · 2020-05-03 08:26:36

Hi :-)

can you go
http://piwigo.org/svn/extensions/meta_og/

download main.inc.php and test

mjp · 2020-05-03 15:05:20

Thanks!

Yes, I use Extended Description plugin and some HTML tags to make my album descriptions look the way I want.

The updated version works better, but for some reason is not fully compatible with Extended Description. The [lang] tag works fine, but   do not work as expected. I tried to change in your code

Code:

  if (isset($pwg_loaded_plugins['ExtendedDescription'])){
    add_event_handler('AP_render_content', 'get_user_language_desc');

to

Code:

  if (isset($pwg_loaded_plugins['ExtendedDescription'])){
    add_event_handler('AP_render_content', 'get_extended_desc');

which shoudl be more generic, but it did not work neither. Any ideas?

ddtddt · 2020-05-03 15:32:47

Hi :-)

@mjp
for more / complete ... I must see but I don't know yet what I chose for the tag

ddtddt · 2020-05-08 01:49:15

Hi :-)

new bera relase

if plugin Extended descriptions is activate, on album page only short description or top description is use for og:description

localhost · 2020-06-07 11:40:58

Hi,

Just registered here to post about a pretty similar/related issue, so I guess it's appropriate to use this thread (sorry if it isn't).

I just installed version 0.7.beta7 of Metadata Open Graph, and I noticed that quotes are not escaped in the description, causing a pretty bad bug when the description does contain quotes (actually I'm surprised it doesn't totally break the page).

For instance, if you check the source code of this page https://gal.patheticcockroach.com/picture.php?/53/ , you'll notice (text truncated by me for clarity):

Code:

<meta property="og:description" content="The Sixth Sense version of the well-known "I see dumb people"">

I would expect something like:

Code:

<meta property="og:description" content="The Sixth Sense version of the well-known &quot;I see dumb people&quot;">

I suspect we're missing a htmlspecialchars() somewhere ?

ddtddt · 2020-06-07 17:40:28

Hi :-)

Thanks for your post I look when I look

Piwigo.org

Announcement

#1 2020-05-02 22:34:28

Metadata Open Graph description error

Code:

#2 2020-05-03 08:16:05

Re: Metadata Open Graph description error

#3 2020-05-03 08:26:36

Re: Metadata Open Graph description error

#4 2020-05-03 15:05:20

Re: Metadata Open Graph description error

Code:

Code:

#5 2020-05-03 15:32:47

Re: Metadata Open Graph description error

#6 2020-05-08 01:49:15

Re: Metadata Open Graph description error

#7 2020-06-07 11:40:58

Re: Metadata Open Graph description error

Code:

Code:

#8 2020-06-07 17:40:28

Re: Metadata Open Graph description error

Board footer