Announcement

#1 2021-02-01 20:00:16

manuvui
Member
2014-01-19
14

Tags edition

Hi

After update to 11.1 tags edition area in Admin don´t work. I have about 6000 keywords and I can't go to the next tag page. I can't see the orphans or edit or merge tags. Using safari the problem is bigger: none of the buttons work in tags area.

(Piwigo 11.2.0 Comprobar si hay una nueva versión disponible
Sistema operativo: Linux
PHP: 7.3.26 (Ver información) [2021-02-01 18:43:36]
MySQL: 5.7.33 [2021-02-01 18:43:36]
Librería gráfica: External ImageMagick 6.9.10-68

Offline

 

#2 2021-02-01 20:53:23

erAck
Only trying to help
2015-09-06
1995

Re: Tags edition

Confirmed. Both, the pagination arrows and the Display 100,200,500,1000 buttons don't work. Typing into the Filter box doesn't. Also, when selection mode is activated the All,None,Invert buttons don't do anything. Adding a keyword works, deleting does not. Editing works, but confirming spins forever until x hit but the change is accepted after. I also noticed that the left sidebar menu is spoiled (i.e. all submenus are opened at once).


Running Piwigo at https://erack.net/gallery/

Offline

 

#3 2021-02-02 11:56:25

stefano1
Member
2021-02-02
3

Re: Tags edition

I have the same problem.

Above all keywords something like:
"Gro\u00dffeldsiedlung","id":"1825","url_name":"location_aderklaaer_strasegrosfeldsiedlung","counter":1},{"name":"Location: Adolf Blamauer Gasse","id":"2525","url_name":"location_adolf_blamauer_gasse","counter":1}, (...)"
appears.The list is quite long.

Could it be because of the ß-symbol? for example first error is Großfeldsiedlung (Gro\u00dffeldsiedlung)

Also all submenus in the menu are visible. Display buttons and keyword search also dont work.
I can not edit any keywords, same problem than erAck.

I updated to Piwigo 11.2 automatically. Everything else works fine.

Offline

 

#4 2021-02-02 14:07:59

erAck
Only trying to help
2015-09-06
1995

Re: Tags edition

Fwiw, in the Firefox 78.7.0esr Web Console there are these errors:

Code:

Uncaught TypeError: dataTags.filter is not a function
    getNumberPages https://erack.net/gallery/_data/combined/1y747fn.js:151
    <anonymous> https://erack.net/gallery/_data/combined/1y747fn.js:162

Uncaught TypeError: AdminTools is undefined
    <anonymous> https://erack.net/gallery/admin.php?page=tags:3243

Firefox 84.0.2 reports even more locations of "dataTags.filter is not a function".


Running Piwigo at https://erack.net/gallery/

Offline

 

#5 2021-02-02 14:09:00

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13782

Re: Tags edition

I don't think it's related to the ß. I think you also have the problem in the group manager (if my guess is right...) I also have a problem on the tag manager withmy old Chrome.

Open file admin/themes/default/js/common.js, line 145, replace:

Code:

  //Arrays to reverse changes
  attrChanges = []; //Attribute changes : {object(s), attribute, value}
  classChanges = []; //Class changes : {object(s), state(add:true/remove:false), class}
  htmlChanges = []; //Html changes : {object(s), html}

by

Code:

  constructor() {
    //Arrays to reverse changes
    this.attrChanges = []; //Attribute changes : {object(s), attribute, value}
    this.classChanges = []; //Class changes : {object(s), state(add:true/remove:false), class}
    this.htmlChanges = []; //Html changes : {object(s), html}
  }

For the refresh in your web browser, and tell me if it works any better (finger crossed). At least for me it fixes an error on Chrome.

Offline

 

#6 2021-02-02 14:15:25

erAck
Only trying to help
2015-09-06
1995

Re: Tags edition


Running Piwigo at https://erack.net/gallery/

Offline

 

#7 2021-02-02 14:15:25

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13782

Re: Tags edition

If it doesn't work (because I don't have this problem with Firefox 78.7.0esr), then please do the following:

1) with plugin LocalFiles Editor, tab "local config", add:

Code:

<?php
$conf['template_combine_files'] = false;
?>

2) save and open the tag manager

3) open the web browser console (you can right click + "inspect" anywhere on the page) and tell me if you have any specific error described

Offline

 

#8 2021-02-02 14:17:20

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13782

Re: Tags edition

erAck wrote:

dataTags.filter is not a function"

Gonna check this!

Offline

 

#9 2021-02-02 14:24:37

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13782

Re: Tags edition

@erAck if you can set $conf['template_combine_files'] = false; it would help finding the "original" line in the JS files.

Offline

 

#10 2021-02-02 14:33:11

erAck
Only trying to help
2015-09-06
1995

Re: Tags edition

> Open file admin/themes/default/js/common.js, line 145, replace:

Still broken.

> $conf['template_combine_files'] = false;

The same, but with locations in admin/themes/default/js/tags.js

Code:

Uncaught TypeError: dataTags.filter is not a function
    getNumberPages https://erack.net/gallery/admin/themes/default/js/tags.js?v11.2.0:925
    <anonymous> https://erack.net/gallery/admin/themes/default/js/tags.js?v11.2.0:1007
tags.js:925:26

Uncaught TypeError: dataTags.filter is not a function
    getNumberPages https://erack.net/gallery/admin/themes/default/js/tags.js?v11.2.0:925
    movePage https://erack.net/gallery/admin/themes/default/js/tags.js?v11.2.0:931
    <anonymous> https://erack.net/gallery/admin/themes/default/js/tags.js?v11.2.0:1000
    jQuery 2
        dispatch
        handle
tags.js:925:26

Running Piwigo at https://erack.net/gallery/

Offline

 

#11 2021-02-02 15:00:52

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13782

Re: Tags edition

OK, problem reproduced with a tag including a quote. Searching a fix.

Offline

 

#12 2021-02-02 15:22:13

erAck
Only trying to help
2015-09-06
1995

Re: Tags edition

Indeed, I have such as well with an embedded apostrophe.


Running Piwigo at https://erack.net/gallery/

Offline

 

#13 2021-02-02 16:22:52

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13782

Re: Tags edition

I hope this will work for you as well [Github] Piwigo commit c88daa88

Can you check? If you're not familiar with Git (which is OK), you can simply replace the 3 files :

* admin/tags.php
* admin/themes/default/js/tags.js
* admin/themes/default/template/tags.tpl

Offline

 

#14 2021-02-02 18:40:54

stefano1
Member
2021-02-02
3

Re: Tags edition

plg wrote:

I hope this will work for you as well [Github] Piwigo commit c88daa88

Can you check? If you're not familiar with Git (which is OK), you can simply replace the 3 files :

* admin/tags.php
* admin/themes/default/js/tags.js
* admin/themes/default/template/tags.tpl

I replaced the 3 files and it´s working now. Thank you very much!
Will there be problems with those files if i´m updating to the next Update release?

Only the header menu (tools, logout etc.) takes longer to be displayed correctly (on load the menu shows as a list menu first outside of the header) but this is no problem.

Edit: Filter function is still not working

Last edited by stefano1 (2021-02-02 18:46:40)

Offline

 

#15 2021-02-02 18:47:01

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13782

Re: Tags edition

stefano1 wrote:

I replaced the 3 files and it´s working now. Thank you very much!

Very good news :-)

stefano1 wrote:

Will there be problems with those files if i´m updating to the next Update release?

No, because I get confirmation these changes fix the problem, then I will include the changes in 11.3.0.

stefano1 wrote:

Only the header menu (tools, logout etc.) takes longer to be displayed correctly (on load the menu shows as a list menu first outside of the header) but this is no problem.

Do you have plugin AdminTools active? What happens on this page if you deactivate this plugin?

Offline

 

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact