🌍
English
Announcement
- [2024-04-01] Piwigo in Hobbit runes
- [2024-03-01] Piwigo 14.3.0
- [2024-01-30] Piwigo 14.2.0
- [2023-12-29] Piwigo 14.1.0
- [2023-12-12] Piwigo 14
#1 2023-05-09 09:24:35
- jorgep
- Member
- 2013-02-03
- 3
Custom Contact Link with Contact Form
Hello/Hi/Greetings,
Trying to use Custom Contact Link with Contact Form
Ran in to a probem with PHP v8.1
Two issies:
Warning: Undefined array key "is_logged" in
/.../_data/templates_c/177dylx^fbf5eb7f66b44a8c1a7e984b9f7ccb519682d587_0.file.contact_form.tpl.php on line 86
<br /><b>Warning</b>: Undefined array key
/.../_data/templates_c/177dylx^fbf5eb7f66b44a8c1a7e984b9f7ccb519682d587_0.file.contact_form.tpl.php on line 92
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /.../_data/templates_c/177dylx^fbf5eb7f66b44a8c1a7e984b9f7ccb519682d587_0.file.contact_form.tpl.php on line 92
">
=====================
Piwigo 13.6.0 Check for upgrade
Installed on 8 May 2023, 6 hours ago
Operating system: Linux
PHP: 8.1.0 (Show info) [2023-05-09 00:20:27]
MySQL: 8.0.30-0ubuntu0.20.04.2 [2023-05-09 00:20:27]
Graphics Library: ImageMagick 6.9.7-4
Cache size N/A never calculated Refresh
Activated plugin list5
Contact Form
Custom Contact Link
LocalFiles Editor
Read Metadata
Virtualize
Piwigo URL: http://localhost
Offline
#2 2023-05-09 09:35:19
- erAck
- Only trying to help
- 2015-09-06
- 2020
Re: Custom Contact Link with Contact Form
1. do not run Piwigo under PHP 8.1, use 8.0 instead
2. on production sites either suppress notices, warnings and deprecated messages, or better log all messages to file,
see [Forum, post 183126 by erAck in topic 31852] Menubar tags issue after 12.2.0 upgrade.
Running Piwigo at https://erack.net/gallery/
Offline
#3 2023-05-09 16:44:15
- jorgep
- Member
- 2013-02-03
- 3
Re: Custom Contact Link with Contact Form
THANK YOU!
This pointed me in the right direction and it hid the warnings..
Offline
#4 2023-09-06 17:33:25
- mic_p
- Member
- 2023-09-06
- 4
Re: Custom Contact Link with Contact Form
While this thread is quite old, some words I have to write.
1.
Telling people NOT to use php 8.1 or higher, is quite dangerous late 2023.
Reason: see https://www.php.net/supported-versions.php and you may notice, that 8.0.x is not longer supported!
The more, 8.2.x is faster and more secure.
2.
Suppressing notices, warnings etc. does not help further.
Such messages are only "suppressed", but not solved.
3.
Maybe this PR is for some of you: https://github.com/Piwigo/ContactForm/pull/14
Beside this all, it's quite a shame that this plugin is not "uptodate".
Checking the code, some options are not used (e.g. CC) but still mentioned inside the code ..
Offline
#5 2023-09-07 11:21:02
- erAck
- Only trying to help
- 2015-09-06
- 2020
Re: Custom Contact Link with Contact Form
1. Piwigo 13.8 and main plugins work fine with PHP 8.1. Some plugins may not be ready for it. That's a never ending story and sooner or later people will have to say good bye to some unmaintained plugins.
2. Suppressing display of notices, deprecates and warnings or rather logging them to file in a production environment is safe.
3. I wish Piwigo devs would pay more attention to pull requests.
Running Piwigo at https://erack.net/gallery/
Offline
#6 2023-09-07 13:46:59
- mic_p
- Member
- 2023-09-06
- 4
Re: Custom Contact Link with Contact Form
erAck wrote:
1. Piwigo 13.8 and main plugins work fine with PHP 8.1. Some plugins may not be ready for it. That's a never ending story and sooner or later people will have to say good bye to some unmaintained plugins.
2. Suppressing display of notices, deprecates and warnings or rather logging them to file in a production environment is safe.
3. I wish Piwigo devs would pay more attention to pull requests.
Currently "using" Piwigo 14.0.0beta_1 and some plugins.
While the latest version of Piwigo has only minor notices when using php 8.2.x, not one of the plugins can be used without warnings, notices and errors with php 8.2.x
Agree with you (1. - 3.), it's quite a shame these days that none of the plugins are maintained properly.
Had to adopt and rework each of them - whell, doing such since 1 week ..
Made because of this some PRs at GH - some are already accepted (also in the core for latest beta2).
Now I would say, that it's up to the plugin devs to update their extensions ..
Offline