#1 2024-10-28 15:07:07

danfbach
Member
2024-10-28
5

Question about github PR activity

Hello,

I have submitted a few issues and pull requests on the official github repo for piwigo nearly a year ago.
There has been no activity on them, and reviewing the repository, there are many unacknowledged issues and pull requests going back many years. I am curious if there is a better place to bring attention to issues and pull requests? If not, some official interaction or acknowledgement (i.e. tagging it, or commented "Thanks for the PR we will review"), just to know someone is actually there monitoring the repo, would be nice.

Thanks,
Dan

Offline

 

#2 2024-10-28 16:19:51

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13934

Re: Question about github PR activity

Hi Dan,

Links to your pull-requests please :-)

Offline

 

#3 2024-10-28 16:22:23

danfbach
Member
2024-10-28
5

Re: Question about github PR activity

Hey plg,

Thanks for the quick reply.

https://github.com/Piwigo/Piwigo/pull/2068

Again, as i said, it's a minor feature, but it was asked for prior to my issue post too, and simple enough to implement i so sent a PR.

Thanks!

Offline

 

#4 2024-10-28 16:34:31

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13934

Re: Question about github PR activity

In my opinion, this is a bad idea. We will review it tomorrow in our design meeting and I'll make some feedbacks here.

Offline

 

#5 2024-10-28 16:43:14

danfbach
Member
2024-10-28
5

Re: Question about github PR activity

Thanks.

The only real reason this was requested from my users is that the size selector button is not obvious, so i was very frequently asked how to get a different size for download.
Certainly open to a more elegant solution if one comes up in your meeting.

Offline

 

#6 2024-10-28 16:55:24

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13934

Re: Question about github PR activity

danfbach wrote:

[...] get a different size for download [...]

and that's the important info I needed ;-)

Did you try [extension by plg] Download by Size ? Maybe [extension by plg] Custom Download Link should include several buttons for several sizes.

Offline

 

#7 2024-10-28 17:13:19

danfbach
Member
2024-10-28
5

Re: Question about github PR activity

I do have the download by size already actually - unfortunately still isn't obvious enough for some users. haha can't make them all happy. I think a lot of them are doing a "Right Click -> Save As" operation on the image they're viewing.

We use our piwigo installation primarily to supply assets to vendors, so they like to be able to pick the right size for their needs when possible.

I was not aware of the custom download button link plugin, and I could see this helping to mitigate with some minor changes.

I would be happy with any solution that doesn't require me to patch my site with custom changes each time i update. :)

Offline

 

#8 2024-10-29 15:47:46

hannah
Piwigo Team
2019-04-24
69

Re: Question about github PR activity

Hi danfbach,

After some discussion with our designer we think we have found another way for you to get the result expected and avoiding adding these changes to the core of Piwigo. We think it would be better to update the plugin "custom download link".

In the plugin it means adding settings to either have just one download link displayed link it currently is, or to have multiple download links displayed, one button for each size. The position of these download buttons can be configurable at the top or bottom of the image, or with the picture information (similar to download format buttons).

Here are some examples of what we know we can do to achieve something similar for the "custom download link" plugin :

https://sandbox.piwigo.com/_datas/4/y/1/4y1zzhnrnw/i/uploads/4/y/1/4y1zzhnrnw//2024/10/29/20241029153600-a71aa9cf-sm.png
This is how the current "custom download link" displays this button below the image

https://sandbox.piwigo.com/_datas/4/y/1/4y1zzhnrnw/i/uploads/4/y/1/4y1zzhnrnw//2024/10/29/20241029153601-2801abff-sm.png
This is how the current "download format buttons" displays

https://sandbox.piwigo.com/_datas/4/y/1/4y1zzhnrnw/i/uploads/4/y/1/4y1zzhnrnw//2024/10/29/20241029153600-29bdc5d6-sm.png
This is an example of the download buttons above the image

Offline

 

#9 2024-10-29 19:09:11

danfbach
Member
2024-10-28
5

Re: Question about github PR activity

Those changes to the plugin seem like they would offer the functionality I'm looking for.

In truth, I'm not really sure what i'm looking at in your screenshots, but assuming that your last image is an example of what it might look like, then i would say that it would work.

Offline

 

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2025 · Contact