•  » Extensions
  •  » User Tags extension breaks popup help in other pages?

#1 2025-02-08 16:41:28

markthecoder
Member
2024-12-28
4

User Tags extension breaks popup help in other pages?

Hello,

Sorry for the new topic, but my late-Dec post got no response and I can't find any repository for the User Tags extension so I'm resorting to a second post in a new topic.

Has anyone noticed after the User Tags extension is activated none of the popup help text displays on any page other than the User Tags admin page? They're just blank. Or is it just me?
I think the problem is function get_admin_help in plugins/user_tags/src/userTags/Config.php:

Code:

public static function get_admin_help($help_content, $page) {
    return load_language('help/' . $page . '.html',
                         T4U_PLUGIN_ROOT . '/',
                         ['return' => true]
                         );
  }

When UT is activated this function is invoked via trigger_change in popuphelp.php for any popup help, but since it doesn't check the $page argument to see what the current page is, it always blows away $help_content with its own (failed) load_language lookup.
If I replace it with this code things work better (other than the fact that 'readme' is a very generic name bound to conflict with some other extension in the future):

Code:

 public static function get_admin_help($help_content, $page) {
    if ( $page == 'readme' ){
       $help_content = load_language('help/' . $page . '.html',
                         T4U_PLUGIN_ROOT . '/',
                         ['return' => true]
       );
    }
    return $help_content;
  }

environment:

    Piwigo 15.3.0 Check for upgrade
    Installed on 4 July 2024, 7 months 3 days ago
    Operating system: Linux
    PHP: 8.3.6 (Show info) [2025-02-08 15:37:51]
    MySQL: 10.11.8-MariaDB-0ubuntu0.24.04.1 [2025-02-08 10:37:51]
    Graphics Library: ImageMagick ImageMagick 6.9.12-98
    Cache size 23.65 Mo   calculated 5 months ago Refresh

Offline

 

#2 2025-02-09 07:56:35

nicolas
Former Piwigo Team
2004-12-30
1235

Re: User Tags extension breaks popup help in other pages?

Hi.
My bad. I saw your complain but I forgot.
I just publish a new release that should fix the issue you reported. Thanks for your help.

Offline

 

#3 2025-02-09 15:30:34

markthecoder
Member
2024-12-28
4

Re: User Tags extension breaks popup help in other pages?

nicolas wrote:

I saw your complain but I forgot.

Serves me right for posting during the holidays.
Have a good day!

Offline

 
  •  » Extensions
  •  » User Tags extension breaks popup help in other pages?

Board footer

Powered by FluxBB