Hello,

Exactly the same problem after upgrade to 15.4.0

Alexandr

I can't reproduce for now and we have another equivalent report (in the French forum).

Can you use your web browser console to see if you have any specific response for the call to ws.php ?

plg wrote:

I can't reproduce for now and we have another equivalent report (in the French forum).

Can you use your web browser console to see if you have any specific response for the call to ws.php ?

https://sandbox.piwigo.com/i?/uploads/4 … ead-la.png

When I edit some existing photos in a single mode, everything is ok.
From web browser console:
{"stat":"ok","result":null}

Maybe there is an issue only while editing just uploaded photos? I will try.

I have been able to reproduce the bug. I need you to try this solution. Open file include/functions.inc.php, about line 2881, just before function pwg_unique_exec_ends, insert this new function:

function pwg_unique_exec_is_running($token_name)
{
  $query = '
SELECT
    COUNT(*)
  FROM '.CONFIG_TABLE.'
  WHERE param = "'.$token_name.'_running"
;';
  list($counter) = pwg_db_fetch_row(pwg_query($query));

  return $counter > 0;
}

then in include/functions_user.inc.php, line 445, before :

           else
           {
            $logger->info($logger_msg.'user_cache not ready yet, after waiting ....

insert

          elseif (!pwg_unique_exec_is_running($cache_generation_token_name))
          {
            $logger->info($logger_msg.'user_cache rebuilt but has been reset since, give it another try, after waiting '.get_elapsed_time($user_cache_waiting_start_time, get_moment()));
            return getuserdata($user_id, true);
          }

I have other solutions (and I will certainly combine several to get the optimal solution) but I would like you to test only this one for now.

plg wrote:

I have been able to reproduce the bug. I need you to try this solution. Open file include/functions.inc.php, about line 2881, just before function pwg_unique_exec_ends, insert this new function:

You say "just before function pwg_unique_exec_ends" but you don't mean to put the new function block inside the pwg_unique_exec_ends, right? It should be its own function, like this?

function pwg_unique_exec_ends($token_name)
{
  conf_delete_param($token_name.'_running');
}

function pwg_unique_exec_is_running($token_name)
{
  $query = '
SELECT
    COUNT(*)
  FROM '.CONFIG_TABLE.'
  WHERE param = "'.$token_name.'_running"
;';
  list($counter) = pwg_db_fetch_row(pwg_query($query));

  return $counter > 0;
}

?>

Because after making the change, I am getting the "an error has occurred" on every item in single mode immediately, so I clearly messed something up.

windracer wrote:

You say "just before function pwg_unique_exec_ends" but you don't mean to put the new function block inside the pwg_unique_exec_ends, right? It should be its own function, like this?

Yes of course, you don't write a function inside a function (actually you can, but don't)

For me it works, it's just that it needs to rebuild user_cache as many times as image to save. For example, if my user_cache takes 5 seconds to rebuilt, one image will take 5s+epsilon, another image will take 2x5s+epsilon and the third photo will take 3x5s+epsilon. No guarantee that the first image in the list will finish first. At this point, the order is random. The total time to perform will be the slowest image, ie 15seconds+epsilon.

We're working on:

* do not send calls to pwg.images.setInfo in parallel, but one by one. First photo would take 5s+epsilon. The total time would be 3x(5s+epsilon). Not better in time, but avoid deadlock on mutual exclusion.

* avoiding to rebuild user_cache. The total time will be 3xepsilon. Much better.

* avoiding to reset user_cache when not necessary. Nice but a bit dangerous.

I figured out my issue (I had some other problems in my test site) and that second code recommendation (in user.inc.php) seems to fix the problem for me.