Piwigo.org

plg · 2005-08-28 15:15:01

chrisaga, if this was possible, I'd like not to have to give thumbnail dimensions at each category.php reload. If thumbnails dimensions are cached in the database (in fact, it's required because of remote sites), I have to modify admin/include/functions_metadata.php:update_metadata. I'm fond of this solution, but it's an easy modification in PHP code and data model.

I don't understand why you need max_displayed_thumbnail_height and max_displayed_thumbnail_width ? These configuration parameters are useful only for calculation of thumbnail diplayed dimensions, and in your template, you don't use thumbnail dimensions.

I've seen your HTML/CSS code on your test page, and I give my opinion about #manual2 : if HTML is simple, CSS code is too much complicated, full of hacks. I don't think having hacks for IE, other for Gecko or Opera is the right solution.

If the choice is between :

#1 : simple CSS, requiring PHP code to give thumbnail dimensions (and number of pixels for "top")
#2 : complex CSS not requiring thumbnail dimensions

I prefer #1

chrisaga wrote:
Mabe there are some solutions !!! Getting rid of dealing with sumbnails dimensions is worth searching a little bit, don't you think so ? But i need some help there. Any idea ?

Not so sure avoiding dealing with thumbnail dimensions is worth having a more complex CSS code.

Let's consider the following situation : I have 4 thumbnails to display (original width*height are given). max_displayed_thumbnail_height=100, max_displayed_thumbnail_width=100.

- tn1 (100*75) : displayed_width=100, displayed_height=75, top=13
- tn2 (75*100) : displayed_width=75, displayed_height=100, top=0
- tn3 (150*110) : displayed_width=100, displayed_height=74, top=13
- tn4 (42*50) : displayed_width=42, displayed_height=50, top=25

tn3 is too big, tn4 is too smal.

Question : should tn4 displayed height be 100 (and displayed width be 84) ? (I think no, only display resize for smaller no bigger)

plg · 2005-08-28 15:16:40

volcom wrote:
I just want to know : what's about underlining in menus & thumbnails ? I saw you said you disabled it but ?

underlining will be kept, but easy to disable in CSS :-)

chrisaga · 2005-08-28 16:06:01

z0rglub wrote:
chrisaga, if this was possible, I'd like not to have to give thumbnail dimensions at each category.php reload.

With #manual2 style design, you never have to give thumnails dimensions

z0rglub wrote:
I don't understand why you need max_displayed_thumbnail_height and max_displayed_thumbnail_width ? These configuration parameters are useful only for calculation of thumbnail diplayed dimensions, and in your template, you don't use thumbnail dimensions.

My idea was to not put the size in the template css to avoid the need to change it in each template when the administrator first sets his gallery (he might want different thumbnails size than us).
My first solution was to ask the php to give it in the <head>, but a simpler solution is to have a small template-independant css which could handle that. So don't worry.

z0rglub wrote:
I've seen your HTML/CSS code on your test page, and I give my opinion about #manual2 : if HTML is simple, CSS code is too much complicated, full of hacks. I don't think having hacks for IE, other for Gecko or Opera is the right solution.

If the choice is between :

#1 : simple CSS, requiring PHP code to give thumbnail dimensions (and number of pixels for "top")
#2 : complex CSS not requiring thumbnail dimensions

The css don't seems so complicated to me, and it cant be made a litle simpler.
First I think some redundant rules can be avoided (like margin:0px, ...).
Then I clearly duplicated the rules between the Geko/Opera set and the IE for the working phase. Lots of are common and can be merged in a syntax understandable by both families.
Finaly, I only used 2 tricks, not even real hacks (relying on parsing bugs, like strange comments, ...)

I prefer #2 because it's drawbacks can be minimized and it's less php and database computing on the server (important for mutualized hosting)

----Edited----
What if I could reduce the css code almost by 2 and have no specific rules anymore for Geko and Opera, Just IE ?
Take a look at #manual3 :D
--------------

z0rglub wrote:
Question : should tn4 displayed height be 100 (and displayed width be 84) ? (I think no, only display resize for smaller no bigger)

In my first proposition (remember the ASCII art), I told about clipping of too big thumbnails, not resizing. So my solution do not resize. It can do that but I think it's not a good idead because if clipping is considered not good enough for displaying thumbnails, neither sould be an image zoomed by the browser. If quality matters that much, we should provide right sized thumbnails for every picture.

Last edited by chrisaga (2005-08-28 17:07:14)

chrisaga · 2005-08-28 16:07:54

z0rglub wrote:
volcom wrote:
I just want to know : what's about underlining in menus & thumbnails ? I saw you said you disabled it but ?
underlining will be kept, but easy to disable in CSS :-)

I'm not very fond of that, and think that won't be in my personal templates, unless yoDan explains how to get the dotted underlying works with Geko.

plg · 2005-08-29 01:02:34

My current problem is the following : yoDan has gone to vacations and I thought we had agreed on gallery #2. I have not the same CSS level as you chrisaga and I can't argue :-/ Wouldn't it be wise to commit gallery #2 and work on what remains on the template for branch 1.5 ? After branch 1.5, we'll discuss on improving thumbnails display, and I think we'll have to set constraints (width and height, no text) to simplify this page. In my opinion (in my level of understanding in fact), HTML/CSS code is getting too much complicated.

Branch 1.5 is coming in less than 2 weeks and I still have many things to do, and template system has already been improved a lot. Keep some improvement for branch 1.6 (or release 1.5.1).

chrisaga · 2005-08-29 08:09:49

z0rglub wrote:
My current problem is the following : yoDan has gone to vacations and I thought we had agreed on gallery #2. I have not the same CSS level as you chrisaga and I can't argue :-/ Wouldn't it be wise to commit gallery #2 and work on what remains on the template for branch 1.5 ? After branch 1.5, we'll discuss on improving thumbnails display, and I think we'll have to set constraints (width and height, no text) to simplify this page. In my opinion (in my level of understanding in fact), HTML/CSS code is getting too much complicated.

We are still in galery 2. The one thing I changed is to avoid the need of giving thumbnails dimensions. To do thad I just added a SPAN to wrap the image and added 2 or 3 rules because IE doesn't work like Geko and Opera. If you agree, I could commit it in the CVS tonight.
BTW I'm not such a great expert and I can still understand where the HTML/CSS goes.

z0rglub wrote:
Branch 1.5 is coming in less than 2 weeks and I still have many things to do, and template system has already been improved a lot. Keep some improvement for branch 1.6 (or release 1.5.1).

I think the next improvement will be a little reordering of the rules and the doc to explain how the template can be customized to make a new one. But it'll be in the 1.5.1 because I'm leaving on saturday for 3 weeks.

plg · 2005-08-29 19:38:18

chrisaga wrote:
We are still in galery 2. The one thing I changed is to avoid the need of giving thumbnails dimensions. [...] If you agree, I could commit it in the CVS tonight.

OK, commit :-) I don't even remember the difference between current situation and the one you're commiting tonight, I'll have the surprise :-)

chrisaga wrote:
BTW I'm not such a great expert and I can still understand where the HTML/CSS goes.

Not an expert, yes maybe. Let's say I'm a pure newbie and you have already heard about CSS... :-) (and yoDan has read the introduction of a CSS book in a bookstore).

z0rglub wrote:
I think the next improvement will be a little reordering of the rules and the doc to explain how the template can be customized to make a new one. But it'll be in the 1.5.1 because I'm leaving on saturday for 3 weeks.

If possible, not in 1.5.1 but in BSF. Modifying templates in minor releases should be done only for blocking bugs (IMO).

plg · 2005-08-29 20:23:56

(it rocks, thanks for committing, what a great improvement since branch 1.4 !)

chrisaga · 2005-08-29 22:11:20

z0rglub wrote:
(it rocks, thanks for committing, what a great improvement since branch 1.4 !)

Thanks, I kept our "Girafe" work with the comments in the css, so we still can improve it quite easily.

z0rglub wrote:
chrisaga (not Z0rglub) wrote:
I think the next improvement will be a little reordering of the rules and the doc to explain how the template can be customized to make a new one. But it'll be in the 1.5.1 because I'm leaving on saturday for 3 weeks.
If possible, not in 1.5.1 but in BSF. Modifying templates in minor releases should be done only for blocking bugs (IMO).

Right I'm not yet very easy with the version numbering.

BTW, I think there is an elegant solution for Category names containing quotes (') in 1.4 Could you keep it in BSF ?

Unless you have a problem with the template, this will be my last contribution untill I come back on 25th of september because I must pack for my 3 weeks of trekking in Ecuador ! I'll be connected till Wednesday, just in case. Have an easy 1.5 release !

Last edited by chrisaga (2005-08-29 22:14:50)

plg · 2005-08-29 22:27:16

I have a problem with your last commit.

- before commit, I have

- and after commit, I have

no top alignement (which is useless in my opinion) and too much space between lines.

chrisaga wrote:
BTW, I think there is an elegant solution for Category names containing quotes (') in 1.4 Could you keep it in BSF ?

Are you talking about this bug? The correction has to be reported on BSF before creating 1.5 branch.

chrisaga · 2005-08-30 07:51:48

z0rglub wrote:
I have a problem with your last commit.

[ ... ]

no top alignement (which is useless in my opinion) and too much space between lines.

It was not the alignment of images in the grey frame, but the alignment of the grey frames themselves when the legend wraps over several lines. Obviously you can"t see it since you have deactivated the legend.
Anyway, I removed it.

z0rglub wrote:
chrisaga wrote:
BTW, I think there is an elegant solution for Category names containing quotes (') in 1.4 Could you keep it in BSF ?
Are you talking about this bug? The correction has to be reported on BSF before creating 1.5 branch.

Yes it's this bug

plg · 2005-09-03 23:44:01

The template was made the official default template :-) It's available in build BSF_200509032321. I renamed it to "yoga" (yoDan and chrisaga). Now, let's wait testers first impressions :-)

volcom · 2005-09-04 10:53:06

cool ! I'm going to test it :)

plg · 2005-09-05 22:27:36

There is a bug for you : Image Nouveau

droopy191 · 2005-09-09 22:20:26

Hello
I installed the pwg BSF_200509032321 and wrote down my suggestions/notes.
Browsers used:
Mozilla Firefox 1.0.6 FR
IE 6 SP2

- I confirm the bug declared by flipflip with ie6 on !new image

- logon screen: bug ??
/pwg/identification.php return
Notice: Undefined index: mail_webmaster in e:\www\pwg\identification.php on line 74

- main screen with or without pictures added
the menu is very large (too large ??)
see http://droopy191.free.fr/public/left_menu.jpg
probably just my personal feeling?

the logon menu at bottom is not aligned

- visual issue on the picture page
the vertical space between the main picture and next/prev pictures is different between IE6 /FF
http://droopy191.free.fr/public/next-prev_FF.jpg
http://droopy191.free.fr/public/next-prev_IE6.jpg
As usually, I think that FF do the right thing but the little space is prettier ( also a personal remark)

Html errors
- on the main page
problem of categories menu (ul li )

- on the search page
<a> badly closed
use of # in id and name not allowed
use of non html strict tag as valign

- on all page " - Warning: <a> escaping malformed URI reference " only for Tidy validator
in the subject of contact webmaster link -> no spaces allowed in <a> tag

See my old post http://forum.phpwebgallery.net/viewtopic.php?id=4326

I hope that can help.

Thanks all for this great new template

Piwigo.org

Announcement

#61 2005-08-28 15:15:01

Re: Improved HTML and layout

chrisaga wrote:

#62 2005-08-28 15:16:40

Re: Improved HTML and layout

volcom wrote:

#63 2005-08-28 16:06:01

Re: Improved HTML and layout

z0rglub wrote:

z0rglub wrote:

z0rglub wrote:

z0rglub wrote:

#64 2005-08-28 16:07:54

Re: Improved HTML and layout

z0rglub wrote:

volcom wrote:

#65 2005-08-29 01:02:34

Re: Improved HTML and layout

#66 2005-08-29 08:09:49

Re: Improved HTML and layout

z0rglub wrote:

z0rglub wrote:

#67 2005-08-29 19:38:18

Re: Improved HTML and layout

chrisaga wrote:

chrisaga wrote:

z0rglub wrote:

#68 2005-08-29 20:23:56

Re: Improved HTML and layout

#69 2005-08-29 22:11:20

Re: Improved HTML and layout

z0rglub wrote:

z0rglub wrote:

chrisaga (not Z0rglub) wrote:

#70 2005-08-29 22:27:16

Re: Improved HTML and layout

chrisaga wrote:

#71 2005-08-30 07:51:48

Re: Improved HTML and layout

z0rglub wrote:

z0rglub wrote:

chrisaga wrote:

#72 2005-09-03 23:44:01

Re: Improved HTML and layout

#73 2005-09-04 10:53:06

Re: Improved HTML and layout

#74 2005-09-05 22:27:36

Re: Improved HTML and layout

#75 2005-09-09 22:20:26

Re: Improved HTML and layout

Board footer