Piwigo.org

Eric · 2009-09-19 01:54:18

plg wrote:
Hi Piwigo team,

It's time for a new release, don't you think? What we currently have:

* plugins with multiple language description
* avoid compatibility warnings with PHP 5.3
* automatic connection at the end of install
* hide categories when no photo inside
* italian/german/spanish users can subscribe to Piwigo newsletter in their own language
* fix Internet Explorer 8 (IE8) display bugs
(...)

This one seems to not be fixed at this time on 2.0.4 :

Deprecated: Function set_magic_quotes_runtime() is deprecated in E:\www\Infernoweb\phpwebgallery\include\common.inc.php on line 31

VDigital · 2009-09-28 22:38:03

Eric wrote:
VDigital wrote:
And at least, Eric, offer a $conf to switch to a double password input in admin.
I'm OK with that. But do not delay the release of the next release so far. This is not a major feature and I don't have much free time right now to do that quickly.

Well done.

Revision: 3935
Author: Eric
Date: 21:22:59, lundi 28 septembre 2009
Message:
[Bug 1041] Switchable double/single password input with text or password type in admin using new $conf
----
Modified : /trunk/admin/template/goto/user_list.tpl
Modified : /trunk/admin/user_list.php
Modified : /trunk/include/config_default.inc.php

[Bugtracker] ticket 1041

Eric · 2009-09-28 22:57:28

Thx ! But I'm unable to merge from trunk to branch 2.0. I've many conflicts with files.

I'll retry tomorrow.

VDigital · 2009-09-29 07:46:15

Logic! That is not the normal way to proceed. Maybe the best is to wait for 2.1.0

P@t · 2009-10-09 15:11:43

I've just take a look to this functionality...

I'm ok to have a double password type in admin...
For me, $conf['double_password_type_in_admin'] should be true by default.

But... if $conf['double_password_type_in_admin'] is true, why password and email address are mandatory???
I'm agree with vincent:

VDigital wrote:
2 - It was the only way to create a second guest profile with no password. Now I can't. Password is mandatory.

Last edited by VDigital (2009-10-09 19:38:07)

Eric · 2009-10-09 23:48:28

P@t wrote:
But... if $conf['double_password_type_in_admin'] is true, why password and email address are mandatory???
I'm agree with vincent:
VDigital wrote:
2 - It was the only way to create a second guest profile with no password. Now I can't. Password is mandatory.

If $conf['double_password_type_in_admin'] is true then password have to be mandatory. Otherwise what would be the double password entry?

However, I can understand the request for the case where $conf['double_password_type_in_admin'] is false. In this case, password should not be mandatory.

About email address, coding like that should it be ok ?

Code:

if $conf['double_password_type_in_admin'] is true
{
  email address mandatory = false
}

VDigital · 2009-10-10 09:31:00

May I revise a bit my advice.

I have no problem with $conf['double_password_type_in_admin'] as true or false.
But P@t's remark invited me to change my advice.

Let us see.

If on the Admin page, we could switch from double-silent password to single-visible and vice versa, it would be better.
Then we can accept that non mandatory password will be only on single and visible input.

So, $conf['double_password_type_in_admin'] is a starting default mode only.

Eric · 2009-10-10 14:29:07

Adding a checkbox on admin page to control if $conf['double_password_type_in_admin'] should be true or false ? I'm ok with that.

By default the value will be "true" : Double hidden password type with password and email mandatory.
If checked to "false" by admin : Single clear password type with password and email not mandatory.

If this is correct, i'll fill in the bugtracker for a futur fix. Ok ?

VDigital · 2009-10-10 14:49:38

Perfect for me.

P@t, does this last proposal suit you?

P@t · 2009-10-10 18:15:34

For user registration, password and email are not mandatory... why they should be mandatory on admin side???
I really don't understand... admins know what they do...

But i'm ok to add a checkbox on user list page.

Last edited by P@t (2009-10-10 18:15:56)

Eric · 2009-10-10 22:06:27

P@t wrote:
For user registration, password and email are not mandatory... why they should be mandatory on admin side???

???
Of course for user registration email are mandatory ! But not password, you're right. And this is also debatable.
Personally, I can't stand that users don't type a password. It's nonsense to me... But that another subject.

P@t wrote:
I really don't understand... admins know what they do...

But i'm ok to add a checkbox on user list page.

Ok : [Bugtracker] ticket 1188

VDigital · 2009-10-10 22:30:36

Eric wrote:
Of course for user registration email are mandatory !

False! It's your choice.

Admin > Configuration > General

Main tab
Mail address is obligatory for all users

Eric · 2009-10-10 22:51:44

Oops ! Sorry, you're right. It's a possible choice for admins...

I'm so used to validate this option by default that I feel it's a logical enabled feature in core. But that's strange for me too. I can't stand visitors registered without giving a valid email address. That's very usefull for users to recover a forgotten password and for admins to checkout the "flooders".

So, I'ld revise my opinion about that now. If password and / or email are not mandatory for users, there is actually no reason for it to be so for the admins. Even if the overall system does not really correspond to my vision...

P@t · 2009-10-11 01:30:08

Maybe I have an idea...
The problem is that we don't want clear password input because browser can save it...
But, with jQuery, it' really easy to transform a text input into password input when you validate a new user.

Edit: I tried, and it's work ;-)

jQuery().ready( function() {
jQuery("form[name='add_user']").submit( function () {
jQuery("input[name='password']").attr("type", "password");
});
});

Admin can see password text... but when you hit vadilate button, input text become password input for browser...

Last edited by P@t (2009-10-11 01:43:02)

Eric · 2009-10-11 02:55:02

Well done, P@t !

Surely this is the solution :

Exit double password type in admin
Exit password / email mandatory in admin
Welcome to jQuery to hide password on submit

And this can be set too on users registration page. So i would be easier for Grand-Ma, who has some problems using keyboard to set correctly the two passwords fields, to register on family's gallery. ;-)

+1 for jQuery

Piwigo.org

Announcement

#16 2009-09-19 01:54:18

Re: release 2.0.4 under preparation

plg wrote:

#17 2009-09-28 22:38:03

Re: release 2.0.4 under preparation

Eric wrote:

VDigital wrote:

#18 2009-09-28 22:57:28

Re: release 2.0.4 under preparation

#19 2009-09-29 07:46:15

Re: release 2.0.4 under preparation

#20 2009-10-09 15:11:43

Re: release 2.0.4 under preparation

VDigital wrote:

#21 2009-10-09 23:48:28

Re: release 2.0.4 under preparation

P@t wrote:

VDigital wrote:

Code:

#22 2009-10-10 09:31:00

Re: release 2.0.4 under preparation

#23 2009-10-10 14:29:07

Re: release 2.0.4 under preparation

#24 2009-10-10 14:49:38

Re: release 2.0.4 under preparation

#25 2009-10-10 18:15:34

Re: release 2.0.4 under preparation

#26 2009-10-10 22:06:27

Re: release 2.0.4 under preparation

P@t wrote:

P@t wrote:

#27 2009-10-10 22:30:36

Re: release 2.0.4 under preparation

Eric wrote:

#28 2009-10-10 22:51:44

Re: release 2.0.4 under preparation

#29 2009-10-11 01:30:08

Re: release 2.0.4 under preparation

#30 2009-10-11 02:55:02

Re: release 2.0.4 under preparation

Board footer