Hi Hansi,

Nice to see that PostgreSQL is interesting to users. I admit that I believe SQLite is more relevant than PostgreSQL for Piwigo, but the first feedback is from a PostgreSQL user, not an SQLite user :-)

Concerning your problem of insert syntax. I was nearly sure this syntax would not work with something else than MySQL.

@nicolas : I will add a:

pwg_db_simple_insert(
    LANGUAGES_TABLE,
    array(
        'id' => 'pt_BR',
        'name' => 'Brasil [BR]',
    )
);

(simpler than mass_insert)

The problem is the same in admin/include/themes.class.php.

plg wrote:

nicolas wrote:

I propose to use the standard syntax of "INSERT INTO" :

Code:

insert into (COLUMNS) values(VALUES)

I didin't see that syntax (insert into set ...) before !

It's a matter of readibility. The "standard" syntax is less readable. This is why I've used the "insert into set" syntax (and P@t reused it in language manager).

Because yes, we like to have more readable code, I think that:

Code:

pwg_db_simple_insert(
    LANGUAGES_TABLE,
    array(
        'id' => 'pt_BR',
        'name' => 'Brasil [BR]',
    )
);

is more readable than:

Code:

$query = '
INSERT INTO '.LANGUAGES_TABLE.'
  (id, name)
  VALUES
  ("pt_BR", "Brasil [BR]")
;';
pwg_query($query);

The more you add columns, the more readable pwg_db_simple_insert is, compared to "insert into values".

And the code of pwg_db_simple_insert function is the same as the one I proposed ? If yes, it's ok for me.

Any way, languages table is missing in piwigo_structure-pgsql and piwigo_structure-sqlite.sql...
And there is still pwg_stuffs table????

nicolas, can you fix it?

nicolas wrote:

And the code of pwg_db_simple_insert function is the same as the one I proposed ? If yes, it's ok for me.

If we have a clean function pwg_db_simple_insert then we can use "insert into values" syntax, which is compatible everywhere I suppose.