In fact I realize that the language key conversion for 2.1 is a BIG pain for template developers.

We have a mapping to convert 2.0 language keys to 2.1 language keys. Would you like to send me your *.tpl files so that I can perform the substitutions and send it back to you?

plg wrote:

We correct the value in english.

Then a script do the painful job: update the key with the english value and propagate the new key to all languages.

I'm missing something here ... why do we need to change the keys?

tosca wrote:

plg wrote:

We correct the value in english.

Then a script do the painful job: update the key with the english value and propagate the new key to all languages.

I'm missing something here ... why do we need to change the keys?

there is no key anymore.

The english text is the key.

So, the key for "Ne pas répéter le diaporama" is "Not repeat the slideshow".
If you change the english text by "Do not repeat the slideshow", you have to change the french key for "Ne pas répéter le diaporama"

nicolas wrote:

The first time (what we are doing now) is a bit difficult to ckeck all keys are correct. After I cannot image we will change often keys. I think if we can't do in another way and we have to change a key, we must inform users like for upgrade per example.

:'-(
I love coding, but translation, beuark. it's something like a waste of time for me ^^;

grum wrote:

So, the key for "Ne pas répéter le diaporama" is "Not repeat the slideshow".
If you change the english text by "Do not repeat the slideshow", you have to change the french key for "Ne pas répéter le diaporama"

Yes but we are in a transitionnal stage. The idea is to prepare gettext that will make life of translator better than today. Bellieve me it will be better for you too. :-)

grum wrote:

I love coding, but translation, beuark. it's something like a waste of time for me ^^;

I will take your example to explain you it can work but only for Piwigo 2.2. I hope with that example you understand why we are doing all that awful changes.

For people who don't want technical explanations you can stop reading here ! :-)

I will take two keys for an example. With gettext, we have a master file with all keys. You should have notice that we create a new directory in language directory name templates. That master file (there will be severals ones but it's not really important for the moment) will live in that directory. I will have the two keys "Not repeat the slideshow" and "Not repeat the slideshow". My messages.pot (the master file) will be :

msgid "Not repeat the slideshow"
msgstr ""

msgid "You are not authorized to access the requested page"
msgstr ""

I want to translate that file in french and I will create a messages.po file in language/fr_FR/LC_MESSAGES. The content will be :

msgid "Not repeat the slideshow"
msgstr "Ne pas répeter le diaporama"

msgid "You are not authorized to access the requested page"
msgstr "Vous n'êtes pas autorisé à accéder à cette page"

(The contents of theses files are a bit more complex but we don't care for explanations).

grum wrote:

If you change the english text by "Do not repeat the slideshow", you have to change the french key for "Ne pas répéter le diaporama"

And it could hapens for many reasons. So for that example, I will update my master template and its content will be :

msgid "Do not repeat the slideshow"
msgstr ""

msgid "You are not authorized to access the requested page"
msgstr ""

Of course we have to update french. But we don't want to do it by hand. gettext comes with many tools to do that. Here "merge" will to the trick and the new messages.po for french will be:

#, fuzzy
msgid "Don't repeat the slideshow"
msgstr "Ne pas répeter le diaporama"

msgid "You are not authorized to access the requested page"
msgstr "Vous n'êtes pas autorisé à accéder à cette page"

Translators have to only check for fuzzy keys. Translation is correct so they remove the comment and job is done for translation.

tosca wrote:

The values should be modified easily; as for the keys, well they are nothing else than keys, and should be used for internal purpose only.

You forgot the fact that if we change a key we have to change all files that use it. It will be probably be only one but plugins or others themes can use that key. I think it's the only thing we have to take care about. For others gettext will do the job for us.

p.s : I can give my examples files and commands if someone wants.

Last edited by nicolas (2010-04-02 21:45:59)

tosca wrote:

nicolas wrote:

tosca wrote:

The values should be modified easily; as for the keys, well they are nothing else than keys, and should be used for internal purpose only.

You forgot the fact that if we change a key we have to change all files that use it. It will be probably be only one but plugins or others themes can use that key. I think it's the only thing we have to take care about. For others gettext will do the job for us.

I might not have said it clearly: I'm perfectly aware that the keys are ... well, keys ( ;-))  to access all the language files; that's what I called "internal purpose" as they shouldn't appear anywhere else than the code.

What I still don't understand is why we choose to have english values = keys and put impositions on english values that we don't have on other languages; even worse, as English is not the native language of anybody in the team, it is  more likely to improved/modified in the future.

I think this discussion may continue in the [Forum, topic 15739] Improve localization and internationalization

nicolas wrote:

We choose to replace old keys without meaning by key which are english value because of fallback mechanism.

That's the answer I needed to understand.