Piwigo.org

kenl · 2013-02-13 15:11:40

Hello,

Is there an escape character for commas in tag names when adding photos with addSimple?

For example, I use a tag "Smith, John" I add a photo, with the tag, to piwigo using addSimple. When viewing the photo, it is tagged 2 times with "Smith" and "John".

I've tried sending the tag as:
Smith, John
"Smith, John"

Is there a way to 'escape' the comma character?

Thanks,
Ken

flop25 · 2013-02-13 15:24:14

Hello
it seems no
"$tag_names = explode(',', $params['tags']);" :/
So I open a ticket in our bugtracker

kenl · 2013-02-13 16:05:32

Thank you.

Ken

flop25 · 2013-02-13 19:13:57

fixed
[Subversion] r20741 if you want to apply the fix now, and test

mistic100 · 2013-02-13 19:23:35

just a question : why this field is not an array ? (like tag_id field in pwg.tags.getImages)

flop25 · 2013-02-13 19:25:25

mistic100 wrote:
just a question : why this field is not an array ? (like tag_id field in pwg.tags.getImages)

Ho! Yeah... don't know... maybe historical reasons
If you have a better fix, I won't be offended ^^

mistic100 · 2013-02-13 19:34:06

we can't modify it for compatibility reasons, but why not adding an other field "tags2" or something, working like an array (and say that the first one is deprecated)

off-topic: I'm working on a small modification of reflexion.getMethodDetails allowing to add specific info for a field

flop25 · 2013-02-13 19:42:04

mistic100 wrote:
we can't modify it for compatibility reasons

yep I thought of that

mistic100 wrote:
(and say that the first one is deprecated)

but didn't think as far
Good idea finally

rvelices · 2013-02-13 20:07:17

I have a better fix
- make tags parameter as optional to accept array ( 'tags' => array('default' => null, 'flags' => WS_PARAM_ACCEPT_ARRAY),
- then

Code:

...
if (is_array(params[tags]))
tag_names = params[tags]
else
tag_names = explode(',', params[tags])

and that it is. fully backward compatible and properly working ...

mistic100 · 2013-02-13 20:18:22

this API system is so well coded ! :-)

flop25 · 2013-02-13 20:21:54

rvelices wrote:
I have a better fix
- make tags parameter as optional to accept array ( 'tags' => array('default' => null, 'flags' => WS_PARAM_ACCEPT_ARRAY),
- then
Code:
...
if (is_array(params[tags]))
tag_names = params[tags]
else
tag_names = explode(',', params[tags])
and that it is. fully backward compatible and properly working ...

and so spoke the voice of wisdom ^^

let me still add the escape of the comma for the string

Piwigo.org

Announcement

#1 2013-02-13 15:11:40

pwg.images.addSimple - escape character for commas in tags

#2 2013-02-13 15:24:14

Re: pwg.images.addSimple - escape character for commas in tags

#3 2013-02-13 16:05:32

Re: pwg.images.addSimple - escape character for commas in tags

#4 2013-02-13 19:13:57

Re: pwg.images.addSimple - escape character for commas in tags

#5 2013-02-13 19:23:35

Re: pwg.images.addSimple - escape character for commas in tags

#6 2013-02-13 19:25:25

Re: pwg.images.addSimple - escape character for commas in tags

mistic100 wrote:

#7 2013-02-13 19:34:06

Re: pwg.images.addSimple - escape character for commas in tags

#8 2013-02-13 19:42:04

Re: pwg.images.addSimple - escape character for commas in tags

mistic100 wrote:

mistic100 wrote:

#9 2013-02-13 20:07:17

Re: pwg.images.addSimple - escape character for commas in tags

Code:

#10 2013-02-13 20:18:22

Re: pwg.images.addSimple - escape character for commas in tags

#11 2013-02-13 20:21:54

Re: pwg.images.addSimple - escape character for commas in tags

rvelices wrote:

Code:

Board footer