Piwigo.org

mistic100 · 2013-11-21 19:52:25

Hello,

I created the AdminTools plugin http://piwigo.org/svn/extensions/AdminTools (only compatible with trunk)

it adds a toolbar on public pages offering some admin tasks :
- "edit" and "add to caddie" for albums (existing buttons are removed from the page)
- "edit", "add to caddie" and "representative" for photos (existing buttons are removed too)
- a toolbox with the same functionnalities as AdminMultiView
- a quick access to main admin page
- (any more ideas ?)

currently the "quick edit" feature is not done, I plan a Colorbox with a form (plg will perhaps do it)
and I have to add a nice "Done" message for "add to caddie" and "representative"

If possible I would like to integrate it as a default plugin (thus remove AdminMultiView)

plg · 2013-11-21 20:16:38

How can you introduce your plugin without a screenshot? ;-)

opened:

closed:

mistic100 · 2013-11-21 20:58:11

some ideas

- add a button on album page "Add photos", now possible with the changes made msalik and integrated by plg
- add a button on photo page "manage comments" but would need an input parameter on admin.php?page=comments

flop25 · 2013-11-21 22:32:49

alléluia alléluiaaa!
Thx god Mistic100 for your mercy!

^^

Eric · 2013-11-21 22:48:37

Wow !! Very great job, thx mistic100 !

:-)

rvelices · 2013-11-26 05:58:36

Really really nice. A lot better than multi view. I also have my wish list... :-)
- crash invalid sql if current album has a null representative
- I find that making sql requests and sending to the browser the list of users, themes, languages, and full autocompletion tags on every page hit is overkill as some of these lists are potentially long (on my small phone the pages with the bar are visibly a lot slower to load and render). Maybe load them with ajax ws when clicking on tools or quick edit ?
- unusable with my theme on mobile devices
- if panel closed, the open icon covers my menu icon and title bar. Would you be ok to move the closed icon to lets say top 25% and left 0 ?
- if panel opened, it goes on 2 or 3 lines and the page title is completely hidden. Maybe hide the text and leave only icons through css media queries?

Thanks

mistic100 · 2013-11-26 10:28:26

Your two last points are about smartpocket ?

rvelices · 2013-11-26 11:34:57

mistic100 wrote:
Your two last points are about smartpocket ?

My theme, but I think it also goes for smart pocket ...

mistic100 · 2013-11-26 11:41:49

I didn't test on smartpocket,
it certainly fails when I try to push the body down (playing with "margin-top" or "top" if position:absolute)

can you send me a copy of your theme ?

move the closed icon to lets say top 25% and left 0

isn't this above the menubar on many themes ? including elegant

flop25 · 2013-11-26 11:49:21

The theme should adapt themself to the admin bar, because that bar will certainly be enhanced with more features and integrated in the futur

rvelices · 2013-12-10 11:29:06

3 more wishes in order of importance:

1. fatal error picture page when the photo doesn't exist or no permissions (because admintools_add_public_controller is on page_header which is also called in case of page_no_found() or access_denied()). Proposition: test

Code:

if (script_basename() == 'picture' && empty($page['current'])) return;

2. admin toolbar is also added on independent pages of plugins (ROOT_PATH = ../../ , PLGINS_PATH = ../../plugins/ ). The issue is that combine_css and combine_script expect a path relative to the root gallery. Proposition: replace in the tpl path=$ADMINTOOLS_PATH|cat:' with path='plugins/AdminTools/

3. we make systematically the query SELECT added_by in admintools_save_picture but most of the time is useless because there is no request to delete or update the photo.

mistic100 · 2013-12-10 11:38:02

1. I can not reproduce it...
what is the exact error ?
and you mean $picture['current'] right ? (not $page)

2. ok

3. ok

mistic100 · 2013-12-10 11:40:54

mistic100 wrote:
1. I can not reproduce it...

I was not logged :-) so blocked before

rvelices · 2013-12-10 11:52:34

mistic100 wrote:
2. ok

Thanks, but I think 2 is not fixed because ADMINTOOLS_PATH is also used in include_once and template->set_filename and your commit fixed the tpl issue but broke these ones ...

mistic100 · 2013-12-10 12:02:19

these path issues are awfull !!

plugins should not even have front end files in their directory ! how rv_gmaps and osm work is even better

edit: damn ! combine_css and combine_script do not accept absolute path (I guess FileCombiner prepends the path with './'), it would be a nice solution to always provide abs paths to the template as we do for include function

my problem is that what to minimize hard coded paths

Piwigo.org

Announcement

#1 2013-11-21 19:52:25

Admin Tool Bar

#2 2013-11-21 20:16:38

Re: Admin Tool Bar

#3 2013-11-21 20:58:11

Re: Admin Tool Bar

#4 2013-11-21 22:32:49

Re: Admin Tool Bar

#5 2013-11-21 22:48:37

Re: Admin Tool Bar

#6 2013-11-26 05:58:36

Re: Admin Tool Bar

#7 2013-11-26 10:28:26

Re: Admin Tool Bar

#8 2013-11-26 11:34:57

Re: Admin Tool Bar

mistic100 wrote:

#9 2013-11-26 11:41:49

Re: Admin Tool Bar

#10 2013-11-26 11:49:21

Re: Admin Tool Bar

#11 2013-12-10 11:29:06

Re: Admin Tool Bar

Code:

#12 2013-12-10 11:38:02

Re: Admin Tool Bar

#13 2013-12-10 11:40:54

Re: Admin Tool Bar

mistic100 wrote:

#14 2013-12-10 11:52:34

Re: Admin Tool Bar

mistic100 wrote:

#15 2013-12-10 12:02:19

Re: Admin Tool Bar

Board footer