Hi,

In include/functions_metadata.inc.php we assume that if we find non ASCII characters and if string doesn't qualify as UTF-8 then we apply a iso-8859-1 to utf-8 conversion.

A user has reported a problem with symbol "oe" (as a single character, ie "ligature") : the string is not displayed in Piwigo, but still exists (as an invisible character).

I have tried to replace iso-8859-1 by windows-1252 in function clean_iptc_value and it works fine on this photo. Then I wondered if you could detect Windows-1252 or ISO-8859-1 but it doesn't work with mb_detect_encoding. Then I read on http://stackoverflow.com/questions/3714 … 1-to-utf-8 :

[difference between Windows-1252 and ISO-8859-1] The characters 0x80-0x9F will not convert correctly. But these are control characters which are almost never used.

That means that if you use windows-1252 as origin encoding for conversion instead of iso-8859-1 it should be good for both windows-1252 and iso-8859-1 strings.

Do you think it's OK for changing:

[pierrick@pierrick-desktop] ~/public_html/piwigo/dev/branches/2.5                                                                                                                                                                                                                      
$ svn diff include/
Index: include/functions_metadata.inc.php
===================================================================
--- include/functions_metadata.inc.php  (revision 23497)
+++ include/functions_metadata.inc.php  (working copy)
@@ -103,7 +103,7 @@
     if ( ($qual = qualify_utf8($value)) != 0)
     {// has non ascii chars
       $value = convert_charset( $value,
-        $qual>0 ? 'utf-8' : 'iso-8859-1',
+        $qual>0 ? 'utf-8' : 'windows-1252',
         get_pwg_charset() );
     }
   }