Announcement

#16 2013-12-10 15:12:49

rvelices
Piwigo Team
2005-12-29
1960

Re: Admin Tool Bar

thanks for the modifications.

mistic100 wrote:

edit: damn ! combine_css and combine_script do not accept absolute path (I guess FileCombiner prepends the path with './'), it would be a nice solution to always provide abs paths to the template as we do for include function

It's normal because of
1. question_mark_in_url
2. ability not to combine files means we must get an url from a path

Because of these 2 points, combine requires a path relative to the root install and it manages then to use it as an url or a path to generate a combined file ...

Offline

 

#17 2013-12-10 15:22:55

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: Admin Tool Bar

rvelices wrote:

ability not to combine files means we must get an url from a path

ah ! good point :)

Offline

 

#18 2013-12-16 21:17:49

rvelices
Piwigo Team
2005-12-29
1960

Re: Admin Tool Bar

Re--hello. Still me :-)
A couple of more things please :

1. colorbox on mobile is larger than screen. Sol: add maxWidth: "100%" in options when calling colorbox
2. picture page - there is an unnecessary query in admintools_add_public_controller lines 80-83 - $page['category']['representative_picture_id'] contains already the required information
3. switch_lang_to(get_default_language()); generates an unnecessary sql query - multi view could easily know if it changed the language of the user (in addition it would work with several admins having their own language) Example

Code:

function original_language()
{
 if (isset($this->user['language']) && isset($this->data['language']) && $this->user['language'] != $this->data['language'])
   return $this->user['language'];
 return false;
}
// need to also save the language on user_init() >>>

4. too bad that admin links from the toolbar do not work while viewing as guest ( maybe we should not switch the user if IN_ADMIN is defined - but switch the language ...)
5.  multiview get_clean_url - array_keys($this->data) is completely useless because all get params have a prefix ato, but this->data do not (I end up with tags.php?ato_lang=de_DE&ato_lang=fr_FR)


Thanks a lot ...

Offline

 

#19 2013-12-17 11:59:25

mistic100
Former Piwigo Team
Lyon (FR)
2008-09-27
3277

Re: Admin Tool Bar

I'll do the changes

just about your point 3 : the time consumed by the SQL query is totally negligible compared to filesystem accesses to reload language files (add switch_lang_to has its own cache, no gain here)

Offline

 

#20 2015-04-02 11:03:56

bocman
Member
2015-02-18
42

Re: Admin Tool Bar

Hello!
I would like to add in tools bar link to quick synchronization.
How can I do it?

Thank you!

Offline

 

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2022 · Contact