Announcement

#1 2019-10-10 19:01:18

baumbaum
Member
2019-10-10
5

the administration batch page is not working

Hello/Hi/Greetings,

   after the upgrade to 2.10 (from 2.9) in the administration section photos/batch (Fotos/Stapelverarbeitung) the batch page is not working. E. g. I can not select an album in the filter section of this page. Then in action section on this page some functions are not working. E.g. I select "Mehrfache Bildgrößen generieren" (generate multiple file sizes), then the "everything" and "nothing" action is not working. After activating some filesizes directly the orange button "Aktion anwenden" starts nothing.

Sincerely
yours Andreas

Piwigo version: 2.10
PHP version: 7.3
MySQL version: 10.2.25-MariaDB
Piwigo URL:

Offline

 

#2 2019-10-11 04:21:59

phuriousgeorge
Member
2019-10-11
3

Re: the administration batch page is not working

I can confirm issues with batch manager as well with 2.10.0. I cannot delete duplicate photos via the batch manager. I I receive the banner with "confirmation" that the images were deleted, but they show up when the page is refreshed.  Individually editing the photo and deleting from there does indeed delete the photo.

Offline

 

#3 2019-10-11 10:05:25

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13605

Re: the administration batch page is not working

Hello,

Which web browser do you use? Can you try another one and say if it works any better?

Offline

 

#4 2019-10-11 12:53:47

mphased
Member
2019-10-11
4

Re: the administration batch page is not working

Hi,

I don't mean to cross-post but I can confirm a similar issue/behaviour on my Piwigo 2.10.0 (updated this morning).

I don't think it is a browser specific error (at least in my case) because my browser console reports a syntax error in combined js file). See more info here: [Forum, post 174577 by mphased in topic 29631] "Some checksums are missing." after upgrade to 2.10

But right, as plg said, the others could use different browsers and report it here, just to be sure...

Regards
mphased

Offline

 

#5 2019-10-11 16:22:55

baumbaum
Member
2019-10-10
5

Re: the administration batch page is not working

I use Firefox 69.0.2. And I tried it with Chrome 77... It's the same with both browsers.

Offline

 

#6 2019-10-11 16:38:38

phuriousgeorge
Member
2019-10-11
3

Re: the administration batch page is not working

I didn't think it'd be related to mphased reference, but I checked my console and saw"Uncaught SyntaxError: Unexpected token '<'".  With the Admin Tools plugin, if I disabled "Combine JS&CSS", deletions and other actions in the batch manager worked correctly.

Offline

 

#7 2019-10-11 17:16:11

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13605

Re: the administration batch page is not working

phuriousgeorge wrote:

I checked my console and saw"Uncaught SyntaxError: Unexpected token '<'".

As I can't reproduce the bug, I really need to know the exact place of this error. Does [Forum, post 174580 by plg in topic 29631] "Some checksums are missing." after upgrade to 2.10 helps to solve the bug?

Offline

 

#8 2019-10-11 17:21:36

baumbaum
Member
2019-10-10
5

Re: the administration batch page is not working

Is "1xp55av.js:416:384" helpful to find the mentioned code error?

Offline

 

#9 2019-10-11 17:24:59

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13605

Re: the administration batch page is not working

baumbaum wrote:

Is "1xp55av.js:416:384" helpful to find the mentioned code error?

not really. I need to see what's in file 1xp55av.js, line 416, column 384. Can you open this file (in directory _data/combined) and move to this point?

Offline

 

#10 2019-10-11 17:35:24

baumbaum
Member
2019-10-10
5

Re: the administration batch page is not working

yes! I can!

line 416:

else{var redirect_to='admin.php?page=batch_manager';redirect_to+='&action=delete_orphans';redirect_to+='&nb_orphans_deleted='+jQuery('#orphans_to_delete').data('origin');document.location=redirect_to;}},error:function(XMLHttpRequest){jQuery('#orphans_deletion').hide();jQuery('#orphans_deletion_error').show().html('error '+XMLHttpRequest.status+' : '+XMLHttpRequest.statusText);}});}<br />

I will attach the js.file.

Offline

 

#11 2019-10-11 18:00:51

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13605

Re: the administration batch page is not working

OK, good step. So you have a very unexpected "<br />" at the end of your combined JS file. This is the reason why you have a JS error.

For now, I understand where this "<br />" comes from :-/

Offline

 

#12 2019-10-11 18:03:26

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13605

Re: the administration batch page is not working

Do you have something else after "<br />" ?

My intuition tells me you are running PHP 7.3 and fall into the Jshrink bug, see [Github] Piwigo issue #1089

Can you copy file include/jshrink.class.php from a fresh Piwigo 2.9.5 into your Piwigo 2.10.0 installation?

Offline

 

#13 2019-10-11 18:09:35

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13605

Re: the administration batch page is not working

OK, I think I reproduced it with a PHP 7.3.10 installation. Here is what I have:

[...] jQuery('#orphans_deletion_error').show().html('error '+XMLHttpRequest.status+' : '+XMLHttpRequest.statusText);}});}<br />
<b>Deprecated</b>:  strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in <b>/var/www/html/piwigo/include/jshrink.class.php</b> on line <b>195</b><br />;

We're right into the Jshrink bug.

I confirm the bug disappears when I use jshrink.class.php copied from Piwigo 2.9.5

Offline

 

#14 2019-10-11 18:10:34

phuriousgeorge
Member
2019-10-11
3

Re: the administration batch page is not working

plg wrote:

phuriousgeorge wrote:

I checked my console and saw"Uncaught SyntaxError: Unexpected token '<'".

As I can't reproduce the bug, I really need to know the exact place of this error. Does [Forum, post 174580 by plg in topic 29631] "Some checksums are missing." after upgrade to 2.10 helps to solve the bug?

I turned combine setting back on and made the change to add the bracket as stated in your post and it does appear to be working for me now.

Offline

 

#15 2019-10-11 18:42:47

baumbaum
Member
2019-10-10
5

Re: the administration batch page is not working

yes! it's working now! thanks

Offline

 

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2022 · Contact