🌍
English
Announcement
- [2024-12-20] Piwigo 15.3.0 : same as 15.2.0 but compatible with PHP 7
- [2024-12-19] Piwigo 15.2.0 : better user activation and many fixes
- [2024-11-11] Piwigo 15.1.0 : small fixes and what's new popup
- [2024-10-22] Piwigo 15
- [2024-09-23] Piwigo 15.0.0RC1, almost there
#1 2021-01-19 15:08:30
- tomasz
- Member
- New Jersey, US
- 2021-01-19
- 7
[resolved] infinite loop?
While on a screen having "previous" and "next" links, I am getting "infinite loop?" message.
I do not have this issue on a Windows server, PHP.4.9 and MySQL 5.7.28.
My environment is as follows:
Piwigo 11.0.0 Check for upgrade
Operating system: Linux
PHP: 7.4.14 (Show info) [2021-01-19 09:04:42]
MySQL: 5.5.62-log [2021-01-19 09:04:42]
Graphics Library: External ImageMagick 6.9.10-23
I am running MySQL with InnoDB engine.
Piwigo URL: http://piwigo.odkrywcy.com/
Offline
#2 2021-01-19 15:25:49
- plg
- Piwigo Team
- Nantes, France, Europe
- 2002-04-05
- 13882
Re: [resolved] infinite loop?
OK, I reproduce on my install. You can't reach page 2 if you have several pages of albums. No problem if you have several pages of photos. Having several pages of albums is not so common, but still that's a real issue. Piwigo 11.1.0 will come fast...
Offline
#3 2021-01-19 22:29:07
- fingertrouble
- Member
- 2021-01-19
- 2
Re: [resolved] infinite loop?
Same here, having this very issue on all pages. Disabled all plugins, changed themes, Tried purging user caches. Purge sessions, Purge unused notification feeds, Purge compiled templates...all to no joy.
Piwigo 11.0.0
Operating system: Linux
PHP: 7.4.14 (Show info) [2021-01-19 21:28:35]
MySQL: 5.5.5-10.2.36-MariaDB-1:10.2.36+maria~bionic [2021-01-19 21:28:35]
Graphics Library: ImageMagick 6.9.7-4
Offline
#4 2021-01-20 00:12:10
- dellumber
- Member
- 2019-06-16
- 1
Re: [resolved] infinite loop?
I get the message "infinite loop?" whenever I click on "display all photos in all sub-albums"
Piwigo 11.0.0 Check for upgrade
Operating system: Linux
PHP: 7.3.19-1~deb10u1 (Show info) [2021-01-19 18:11:08]
MySQL: 5.5.5-10.3.27-MariaDB-0+deb10u1 [2021-01-19 18:11:08]
Graphics Library: External ImageMagick 6.9.10-23
Offline
#6 2021-01-20 12:02:50
- plg
- Piwigo Team
- Nantes, France, Europe
- 2002-04-05
- 13882
Re: [resolved] infinite loop?
The good news is:
1) easy to avoid, by displaying more albums per page (setting on [Admin>Configuration>Options>Display]
2) easy to fix (like, very easy, 2 minutes of search in the code I modified...)
Code:
[2021-01-20 12:00:18] ~/git/Piwigo (11.x) $ git diff
diff --git a/include/functions_url.inc.php b/include/functions_url.inc.php
index 676651b..68306c3 100644
--- a/include/functions_url.inc.php
+++ b/include/functions_url.inc.php
@@ -453,6 +453,8 @@ function parse_section_url( $tokens, &$next_token)
strpos($tokens[$next_token], 'created-')===0
or strpos($tokens[$next_token], 'posted-')===0
or strpos($tokens[$next_token], 'start-')===0
+ or strpos($tokens[$next_token], 'startcat-')===0
+ or 'flat' == $tokens[$next_token]
)
{
break;The bad news is:
* should we release 11.1.0 right now or wait for a few more bugs to be discovered
Offline
#7 2021-01-20 12:30:05
- executive
- Member
- 2017-08-16
- 1233
Re: [resolved] infinite loop?
I think you should give it some time. It's better than having to do two or three updates in a row
Offline
#8 2021-01-20 13:52:38
- erAck
- Only trying to help
- 2015-09-06
- 2186
Re: [resolved] infinite loop?
Proposal: add other fixes and release on Friday as on the weekend more upgrades are likely to happen..
Running Piwigo at https://erack.net/gallery/
Offline
#9 2021-01-20 14:38:40
- plg
- Piwigo Team
- Nantes, France, Europe
- 2002-04-05
- 13882
Re: [resolved] infinite loop?
OK, I'm focusing on urgent fixes for the rest of the week and I will push a new release before the week-end, good idea !
Offline
#10 2021-01-20 16:00:26
- fingertrouble
- Member
- 2021-01-19
- 2
Re: [resolved] infinite loop?
Thanks, that fix works for now - I await the update!
Offline
#11 2021-01-20 16:02:00
- Contact
- Member
- https://piskun.ca/
- 2021-01-20
- 2
Re: [resolved] infinite loop?
plg wrote:
I will push a new release before the week-end
Thank you for your quick efforts
Offline
#12 2021-01-20 16:11:17
- arrmgt
- Member
- 2021-01-20
- 4
Re: [resolved] infinite loop?
I did plg's "2) easy-to-fix" edit, and it works fine. Thanks.
Offline
#13 2021-01-22 01:05:11
- bear504
- Member
- 2021-01-22
- 1
Re: [resolved] infinite loop?
Wow thank you greatly! I just upgraded my gallery, noticed this bug and here is a solution. Edited the php file, added the 2 lines and works beautifully.
I joined just to say this. Thank You! :)
plg wrote:
The good news is:
1) easy to avoid, by displaying more albums per page (setting on [Admin>Configuration>Options>Display]
2) easy to fix (like, very easy, 2 minutes of search in the code I modified...)Code:
[2021-01-20 12:00:18] ~/git/Piwigo (11.x) $ git diff diff --git a/include/functions_url.inc.php b/include/functions_url.inc.php index 676651b..68306c3 100644 --- a/include/functions_url.inc.php +++ b/include/functions_url.inc.php @@ -453,6 +453,8 @@ function parse_section_url( $tokens, &$next_token) strpos($tokens[$next_token], 'created-')===0 or strpos($tokens[$next_token], 'posted-')===0 or strpos($tokens[$next_token], 'start-')===0 + or strpos($tokens[$next_token], 'startcat-')===0 + or 'flat' == $tokens[$next_token] ) { break;The bad news is:
* should we release 11.1.0 right now or wait for a few more bugs to be discovered
Offline
#15 2021-01-22 21:20:45
- Contact
- Member
- https://piskun.ca/
- 2021-01-20
- 2
Re: [resolved] infinite loop?
Yes, just released new version 11.1.0 fixes infinite loop bug and at first glance all else looks good.
Offline