Announcement

#1 2021-02-06 16:08:48

erAck
Only trying to help
2015-09-06
1998

Upgrade to 11.3.0 omitted admin/include/functions.php

Hello/Hi/Greetings,

The upgrade from 11.2.0 to 11.3.0 omitted to update file admin/include/functions.php, or rather, its latest change of [Github] Piwigo commit ea69988e is missing, which doesn't harm though because the accompanying part in admin/intro.php that removes the call to get_fs_directory_size() is included. The plugins/check_files_integrity/data/piwigo-11.3.0-sums.txt checksum is done for the 11.3.0 tag of admin/include/functions.php so leads to a mismatch, which is how I stumbled upon this. The changed file is also included in the 11.3.0 release zip.

So again, nothing broken functionality-wise, just odd, and worth a check in the upgrade packaging process.


Running Piwigo at https://erack.net/gallery/

Offline

 

#2 2021-02-09 11:57:33

plg
Piwigo Team
Nantes, France, Europe
2002-04-05
13786

Re: Upgrade to 11.3.0 omitted admin/include/functions.php

Hi erAck,

Perfectly right and I was expecting such a "problem" at some point. What happened? There is no change on this file when we compare version 11.0.0 and 11.3.0, even if some changes were introduced in 11.1.0 and 11.2.0. Piwigo 11.3 have "reverted" to the file as it was in 11.0, sort of.

Code:

[2021-02-09 11:53:33] /tmp/11.3.0-orig $ md5 */admin/include/functions.php
MD5 (1100/admin/include/functions.php) = 5eca738353d3c781f14d048ddc761ad5
MD5 (1110/admin/include/functions.php) = 3334f1aa93ee36449fd5993bba9338d1
MD5 (1120/admin/include/functions.php) = 2f67bee277235a163ba13861834c6af1
MD5 (1130/admin/include/functions.php) = 5eca738353d3c781f14d048ddc761ad5
MD5 (Piwigo-git/admin/include/functions.php) = 5eca738353d3c781f14d048ddc761ad5

When we create the "patch" to upgrade from 11.x to 11.3, we compare 11.0.0 to 11.3.0, without taking intermediate versions into account, assuming the probability of such a revert is very low.

With 11.3.0, we've fallen in the very specific exception!

As you said, nothing is broken since there is just one extra useless function in this file, that is used nowhere in the code (since intro.php was in the patch)

Offline

 

#3 2021-02-09 12:17:58

jkroald
Member
2021-01-28
6

Re: Upgrade to 11.3.0 omitted admin/include/functions.php

HI!
I've just tested the upgrade to 11.3.0 and got this warnings of the upgrade script:

Update to Piwigo 11.3.0
Following plugins may not be compatible with the new version of Piwigo:
Automatic Size
Image Preview
Lightbox
Fotorama
rightClick
gdThumb
GThumb+

Following themes may not be compatible with the new version of Piwigo:
stripped

When will these plugins and the theme "stipped" be available for version 11.3.0 ?

The best from -janR

Offline

 

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact