Announcement

#1 2021-02-22 11:19:47

Alexander83706
Member
Boise
2019-07-07
148

I've just downloaded a copy of jquery.

Hello/Hi/Greetings,

I am seeing external calls to jquery routines off of my box from php modules to include mediainfo.php. I need to insure that a call to jquery routines hit the internal code rather than making more traffic on the internet.
How best to insure that happens ? 


Piwigo URL:
MySql: 5.7
PHP:

Offline

 

#2 2021-02-22 12:16:55

erAck
Only trying to help
2015-09-06
2020

Re: I've just downloaded a copy of jquery.

Find out which of your plugins wants to do such thing.  Piwigo core code AFAIK does not.


Running Piwigo at https://erack.net/gallery/

Offline

 

#3 2021-02-26 12:10:36

Alexander83706
Member
Boise
2019-07-07
148

Re: I've just downloaded a copy of jquery.

I've also got that on smarty . Can't for the life of me imagine external calls from a box that needs to focus on response speed.


php: 7.2
MySql: 5.7
WebSite:

Offline

 

#4 2021-02-26 14:44:53

flop25
Piwigo Team
2006-07-06
7037

Re: I've just downloaded a copy of jquery.

Hello
It's quite difficult to understand you, with that punctuation.

you've talked about mediainfo.php: that's needed for [extension by xbgmsharp] piwigo-videojs . If your server is limited in resources, perhaps the management of video has to be dropped.


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#5 2021-02-26 15:48:04

erAck
Only trying to help
2015-09-06
2020

Re: I've just downloaded a copy of jquery.

VideoJS already comes with its own plugins/piwigo-videojs/include/mediainfo.php though.
And that is not at all related to jQuery. In fact nothing in VideoJS loads anything from jquery.com and the plugins/piwigo-videojs/video-js-?/video*.js code emulates small parts of jQuery.
I'd guess Alexander83706 is confusing things (again).


Running Piwigo at https://erack.net/gallery/

Offline

 

#6 2021-02-26 15:53:36

flop25
Piwigo Team
2006-07-06
7037

Re: I've just downloaded a copy of jquery.

yep but the plugin might call another version of jquery?


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#7 2021-02-26 16:12:36

erAck
Only trying to help
2015-09-06
2020

Re: I've just downloaded a copy of jquery.

At least he could point us to a page where he presumes that would happen.. it's all poking in the dark.


Running Piwigo at https://erack.net/gallery/

Offline

 

#8 2021-02-26 16:23:47

flop25
Piwigo Team
2006-07-06
7037

Re: I've just downloaded a copy of jquery.

yes indeed,
a log of http calls would be great


To get a better help : Politeness like Hello-A link-Your past actions precisely described
Check my extensions : more than 30 available
who I am and what I do : http://fr.gravatar.com/flop25
My gallery : an illustration of how to integrate Piwigo in your website

Offline

 

#9 2021-02-26 16:25:20

erAck
Only trying to help
2015-09-06
2020

Re: I've just downloaded a copy of jquery.

So Piwigo admin pages have generated

Code:

<script type="text/javascript" src="themes/default/js/jquery.min.js?v11.3.0"></script>

loading the local themes/default/js/jquery.min.js whatever that might try..


Running Piwigo at https://erack.net/gallery/

Offline

 

#10 2021-02-26 16:39:27

jnashpiwigo
Piwigo Team
2014-10-21
254

Re: I've just downloaded a copy of jquery.

From my perspective, this is a due-diligence requirement on the gallery owners part.

Using plugins derived from a community is inherently risky and if one is not comfortable with that, one should take action that they deem necessary.

One of the benefits of open source is just that, 'open' - anyone is free to look at, modify, etc. to fit their demands.

With that being said, I'd say that responsibly,

1) Piwigo could state that (which I believe it does) these are plugins developed by the community and by virtue of our 'community' we choose not to sanction any usage of

2) Ensure that Piwigo addresses it owns 'house' - where responsible coding decisions are agreed upon and standards are upheld (which I believe you do)

3) Publish a 'coding standard' for plugin developers and continually enhance based on current best practices

4) Disclaimers - unnecessary, but perhaps pointing people who have concerns like these to a disclaimer that says 'use at your risk'

While some of these are more onerous than others, it's simply the case of:

Code:

Piwigo is open source photo gallery software for the web. Designed for organisations, teams and individuals.

If you want commercial, and accountable action, open source may not be your best path.

Offline

 

#11 2021-02-26 20:13:50

erAck
Only trying to help
2015-09-06
2020

Re: I've just downloaded a copy of jquery.

jnashpiwigo wrote:

If you want commercial, and accountable action, open source may not be your best path.

Sorry, but that's nonsense. Same as with closed source, for open source you'll have to find someone / some company that is willing to do paid work for you and be responsible and accountable.


Running Piwigo at https://erack.net/gallery/

Offline

 

#12 2021-02-26 20:27:07

jnashpiwigo
Piwigo Team
2014-10-21
254

Re: I've just downloaded a copy of jquery.

You're absolutely right, and better stated for sure.

Agreed

Offline

 

#13 2021-02-27 09:19:26

homdax
Member
Sweden
2015-02-02
294

Re: I've just downloaded a copy of jquery.

...and at the end of the day, closed source or open source, a developer must eat.

Offline

 

Board footer

Powered by FluxBB

github twitter newsletter Donate Piwigo.org © 2002-2024 · Contact