🌍
English
Announcement
- [2024-04-17] Piwigo 14.4.0
- [2024-04-01] Piwigo in Hobbit runes
- [2024-03-01] Piwigo 14.3.0
- [2024-01-30] Piwigo 14.2.0
- [2023-12-29] Piwigo 14.1.0
#16 2022-09-06 00:53:00
- windracer
- Member
- St. Pete, FL
- 2014-12-28
- 446
Re: 12.0.0RC2: single quote/apostrophe in photo description
ahtoagah wrote:
I tested pwg_db_real_escape_string() and it seems to work fine.
So using your examples above, I just use pwg_db_real_escape_string instead of the addslashes calls?
Offline
#17 2022-09-06 01:11:28
- windracer
- Member
- St. Pete, FL
- 2014-12-28
- 446
Re: 12.0.0RC2: single quote/apostrophe in photo description
ahtoagah wrote:
I don't use Quick Edit, but I looked into some of its files and found that piwigo/plugins/AdminTools/include/events.inc.php has a similar statement on line 315.
Thanks. I found a few other places in events.inc.php to fix as well.
Offline
#18 2022-10-14 11:39:32
- matthys
- Member
- 2014-04-02
- 188
Re: 12.0.0RC2: single quote/apostrophe in photo description
Just to be clear .. this is also not fixed in the 13 release?
Offline
#19 2022-10-14 22:50:01
- windracer
- Member
- St. Pete, FL
- 2014-12-28
- 446
Re: 12.0.0RC2: single quote/apostrophe in photo description
matthys wrote:
Just to be clear .. this is also not fixed in the 13 release?
Correct. I had to re-apply the changes after I upgraded to 13.0.
Offline
#20 2022-10-15 06:10:56
- Katryne
- Member
- 2016-12-03
- 368
Re: 12.0.0RC2: single quote/apostrophe in photo description
Hello,
I confirm that this is not fixed in PWG 13.
http://photos.katrynou.fr/ v.14.1.0 https://album.chauvigne.info/ v.13.8.0
Système d'exploitation: Linux - Hébergeur 1&1-Ionos PHP: 8.0.28 - MySQL: 5.7.38
Bibliothèque graphique: External ImageMagick 6.9.10-23
Offline
#21 2022-10-28 10:45:20
- matthys
- Member
- 2014-04-02
- 188
Re: 12.0.0RC2: single quote/apostrophe in photo description
Hmmmm, also not fixed in 13.1.0...
Today, after upgrading to 13.1.0, I got: an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Oultremont de Wégimont....
After updating the code manually it worked fine again.
Pity it was not solved in the fix release :-(
Last edited by matthys (2022-10-28 11:26:57)
Offline
#22 2022-11-17 23:46:54
- windracer
- Member
- St. Pete, FL
- 2014-12-28
- 446
Re: 12.0.0RC2: single quote/apostrophe in photo description
Looks like this has been fixed in 13.2.0. Thank you!
[Github] Piwigo commit 96a4e21a
Last edited by windracer (2022-11-17 23:47:18)
Offline
#23 2023-01-02 14:15:30
- pjsteane
- Member
- 2021-02-09
- 5
Re: 12.0.0RC2: single quote/apostrophe in photo description
windracer wrote:
Looks like this has been fixed in 13.2.0. Thank you!
[Github] Piwigo commit 96a4e21a
This does indeed seem to be fixed; however I got caught out by the auto upgrade process, and I was still getting problems with the Batch Manager unit update screen. The changes suggested earlier in this thread to file batch_manager_unit.php need to be manually reverted, or the modified file manually overwritten by a new copy, as that file hasn't changed for several versions.
Offline