Changeset 625 for trunk/admin/update.php

Timestamp:

Nov 30, 2004, 9:26:44 PM (20 years ago)

Author:

plg

Message:

• update_global_rank new function : far more intelligent update. Take into account the possiblity to have category tree not in category id ascending order

• update global_rank when moving categories among the same parent

• new function mass_updates : depending on MySQL version, create a temporary table, make one big insert and one big update by joining 2 tables (4.0.4 or above) or make 1 update per primary key

• function update_category improved for representative_picture_id check : only one useful query (equivalent to NOT EXISTS) instead of N (N = number of categories) queries

File:

• trunk/admin/update.php (modified) (4 diffs)

trunk/admin/update.php

@@ -43 +43 @@
  * (insides its sub-category), even the newer that have none at te
  * beginning. For this, ordering function selects all categories ordered by
- * rank ASC then name ASC for each uppercat. It also updates the global rank
- * which is able to order any two categorie in the whole tree
+ * rank ASC then name ASC for each uppercat.
  *
  * @returns void
@@ -59 +58 @@
 ;';
   $result = pwg_query($query);
+  $datas = array();
   while ($row = mysql_fetch_array($result))
   {
@@ -66 +66 @@
       $current_uppercat = $row['id_uppercat'];
     }
-    $query = '
-UPDATE '.CATEGORIES_TABLE.'
-  SET rank = '.++$current_rank.'
-  WHERE id = '.$row['id'].'
-;';
-    pwg_query($query);
-  }
-  // global rank update
-  $query = '
-UPDATE '.CATEGORIES_TABLE.'
-  SET global_rank = rank
-  WHERE id_uppercat IS NULL
-;';
-  pwg_query($query);
-
-  $query = '
-SELECT DISTINCT(id_uppercat)
-  FROM '.CATEGORIES_TABLE.'
-  WHERE id_uppercat IS NOT NULL
-;';
-  $result = pwg_query($query);
-  while ($row = mysql_fetch_array($result))
-  {
-    $query = '
-SELECT global_rank
-  FROM '.CATEGORIES_TABLE.'
-  WHERE id = '.$row['id_uppercat'].'
-;';
-    list($uppercat_global_rank) = mysql_fetch_array(pwg_query($query));
-    $query = '
-UPDATE '.CATEGORIES_TABLE.'
-  SET global_rank = CONCAT(\''.$uppercat_global_rank.'\', \'.\', rank)
-  WHERE id_uppercat = '.$row['id_uppercat'].'
-;';
-    pwg_query($query);
-  }
+    $data = array('id' => $row['id'], 'rank' => ++$current_rank);
+    array_push($datas, $data);
+  }
+
+  $fields = array('primary' => array('id'), 'update' => array('rank'));
+  mass_updates(CATEGORIES_TABLE, $fields, $datas);
 }
 
@@ -651 +621 @@
   $start = get_moment();
   ordering();
+  update_global_rank();
   echo get_elapsed_time($start, get_moment()).' for ordering categories<br />';
 }