Changeset 10505 for extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/dao/impl/CommentDaoImpl.java

Timestamp:

Apr 20, 2011, 5:17:02 AM (13 years ago)

Author:

anthony43

Message:

huge refactoring to introduce JiwigoException : a generic exception encapsulating low level exceptions (IOException, ProxyAuthentication, etc...)
The aim is to have, on the consumer side, just one exception to catch them all.
this refactoring may need a code review to check the changes.

File:

• extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/dao/impl/CommentDaoImpl.java (modified) (4 diffs)

extensions/jiwigo-ws-api/src/main/java/fr/mael/jiwigo/dao/impl/CommentDaoImpl.java

@@ -16 +16 @@
 import fr.mael.jiwigo.transverse.enumeration.MethodsEnum;
 import fr.mael.jiwigo.transverse.exception.FileAlreadyExistsException;
+import fr.mael.jiwigo.transverse.exception.JiwigoException;
 import fr.mael.jiwigo.transverse.exception.ProxyAuthenticationException;
 import fr.mael.jiwigo.transverse.session.SessionManager;
@@ -52 +53 @@
      * @throws ProxyAuthenticationException
      */
-    public List<Comment> list(Integer idImage) throws IOException, ProxyAuthenticationException {
-        Document doc = (sessionManager.executeReturnDocument(MethodsEnum.GET_INFO.getLabel(), "image_id", String
-                .valueOf(idImage), "comments_per_page", "100"));
+    public List<Comment> list(Integer idImage) throws JiwigoException {
+        Document doc = (sessionManager.executeReturnDocument(MethodsEnum.GET_INFO.getLabel(), "image_id",
+                String.valueOf(idImage), "comments_per_page", "100"));
         Element elementImage = (Element) doc.getDocumentElement().getElementsByTagName("image").item(0);
         Element elementComments = (Element) elementImage.getElementsByTagName("comments").item(0);
@@ -81 +82 @@
      * @throws ProxyAuthenticationException
      */
-    public String getKey(Integer idImage) throws IOException, ProxyAuthenticationException {
-        Document doc = (sessionManager.executeReturnDocument(MethodsEnum.GET_INFO.getLabel(), "image_id", String
-                .valueOf(idImage)));
+    public String getKey(Integer idImage) throws JiwigoException {
+        Document doc = (sessionManager.executeReturnDocument(MethodsEnum.GET_INFO.getLabel(), "image_id",
+                String.valueOf(idImage)));
         //      String key = doc.getRootElement().getChild("image").getChild("comment_post").getAttributeValue("key");
         Element elementImage = (Element) doc.getDocumentElement().getElementsByTagName("image").item(0);
@@ -97 +98 @@
      * @throws ProxyAuthenticationException
      */
-    public boolean create(Comment commentaire) throws IOException, ProxyAuthenticationException {
+    public boolean create(Comment commentaire) throws JiwigoException {
         String key = getKey(commentaire.getImageId());
         try {